From 22b7c84b61b5fffc7ade24ef2e3f9d6040040a15 Mon Sep 17 00:00:00 2001 From: Gerrit User 35022 <35022@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Mon, 8 Apr 2024 19:16:26 +0000 Subject: [PATCH] Update patch set 3 Patch Set 3: (1 comment) Patch-set: 3 --- 9821652bc8174cc8a037b160421af23992a7dc7e | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 9821652bc8174cc8a037b160421af23992a7dc7e diff --git a/9821652bc8174cc8a037b160421af23992a7dc7e b/9821652bc8174cc8a037b160421af23992a7dc7e new file mode 100644 index 00000000..4a52851e --- /dev/null +++ b/9821652bc8174cc8a037b160421af23992a7dc7e @@ -0,0 +1,21 @@ +{ + "comments": [ + { + "unresolved": false, + "key": { + "uuid": "bb46db74_bc5291f6", + "filename": "kickstart/files/kickstart.cfg", + "patchSetId": 3 + }, + "lineNbr": 2722, + "author": { + "id": 35022 + }, + "writtenOn": "2024-04-08T19:16:26Z", + "side": 1, + "message": "I believe you will need to think about upgrade scenarios.\nThe previous release will not have the dual stack support,\nit will run the old code, I think this code will work fine for a straight upgrade process.\nBut maybe for upgrade-abort scenarios or if the active controller is running the new code and some node reboots and it is still running the old code, it may not work;\nAt this moment, the node running the old code will try to resolve the \"controller.internal\" and the active controller will answer the IP for controller.internal for IPv6 and IPv4.\n\nYou can merge this code, it as a clean solution, but in the next tasks we may need to handle these scenarios.", + "revId": "9821652bc8174cc8a037b160421af23992a7dc7e", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + } + ] +} \ No newline at end of file