starlingx
/
metal
Code Issues Proposed changes

Update patch set 2 

Patch Set 2: Code-Review-1

(1 comment)

Patch-set: 2
Reviewer: Gerrit User 28459 <28459@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, ac120a060ad118219f4ceeb4ca7a90882c26a43f
This commit is contained in:
Gerrit User 28459 2024-04-26 20:43:34 +00:00 committed by Gerrit Code Review
parent 95e707f2fa
commit 3cdcc771c0
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
975e868431fe9454762411e3c31999e7a14f1582 Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "273d76b5_c3571fcf",
"filename": "kickstart/files/centos/miniboot_controller_ks.cfg",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 28459
},
"writtenOn": "2024-04-26T20:43:34Z",
"side": 0,
"message": "This file and others are still referenced in the debian build:\n\n install -p -D -m 700 centos/miniboot_controller_ks.cfg /\u003c\u003cPKGBUILDDIR\u003e\u003e/debian/tmp/var/www/pages/feed/rel-\"\"24.03\"\"/kickstart/centos\n install: cannot stat \u0027centos/miniboot_controller_ks.cfg\u0027: No such file or directory\nmake[1]: *** [debian/rules:20: override_dh_install] Error 1\n\nLooks like these are still needed here:\n\nhttps://opendev.org/starlingx/metal/src/branch/master/kickstart/debian/deb_folder/rules#L17",
"revId": "975e868431fe9454762411e3c31999e7a14f1582",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}