Update patch set 2

Patch Set 2: Code-Review+1

(4 comments)

Patch-set: 2
Reviewer: Gerrit User 28464 <28464@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+1, ba4221a1145b7a9de6e233dd2aa4923d01088fc4
Attention: {"person_ident":"Gerrit User 28464 \u003c28464@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_28464\u003e replied on the change"}

d3c0b580215b61a7bd98246379fbe5df38e6b88d

@@ -0,0 +1,90 @@
+{
+  "comments": [
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "8102a7ce_f0dde7a2",
+        "filename": "/COMMIT_MSG",
+        "patchSetId": 2
+      },
+      "lineNbr": 14,
+      "author": {
+        "id": 28464
+      },
+      "writtenOn": "2024-02-09T13:51:52Z",
+      "side": 1,
+      "message": "This test case sounds like you expect pmond to start the ipsec-server process.\nIs that true ? If so, that\u0027s a problem. \n\nsystemd should start the process, pmond just monitors and restarts it if it fails.",
+      "range": {
+        "startLine": 14,
+        "startChar": 28,
+        "endLine": 14,
+        "endChar": 57
+      },
+      "revId": "d3c0b580215b61a7bd98246379fbe5df38e6b88d",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "1f4f7daf_2c49690c",
+        "filename": "/PATCHSET_LEVEL",
+        "patchSetId": 2
+      },
+      "lineNbr": 0,
+      "author": {
+        "id": 28464
+      },
+      "writtenOn": "2024-02-09T13:51:52Z",
+      "side": 1,
+      "message": "Can boost to +2 once comments/questions are addressed.",
+      "revId": "d3c0b580215b61a7bd98246379fbe5df38e6b88d",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "c615d7b0_51dd772a",
+        "filename": "mtce-control/src/scripts/ipsec-server.conf",
+        "patchSetId": 2
+      },
+      "lineNbr": 3,
+      "author": {
+        "id": 28464
+      },
+      "writtenOn": "2024-02-09T13:51:52Z",
+      "side": 1,
+      "message": "I assume this is the systemd service file name.",
+      "range": {
+        "startLine": 3,
+        "startChar": 11,
+        "endLine": 3,
+        "endChar": 23
+      },
+      "revId": "d3c0b580215b61a7bd98246379fbe5df38e6b88d",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "73b05184_f2cff25f",
+        "filename": "mtce-control/src/scripts/ipsec-server.conf",
+        "patchSetId": 2
+      },
+      "lineNbr": 6,
+      "author": {
+        "id": 28464
+      },
+      "writtenOn": "2024-02-09T13:51:52Z",
+      "side": 1,
+      "message": "Do you want pmond to notify maintenance to reboot the node if this process persistently fails ? If so then this needs to be critical. A major will only get you an alarm and node degrade.",
+      "range": {
+        "startLine": 6,
+        "startChar": 11,
+        "endLine": 6,
+        "endChar": 26
+      },
+      "revId": "d3c0b580215b61a7bd98246379fbe5df38e6b88d",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    }
+  ]
+}