From b4599522c16bb5e2fd1c233d8cf68257be44c889 Mon Sep 17 00:00:00 2001
From: Shrikumar Sharma <shrikumar.sharma@windriver.com>
Date: Tue, 31 May 2022 10:08:13 -0400
Subject: [PATCH] Remote subcloud install failure in post-install script

When the kickstart tries to download packages_list from the
system controller, wget fails because the parameter to its
"-O" argument needs the full file path (including the file
name) as opposed to the full path to the directory that the
file resides in.

The argument has been fixed to use the full path name of the
file.

Test Plan:
PASS: Verify that the remote subcloud successfully downloads the
      file and installation passes.

Closes-Bug: 1976384

Signed-off-by: Shrikumar Sharma <shrikumar.sharma@windriver.com>
Change-Id: I65b6bd66e62e7353e33f2694ca5bf99d413df836
---
 bsp-files/kickstarts/post_miniboot_controller.cfg | 2 +-
 bsp-files/kickstarts/post_pxeboot_controller.cfg  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/bsp-files/kickstarts/post_miniboot_controller.cfg b/bsp-files/kickstarts/post_miniboot_controller.cfg
index c33e8128..8ba4003e 100644
--- a/bsp-files/kickstarts/post_miniboot_controller.cfg
+++ b/bsp-files/kickstarts/post_miniboot_controller.cfg
@@ -534,7 +534,7 @@ else
     # so get it from the system controller.
     wlog "${KS} downloading packages_list from the system controller"
     wget ${NOVERIFYSSL_WGET_OPT} ${pkg_url}/${DEST_PKG_FILE} \
-         -O ${PKG_FILE_LOC} \
+         -O ${PKG_FILE_LOC}/${DEST_PKG_FILE} \
          -o $anaconda_logdir/${PKG_FILE}.log \
          || report_post_failure_with_logfile $anaconda_logdir/${PKG_FILE}.log
 fi
diff --git a/bsp-files/kickstarts/post_pxeboot_controller.cfg b/bsp-files/kickstarts/post_pxeboot_controller.cfg
index d9c4b6fe..b4302509 100644
--- a/bsp-files/kickstarts/post_pxeboot_controller.cfg
+++ b/bsp-files/kickstarts/post_pxeboot_controller.cfg
@@ -106,7 +106,7 @@ if [ mountpoint -q /mnt/sysimage ]; then
     fi
 
     wlog "${KS} Downloading from ${feed_url} to ${pkg_file_loc}/${pkg_file}"
-    wget ${NOVERIFYSSL_WGET_OPT} -O ${pkg_file_loc} ${feed_url}/${pkg_file} \
+    wget ${NOVERIFYSSL_WGET_OPT} -O ${pkg_file_loc}/${pkg_file} ${feed_url}/${pkg_file} \
          -o $anaconda_logdir/${pkg_file}.log \
          || wlog "${KS} Failed to download packages_list from controller"