starlingx
/
metal
Code Issues Proposed changes

Change mtcInfo log in mtcCtrlMsg.cpp to a dlog 

The mtcInfo message log was enhanced to include the payload in a
previous update without realizing that message contained the target
BMC's username and password.

This update switches that log to a debug (not enabled by default) log
to avoid revealing provisioned BMC crediatials in the mtce logs.

Test Plan:

PASS: Verify mtce package build
PASS: Verify mtcInfo log with bmc info payload is no longer logged.

Story: 2010940
Task: 49857
Change-Id: I35db04e9292471d92c24c98922350cfb72b5035e
This commit is contained in:
Eric MacDonald 2024-04-11 17:16:59 +00:00
parent 89766131af
commit 97092bd38b
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
mtce/src/maintenance/mtcCtrlMsg.cpp
View File

@ -677,7 +677,7 @@ int send_mtc_cmd ( string & hostname, int cmd , int interface, string json_dict
mtc_cmd.cmd = cmd ;
mtc_cmd.num = 0 ;
data = "{\"mtcInfo\":" + json_dict + "}";
ilog("%s mtc info update: %s", hostname.c_str(), data.c_str());
dlog("%s mtc info update: %s", hostname.c_str(), data.c_str());
rc = PASS ;
break ;
}