starlingx
/
metal
Code Issues Proposed changes

Update patch set 3 

Patch Set 3: -Code-Review

(1 comment)

Patch-set: 3
Label: Code-Review=0, 41eac6eabefb37424b71bde589a1d3149e740fad
Attention: {"person_ident":"Gerrit User 28676 \u003c28676@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_28676\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 28464 \u003c28464@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_28676\u003e replied on the change"}
This commit is contained in:
Gerrit User 28676 2024-02-15 19:20:46 +00:00 committed by Gerrit Code Review
parent b296422271
commit 982b057d91
1 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
d3c0b580215b61a7bd98246379fbe5df38e6b88d
View File

@ -71,6 +71,30 @@
"revId": "d3c0b580215b61a7bd98246379fbe5df38e6b88d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "7b2b994f_a0b17489",
"filename": "/COMMIT_MSG",
"patchSetId": 2
},
"lineNbr": 14,
"author": {
"id": 28676
},
"writtenOn": "2024-02-15T19:20:46Z",
"side": 1,
"message": "That\u0027s right. ipsec-server systemd service is not enabled. I think we can preset this service to enabled so it will be running when system boot. But just preset it enabled in aio.preset and controller.preset (it is supposed to run on controller nodes only).\nEric, do you think it needs to be preseted in lowlatency.preset as well, considering it is only running on controllers?",
"parentUuid": "c150bbda_4edd6524",
"range": {
"startLine": 14,
"startChar": 28,
"endLine": 14,
"endChar": 57
},
"revId": "d3c0b580215b61a7bd98246379fbe5df38e6b88d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {