starlingx
/
metal
Code Issues Proposed changes

Update patch set 7 

Patch Set 7:

(3 comments)

Patch-set: 7
Attention: {"person_ident":"Gerrit User 9926 \u003c9926@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_28464\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 28464 \u003c28464@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_28464\u003e replied on the change"}
This commit is contained in:
Gerrit User 28464 2024-03-28 12:16:38 +00:00 committed by Gerrit Code Review
parent 86eac3f8be
commit c152669c58
1 changed files with 60 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

60
a44610b90605ad3bacd8c36141098c43c59ee087
View File

@ -17,6 +17,24 @@
"revId": "a44610b90605ad3bacd8c36141098c43c59ee087",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "76425a5d_8c534397",
"filename": "mtce-common/src/common/nodeBase.h",
"patchSetId": 7
},
"lineNbr": 1221,
"author": {
"id": 28464
},
"writtenOn": "2024-03-28T12:16:38Z",
"side": 1,
"message": "These are not messages. There are internal pxeboot_mtcalive_monitor FSM states.",
"parentUuid": "5449bdca_e94d00ca",
"revId": "a44610b90605ad3bacd8c36141098c43c59ee087",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -40,6 +58,30 @@
"revId": "a44610b90605ad3bacd8c36141098c43c59ee087",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "fb535e02_d4964feb",
"filename": "mtce-common/src/common/nodeUtil.cpp",
"patchSetId": 7
},
"lineNbr": 1915,
"author": {
"id": 28464
},
"writtenOn": "2024-03-28T12:16:38Z",
"side": 1,
"message": "Not really since the returned pxeboot_address will not be updated and the caller will see that. I will add a warning log.",
"parentUuid": "1b464e22_aa998eef",
"range": {
"startLine": 1915,
"startChar": 5,
"endLine": 1915,
"endChar": 9
},
"revId": "a44610b90605ad3bacd8c36141098c43c59ee087",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -56,6 +98,24 @@
"message": "filestream.close() ?",
"revId": "a44610b90605ad3bacd8c36141098c43c59ee087",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "ca6f4423_0093f950",
"filename": "mtce/src/common/nodeClass.cpp",
"patchSetId": 7
},
"lineNbr": 3553,
"author": {
"id": 28464
},
"writtenOn": "2024-03-28T12:16:38Z",
"side": 1,
"message": "Yes, good one. Will update.",
"parentUuid": "380579a7_e20258f2",
"revId": "a44610b90605ad3bacd8c36141098c43c59ee087",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}