From c89f0ffa20c4403bacbc9f32ddf5d9904ff74ff1 Mon Sep 17 00:00:00 2001 From: Martin Chen Date: Fri, 19 Oct 2018 04:37:28 +0800 Subject: [PATCH] Fix resource leak issues, file not close case Partial-Bug: 1794903 Change-Id: Id6de282c27374d578a0a41869ec6a934e6675db4 Signed-off-by: Martin Chen --- mtce-common/src/daemon/daemon_files.cpp | 1 + mtce/src/rmon/rmonApi/rmon_api.c | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/mtce-common/src/daemon/daemon_files.cpp b/mtce-common/src/daemon/daemon_files.cpp index 8f2578ff..64af6e32 100755 --- a/mtce-common/src/daemon/daemon_files.cpp +++ b/mtce-common/src/daemon/daemon_files.cpp @@ -784,6 +784,7 @@ string get_shadow_signature ( char * shadowfile , const char * username, int ret = snprintf(shadowinfo, infolen, "%s", shadowEntry); if (ret >= (int)infolen) { + fclose(file_ptr); elog("insufficient space in shadow buffer(%d) for %d bytes\n", (int)infolen, ret); return ( "" ); diff --git a/mtce/src/rmon/rmonApi/rmon_api.c b/mtce/src/rmon/rmonApi/rmon_api.c index 95d01989..b6782d7e 100644 --- a/mtce/src/rmon/rmonApi/rmon_api.c +++ b/mtce/src/rmon/rmonApi/rmon_api.c @@ -328,8 +328,8 @@ int add_rmon_client ( const char * process_name_ptr, int port , const char * reg fprintf(pFile, "%s\n", rmon.rmon_rx_buf); // release write lock flock(fileno(pFile), LOCK_UN); - fclose(pFile); } + fclose(pFile); } else { @@ -442,8 +442,8 @@ int remove_rmon_client( const char * process_name_ptr, int socket ) fprintf(pFile, "%s\n", rmon.rmon_rx_buf); // release the lock flock(fileno(pFile), LOCK_UN); - fclose(pFile); } + fclose(pFile); } else { syslog (LOG_ERR, "Failed to open '%s'\n", RMON_API_DEREG_DIR );