56 lines
2.9 KiB
Plaintext
56 lines
2.9 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "e09da03c_17ed6632",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 28464
|
|
},
|
|
"writtenOn": "2024-04-20T13:39:43Z",
|
|
"side": 1,
|
|
"message": "I know that Fabiano delivered the update https://review.opendev.org/c/starlingx/metal/+/914696/4/kickstart/files/kickstart.cfg that is now being discarded for an IP address only based solution. His original solution considered very seriously this precise change but upgrades was a concern.\n\nSeems from the commit message that dual stack handling has exposed another challenge in this area causing us to flop back to the ip address only based solution.\n\nYou need to verify that this solution will work for the upgrade case, at least to the point of the upgrade install working, even if end-to-end upgrade may not be.\n\nI will +2 knowing that the dual-stack feature will eventually need to be upgrades tested.",
|
|
"revId": "9821652bc8174cc8a037b160421af23992a7dc7e",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "bb46db74_bc5291f6",
|
|
"filename": "kickstart/files/kickstart.cfg",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 2722,
|
|
"author": {
|
|
"id": 35022
|
|
},
|
|
"writtenOn": "2024-04-08T19:16:26Z",
|
|
"side": 1,
|
|
"message": "I believe you will need to think about upgrade scenarios.\nThe previous release will not have the dual stack support,\nit will run the old code, I think this code will work fine for a straight upgrade process.\nBut maybe for upgrade-abort scenarios or if the active controller is running the new code and some node reboots and it is still running the old code, it may not work;\nAt this moment, the node running the old code will try to resolve the \"controller.internal\" and the active controller will answer the IP for controller.internal for IPv6 and IPv4.\n\nYou can merge this code, it as a clean solution, but in the next tasks we may need to handle these scenarios.",
|
|
"revId": "9821652bc8174cc8a037b160421af23992a7dc7e",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "e35f6cf3_54da9c87",
|
|
"filename": "kickstart/files/kickstart.cfg",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 2722,
|
|
"author": {
|
|
"id": 32933
|
|
},
|
|
"writtenOn": "2024-04-18T11:04:29Z",
|
|
"side": 1,
|
|
"message": "It should work as mgmt_ip query the active controller and does not attempt to get it differently in case of failure. This makes me believe the API is already present in the previous version.",
|
|
"parentUuid": "bb46db74_bc5291f6",
|
|
"revId": "9821652bc8174cc8a037b160421af23992a7dc7e",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |