metal/c6bdc8b728fa297ab8a51c3a6bb018dba12f1b32

{
  "comments": [
    {
      "unresolved": true,
      "key": {
        "uuid": "c4f7548f_f76770b0",
        "filename": "kickstart/files/kickstart.cfg",
        "patchSetId": 2
      },
      "lineNbr": 2722,
      "author": {
        "id": 28464
      },
      "writtenOn": "2024-04-01T15:22:38Z",
      "side": 1,
      "message": "1 to 3 digits",
      "range": {
        "startLine": 2722,
        "startChar": 29,
        "endLine": 2722,
        "endChar": 37
      },
      "revId": "c6bdc8b728fa297ab8a51c3a6bb018dba12f1b32",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "b155bde9_7e6ef612",
        "filename": "kickstart/files/kickstart.cfg",
        "patchSetId": 2
      },
      "lineNbr": 2722,
      "author": {
        "id": 28464
      },
      "writtenOn": "2024-04-01T15:22:38Z",
      "side": 1,
      "message": "repeated 3 times and then [0-9]{1,3} matches the final group of 1 to 3 digits.",
      "range": {
        "startLine": 2722,
        "startChar": 66,
        "endLine": 2722,
        "endChar": 68
      },
      "revId": "c6bdc8b728fa297ab8a51c3a6bb018dba12f1b32",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "43db5997_58078c33",
        "filename": "kickstart/files/kickstart.cfg",
        "patchSetId": 2
      },
      "lineNbr": 2723,
      "author": {
        "id": 28464
      },
      "writtenOn": "2024-04-01T15:22:38Z",
      "side": 1,
      "message": "Missing ${}.\n\nHowever, more critically, using the mgmt_ip rather than the dig prevents this change from ever being patched back.\n\nThe addition of the mgmt_ip was implemented for an IPSec feature for which there is no plan or intent to patch back.\n\nYou can use the following command and filter out domain names and revert back to the original code where it\u0027s assumed to be IPV6 if the ipv6_addr variable is not empty.\n\nHere is the output in the diff systems\n\nIPV6:\n[sysadmin@controller-1 ~(keystone_admin)]$ dig +short AAAA controller\ncontroller.internal.\nfdff:719a:bf60:2080::2\n\nIPV4:\nsysadmin@controller-0:~$ dig +short AAAA controller\ncontroller.internal.\n\nI think doing so would be a more portable implementation and line up with the way this has always been done before FQDN feature addition.",
      "range": {
        "startLine": 2723,
        "startChar": 11,
        "endLine": 2723,
        "endChar": 19
      },
      "revId": "c6bdc8b728fa297ab8a51c3a6bb018dba12f1b32",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "fa335387_7c998bcc",
        "filename": "kickstart/files/kickstart.cfg",
        "patchSetId": 2
      },
      "lineNbr": 2723,
      "author": {
        "id": 35022
      },
      "writtenOn": "2024-04-01T16:09:20Z",
      "side": 1,
      "message": "Hi Eric, \nI see, thanks.\nIndeed I could keep the original code and check if the result of \"dig +short AAAA controller\" is \"controller.internal\" and in case of affirmative, I can set ipv6_addr to empty string again, so the rest of the code will work.\n\nBut I was talking with Kantek and Tara, they are working on the feature: \"IPv4/IPv6 Dual Stack Networking\" https://storyboard.openstack.org/#!/story/2011027\n\nas I understood, the\n\"dig +short AAAA controller.internal\" and\n\"dig +short A controller.internal\"\n\nmay return valid IP results, so it will not be usefull to distinguish IPv4/Ipv6 installations anymore, for this reason they will check the primary IP addess format to define the installation, for this reason I used their code as soluction for this bug.\nOf course we can change the solution, I will talk with Steven about that.",
      "parentUuid": "43db5997_58078c33",
      "range": {
        "startLine": 2723,
        "startChar": 11,
        "endLine": 2723,
        "endChar": 19
      },
      "revId": "c6bdc8b728fa297ab8a51c3a6bb018dba12f1b32",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "d749f132_22f8e9a4",
        "filename": "kickstart/files/kickstart.cfg",
        "patchSetId": 2
      },
      "lineNbr": 2723,
      "author": {
        "id": 35022
      },
      "writtenOn": "2024-04-01T16:30:25Z",
      "side": 1,
      "message": "The change is not difficult, If necessary I can change the code for:\n\n    ipv6_addr\u003d$(dig +short AAAA controller.internal)\n    if [[ -z \"${ipv6_addr}\" ]]\n    then\n        # during an upgrade the controller.internal may not be defined\n        # but the scenario could be IPv6. So try to resolve the controller\n        ipv6_addr\u003d$(dig +short AAAA controller)\n        if [[ ${ipv6_addr} \u003d\u003d \"controller.internal\" ]] ; then\n           ipv6_addr \u003d \"\"\n        fi\n\n    fi\n\n    if [[ -n \"${ipv6_addr}\" ]]\n    then\n        boot_address_family\u003dinet6\n        ipv6init\u003dyes\n        dhcpv6c\u003dyes\n    else\n        boot_address_family\u003dinet\n        ipv6init\u003dno\n        dhcpv6c\u003dno\n\n\nor I can check if the ${ipv6_addr} has \":\" ( all IPv6 must have \":\" )\n\n        if [[ ${ipv6_addr} \u003d\u003d *\":\"* ]] ; then\n           ipv6_addr \u003d \"\"\n        fi",
      "parentUuid": "fa335387_7c998bcc",
      "range": {
        "startLine": 2723,
        "startChar": 11,
        "endLine": 2723,
        "endChar": 19
      },
      "revId": "c6bdc8b728fa297ab8a51c3a6bb018dba12f1b32",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    }
  ]
}