Update patch set 11

Patch Set 11: (13 comments) Patch-set: 11 CC: Gerrit User 9926 <9926@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Attention: {"person_ident":"Gerrit User 35148 \u003c35148@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_9926\u003e replied on the change"}
2024-04-09 12:11:32 +00:00 · 2024-04-09 12:11:32 +00:00 · 54348f92c4
parent 75e1594357
commit 54348f92c4
2 changed files with 283 additions and 0 deletions
--- a/27
+++ b/27
@ -0,0 +1,27 @@
+{
+  "comments": [
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "9a92f05e_d6f993f5",
+        "filename": "nfv/nfv-plugins/nfv_plugins/nfvi_plugins/nfvi_infrastructure_api.py",
+        "patchSetId": 10
+      },
+      "lineNbr": 2243,
+      "author": {
+        "id": 9926
+      },
+      "writtenOn": "2024-04-09T12:11:32Z",
+      "side": 1,
+      "message": "software deploy ...",
+      "range": {
+        "startLine": 2243,
+        "startChar": 32,
+        "endLine": 2243,
+        "endChar": 34
+      },
+      "revId": "00cc55cb0b460465247074aa916817bc9ded9367",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    }
+  ]
+}
--- a/256
+++ b/256
@ -0,0 +1,256 @@
+{
+  "comments": [
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "e6f07efa_3ce603c0",
+        "filename": "nfv/nfv-plugins/nfv_plugins/nfvi_plugins/nfvi_infrastructure_api.py",
+        "patchSetId": 11
+      },
+      "lineNbr": 2277,
+      "author": {
+        "id": 9926
+      },
+      "writtenOn": "2024-04-09T12:11:32Z",
+      "side": 1,
+      "message": "software",
+      "range": {
+        "startLine": 2277,
+        "startChar": 23,
+        "endLine": 2277,
+        "endChar": 33
+      },
+      "revId": "a10f01e8e9502a6d193bb65bafb541ad7e70f3c6",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "1d03a0d8_8740e929",
+        "filename": "nfv/nfv-plugins/nfv_plugins/nfvi_plugins/nfvi_infrastructure_api.py",
+        "patchSetId": 11
+      },
+      "lineNbr": 2321,
+      "author": {
+        "id": 9926
+      },
+      "writtenOn": "2024-04-09T12:11:32Z",
+      "side": 1,
+      "message": "software deploy ... several instances in file/review",
+      "range": {
+        "startLine": 2321,
+        "startChar": 36,
+        "endLine": 2321,
+        "endChar": 39
+      },
+      "revId": "a10f01e8e9502a6d193bb65bafb541ad7e70f3c6",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "45711420_57ca719c",
+        "filename": "nfv/nfv-plugins/nfv_plugins/nfvi_plugins/nfvi_infrastructure_api.py",
+        "patchSetId": 11
+      },
+      "lineNbr": 2333,
+      "author": {
+        "id": 9926
+      },
+      "writtenOn": "2024-04-09T12:11:32Z",
+      "side": 1,
+      "message": "software",
+      "range": {
+        "startLine": 2333,
+        "startChar": 20,
+        "endLine": 2333,
+        "endChar": 29
+      },
+      "revId": "a10f01e8e9502a6d193bb65bafb541ad7e70f3c6",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "b9f0cd0a_d653e969",
+        "filename": "nfv/nfv-tests/nfv_unit_tests/tests/test_nfv_client.py",
+        "patchSetId": 11
+      },
+      "lineNbr": 256,
+      "author": {
+        "id": 9926
+      },
+      "writtenOn": "2024-04-09T12:11:32Z",
+      "side": 1,
+      "message": "starlingx",
+      "range": {
+        "startLine": 256,
+        "startChar": 17,
+        "endLine": 256,
+        "endChar": 27
+      },
+      "revId": "a10f01e8e9502a6d193bb65bafb541ad7e70f3c6",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "5aab212b_85743b9e",
+        "filename": "nfv/nfv-vim/nfv_vim/directors/_host_director.py",
+        "patchSetId": 11
+      },
+      "lineNbr": 696,
+      "author": {
+        "id": 9926
+      },
+      "writtenOn": "2024-04-09T12:11:32Z",
+      "side": 1,
+      "message": "should comment that now unlocked host can be upgraded (even for major release?)",
+      "revId": "a10f01e8e9502a6d193bb65bafb541ad7e70f3c6",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "d445888a_3a7a01df",
+        "filename": "nfv/nfv-vim/nfv_vim/directors/_sw_mgmt_director.py",
+        "patchSetId": 11
+      },
+      "lineNbr": 78,
+      "author": {
+        "id": 9926
+      },
+      "writtenOn": "2024-04-09T12:11:32Z",
+      "side": 1,
+      "message": "controller_apply_type ?",
+      "range": {
+        "startLine": 78,
+        "startChar": 35,
+        "endLine": 78,
+        "endChar": 51
+      },
+      "revId": "a10f01e8e9502a6d193bb65bafb541ad7e70f3c6",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "5c15363b_817bd8c0",
+        "filename": "nfv/nfv-vim/nfv_vim/directors/_sw_mgmt_director.py",
+        "patchSetId": 11
+      },
+      "lineNbr": 95,
+      "author": {
+        "id": 9926
+      },
+      "writtenOn": "2024-04-09T12:11:32Z",
+      "side": 1,
+      "message": "controller_apply_type ?",
+      "range": {
+        "startLine": 95,
+        "startChar": 27,
+        "endLine": 95,
+        "endChar": 43
+      },
+      "revId": "a10f01e8e9502a6d193bb65bafb541ad7e70f3c6",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "683afcbf_8a972287",
+        "filename": "nfv/nfv-vim/nfv_vim/nfvi/_nfvi_infrastructure_module.py",
+        "patchSetId": 11
+      },
+      "lineNbr": 382,
+      "author": {
+        "id": 9926
+      },
+      "writtenOn": "2024-04-09T12:11:32Z",
+      "side": 1,
+      "message": "Software deploy precheck",
+      "range": {
+        "startLine": 382,
+        "startChar": 4,
+        "endLine": 382,
+        "endChar": 17
+      },
+      "revId": "a10f01e8e9502a6d193bb65bafb541ad7e70f3c6",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "707e043a_004ef371",
+        "filename": "nfv/nfv-vim/nfv_vim/nfvi/objects/v1/_upgrade.py",
+        "patchSetId": 11
+      },
+      "lineNbr": 14,
+      "author": {
+        "id": 9926
+      },
+      "writtenOn": "2024-04-09T12:11:32Z",
+      "side": 1,
+      "message": "note that these states may be removed per comment at\nhttps://opendev.org/starlingx/update/src/commit/76739676dc97db66b5686ad06d5f41273f68b746/software/software/constants.py#L77",
+      "revId": "a10f01e8e9502a6d193bb65bafb541ad7e70f3c6",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "faad15e4_8d974da8",
+        "filename": "nfv/nfv-vim/nfv_vim/nfvi/objects/v1/_upgrade.py",
+        "patchSetId": 11
+      },
+      "lineNbr": 43,
+      "author": {
+        "id": 9926
+      },
+      "writtenOn": "2024-04-09T12:11:32Z",
+      "side": 1,
+      "message": "Is ACTIVATION_FAILED a potential state? \nhttps://opendev.org/starlingx/update/src/commit/76739676dc97db66b5686ad06d5f41273f68b746/software/software/constants.py#L186",
+      "revId": "a10f01e8e9502a6d193bb65bafb541ad7e70f3c6",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "773364b6_bf6d85c2",
+        "filename": "nfv/nfv-vim/nfv_vim/nfvi/objects/v1/_upgrade.py",
+        "patchSetId": 11
+      },
+      "lineNbr": 96,
+      "author": {
+        "id": 9926
+      },
+      "writtenOn": "2024-04-09T12:11:32Z",
+      "side": 1,
+      "message": "is_activating ?",
+      "range": {
+        "startLine": 96,
+        "startChar": 8,
+        "endLine": 96,
+        "endChar": 20
+      },
+      "revId": "a10f01e8e9502a6d193bb65bafb541ad7e70f3c6",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "61c29b78_6de1c08a",
+        "filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy.py",
+        "patchSetId": 11
+      },
+      "lineNbr": 1974,
+      "author": {
+        "id": 9926
+      },
+      "writtenOn": "2024-04-09T12:11:32Z",
+      "side": 1,
+      "message": "this may not guarantee that controller-1 is first; the id order in the database may change if a host-delete occurred (e.g. to change /replace hardware) previously",
+      "revId": "a10f01e8e9502a6d193bb65bafb541ad7e70f3c6",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    }
+  ]
+}