starlingx
/
nfv
Code Issues Proposed changes

Update patch set 5 

Patch Set 5:

(11 comments)

This change is ready for review.

Patch-set: 5
Work-in-progress: false
Attention: {"person_ident":"Gerrit User 35148 \u003c35148@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_35748\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 35748 \u003c35748@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_35748\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 9926 \u003c9926@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_35748\u003e replied on the change"}
This commit is contained in:
Gerrit User 35748 2024-05-06 13:22:44 +00:00 committed by Gerrit Code Review
parent 3735d1eb67
commit 8151293336
3 changed files with 264 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
6142d9f11642113cb641d5683e02478c1a011941
View File

@ -46,6 +46,30 @@
},
"revId": "6142d9f11642113cb641d5683e02478c1a011941",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "97ec3505_d890ab4c",
"filename": "nfv/nfv-plugins/nfv_plugins/nfvi_plugins/nfvi_infrastructure_api.py",
"patchSetId": 2
},
"lineNbr": 2308,
"author": {
"id": 35748
},
"writtenOn": "2024-05-06T13:22:44Z",
"side": 0,
"message": "Done",
"parentUuid": "413d5f62_90da8c97",
"range": {
"startLine": 2305,
"startChar": 12,
"endLine": 2308,
"endChar": 21
},
"revId": "6142d9f11642113cb641d5683e02478c1a011941",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

24
748c9090fe85301cc32cf25d7830eddc8b15b7aa
View File

@ -129,6 +129,30 @@
"revId": "748c9090fe85301cc32cf25d7830eddc8b15b7aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "b7c8affa_9916ec76",
"filename": "nfv/nfv-plugins/nfv_plugins/nfvi_plugins/nfvi_infrastructure_api.py",
"patchSetId": 2
},
"lineNbr": 2363,
"author": {
"id": 35748
},
"writtenOn": "2024-05-06T13:22:44Z",
"side": 1,
"message": "object is updated now with needed details, once the api is changed to asynchronous call the todo comment to be taken care in the _strategy_steps.py",
"parentUuid": "c3a9b272_3b877003",
"range": {
"startLine": 2354,
"startChar": 1,
"endLine": 2363,
"endChar": 54
},
"revId": "748c9090fe85301cc32cf25d7830eddc8b15b7aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {

216
9cb8d032e9aefd3c5c89ac88615073fc40e1e338
View File

@ -23,6 +23,30 @@
"revId": "9cb8d032e9aefd3c5c89ac88615073fc40e1e338",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "3ce40a5e_9a641abc",
"filename": "nfv/nfv-common/nfv_common/tasks/_task_future.py",
"patchSetId": 4
},
"lineNbr": 62,
"author": {
"id": 35748
},
"writtenOn": "2024-05-06T13:22:44Z",
"side": 1,
"message": "Done",
"parentUuid": "7f1ae98c_e8875335",
"range": {
"startLine": 62,
"startChar": 30,
"endLine": 62,
"endChar": 33
},
"revId": "9cb8d032e9aefd3c5c89ac88615073fc40e1e338",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -46,6 +70,30 @@
"revId": "9cb8d032e9aefd3c5c89ac88615073fc40e1e338",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "8edf9c94_312cbba9",
"filename": "nfv/nfv-plugins/nfv_plugins/nfvi_plugins/nfvi_infrastructure_api.py",
"patchSetId": 4
},
"lineNbr": 2357,
"author": {
"id": 35748
},
"writtenOn": "2024-05-06T13:22:44Z",
"side": 1,
"message": "Done",
"parentUuid": "7a94b981_ec0abef9",
"range": {
"startLine": 2357,
"startChar": 14,
"endLine": 2357,
"endChar": 19
},
"revId": "9cb8d032e9aefd3c5c89ac88615073fc40e1e338",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -69,6 +117,30 @@
"revId": "9cb8d032e9aefd3c5c89ac88615073fc40e1e338",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "24a8003e_27a32776",
"filename": "nfv/nfv-plugins/nfv_plugins/nfvi_plugins/openstack/rest_api.py",
"patchSetId": 4
},
"lineNbr": 476,
"author": {
"id": 35748
},
"writtenOn": "2024-05-06T13:22:44Z",
"side": 1,
"message": "Done",
"parentUuid": "862c9f84_758da41e",
"range": {
"startLine": 476,
"startChar": 37,
"endLine": 476,
"endChar": 40
},
"revId": "9cb8d032e9aefd3c5c89ac88615073fc40e1e338",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -92,6 +164,30 @@
"revId": "9cb8d032e9aefd3c5c89ac88615073fc40e1e338",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "56246d0a_08847e74",
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy.py",
"patchSetId": 4
},
"lineNbr": 984,
"author": {
"id": 35748
},
"writtenOn": "2024-05-06T13:22:44Z",
"side": 1,
"message": "yes, I guess it might break. removed the release parameter.",
"parentUuid": "af07cdb5_b1a9a47c",
"range": {
"startLine": 982,
"startChar": 28,
"endLine": 984,
"endChar": 106
},
"revId": "9cb8d032e9aefd3c5c89ac88615073fc40e1e338",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -115,6 +211,30 @@
"revId": "9cb8d032e9aefd3c5c89ac88615073fc40e1e338",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "61f1d7d2_5d0aaf3c",
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy.py",
"patchSetId": 4
},
"lineNbr": 1841,
"author": {
"id": 35748
},
"writtenOn": "2024-05-06T13:22:44Z",
"side": 1,
"message": "Done",
"parentUuid": "68ec7fff_beba4c4e",
"range": {
"startLine": 1841,
"startChar": 8,
"endLine": 1841,
"endChar": 25
},
"revId": "9cb8d032e9aefd3c5c89ac88615073fc40e1e338",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -138,6 +258,30 @@
"revId": "9cb8d032e9aefd3c5c89ac88615073fc40e1e338",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "325ee4b3_b499a7d5",
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy.py",
"patchSetId": 4
},
"lineNbr": 1848,
"author": {
"id": 35748
},
"writtenOn": "2024-05-06T13:22:44Z",
"side": 1,
"message": "Done",
"parentUuid": "20a6f83c_9ae4d219",
"range": {
"startLine": 1848,
"startChar": 74,
"endLine": 1848,
"endChar": 78
},
"revId": "9cb8d032e9aefd3c5c89ac88615073fc40e1e338",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -161,6 +305,30 @@
"revId": "9cb8d032e9aefd3c5c89ac88615073fc40e1e338",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "3e842ca9_6e6b9cd4",
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy.py",
"patchSetId": 4
},
"lineNbr": 1858,
"author": {
"id": 35748
},
"writtenOn": "2024-05-06T13:22:44Z",
"side": 1,
"message": "As precheck should be part of create strategy, so not adding as a step to be\ndone in apply phase.",
"parentUuid": "e38ea45f_654e27de",
"range": {
"startLine": 1858,
"startChar": 8,
"endLine": 1858,
"endChar": 53
},
"revId": "9cb8d032e9aefd3c5c89ac88615073fc40e1e338",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -184,6 +352,30 @@
"revId": "9cb8d032e9aefd3c5c89ac88615073fc40e1e338",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "ff064e59_7ad116b5",
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy_steps.py",
"patchSetId": 4
},
"lineNbr": 28,
"author": {
"id": 35748
},
"writtenOn": "2024-05-06T13:22:44Z",
"side": 1,
"message": "The recent state changes has been taken care, so removing the todo.",
"parentUuid": "e3a3a097_0e4c1211",
"range": {
"startLine": 28,
"startChar": 45,
"endLine": 28,
"endChar": 51
},
"revId": "9cb8d032e9aefd3c5c89ac88615073fc40e1e338",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -206,6 +398,30 @@
},
"revId": "9cb8d032e9aefd3c5c89ac88615073fc40e1e338",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "f8f312ef_81ad5380",
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy_steps.py",
"patchSetId": 4
},
"lineNbr": 1014,
"author": {
"id": 35748
},
"writtenOn": "2024-05-06T13:22:44Z",
"side": 1,
"message": "Done",
"parentUuid": "8020d0dd_0b0f1d7e",
"range": {
"startLine": 1014,
"startChar": 38,
"endLine": 1014,
"endChar": 51
},
"revId": "9cb8d032e9aefd3c5c89ac88615073fc40e1e338",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}