From 0b8e1605db3e115e4f5d92eed49d3bde4e00ade8 Mon Sep 17 00:00:00 2001 From: Scott Little Date: Mon, 19 Nov 2018 10:37:52 -0500 Subject: [PATCH] sign-rpms: Don't attempt off-box signing if variables not set. Problem: User 'jenkins' hit a build-iso failure in sign-rpms. Problem was a test that assumes user jenkins will always provide environment variable setting for SIGNING_USER, SIGNING_SERVER and SIGNING_SERVER_SCRIPT. This is not a valid assumption. Solution: Explicitly test that all three environment variables are set before invoking sign_packages_on_server. Story: 2003906 Task: 27974 Change-Id: If9eb61b8001ca58f9262c2eccab96b4820c68102 Signed-off-by: Scott Little --- build-tools/sign-rpms | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build-tools/sign-rpms b/build-tools/sign-rpms index f0512e9f..403d1eab 100755 --- a/build-tools/sign-rpms +++ b/build-tools/sign-rpms @@ -279,7 +279,7 @@ check_vars echo signing $_PKG_DIR # sign all rpms -if [ "$USER" == "jenkins" ]; then +if [ "$USER" == "jenkins" ] && [ ! -z "${SIGNING_USER}" ] && [ ! -z "${SIGNING_SERVER}" ] && [ ! -z "${SIGNING_SERVER_SCRIPT}" ]; then sign_packages_on_server retval=$? else