starlingx
/
specs
Code Issues Proposed changes

Update patch set 5 

Patch Set 5: Code-Review-1

(6 comments)

Patch-set: 5
Reviewer: Gerrit User 31683 <31683@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, 8fa71d08d60d629d209b2ed0d989b8cdd40d1205
Attention: {"person_ident":"Gerrit User 29042 \u003c29042@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_31683\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 31683 \u003c31683@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_31683\u003e replied on the change"}
This commit is contained in:
Gerrit User 31683 2023-08-11 14:26:50 +00:00 committed by Gerrit Code Review
parent 962d7d096d
commit 128c94ab05
1 changed files with 118 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

118
70f10c8ec853d7bf6bc29ccb82a0f49312ed5723 Normal file
View File

@ -0,0 +1,118 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "216ac435_ffa4f796",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-ARM-platform.rst",
"patchSetId": 5
},
"lineNbr": 19,
"author": {
"id": 31683
},
"writtenOn": "2023-08-11T14:26:50Z",
"side": 1,
"message": "s/was/is/",
"range": {
"startLine": 19,
"startChar": 25,
"endLine": 19,
"endChar": 29
},
"revId": "70f10c8ec853d7bf6bc29ccb82a0f49312ed5723",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "75d87b5f_b8071521",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-ARM-platform.rst",
"patchSetId": 5
},
"lineNbr": 22,
"author": {
"id": 31683
},
"writtenOn": "2023-08-11T14:26:50Z",
"side": 1,
"message": "I would get rid of this sentence",
"range": {
"startLine": 21,
"startChar": 43,
"endLine": 22,
"endChar": 60
},
"revId": "70f10c8ec853d7bf6bc29ccb82a0f49312ed5723",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "7d6cfa20_c46fbf82",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-ARM-platform.rst",
"patchSetId": 5
},
"lineNbr": 47,
"author": {
"id": 31683
},
"writtenOn": "2023-08-11T14:26:50Z",
"side": 1,
"message": "Suggest to explain why this is not feasible. Among other things, I think building cross-architecture docker images may be difficult/impossible.",
"revId": "70f10c8ec853d7bf6bc29ccb82a0f49312ed5723",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "1533f2da_30056acd",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-ARM-platform.rst",
"patchSetId": 5
},
"lineNbr": 122,
"author": {
"id": 31683
},
"writtenOn": "2023-08-11T14:26:50Z",
"side": 1,
"message": "also: starlingx/jenkins-pipelines (maybe?)",
"revId": "70f10c8ec853d7bf6bc29ccb82a0f49312ed5723",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "37e6aa4e_7a955513",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-ARM-platform.rst",
"patchSetId": 5
},
"lineNbr": 238,
"author": {
"id": 31683
},
"writtenOn": "2023-08-11T14:26:50Z",
"side": 1,
"message": "* Existing docker files may not support ARM64 and will need to be ported.\n* Docker image and python wheel build scripts in starlingx/root will need to be extended to support multiple architectures.",
"revId": "70f10c8ec853d7bf6bc29ccb82a0f49312ed5723",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "e96524a2_61f34b12",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-ARM-platform.rst",
"patchSetId": 5
},
"lineNbr": 256,
"author": {
"id": 31683
},
"writtenOn": "2023-08-11T14:26:50Z",
"side": 1,
"message": "* Build docker images on ARM64 platform",
"revId": "70f10c8ec853d7bf6bc29ccb82a0f49312ed5723",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}