Update patch set 10

Patch Set 10: Code-Review-1 (16 comments) Patch-set: 10 Reviewer: Gerrit User 26026 <26026@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1, 29d20791a104d4ceda69ae65178a33086a3d49f5
2023-06-19 14:01:22 +00:00 · 2023-06-19 14:01:22 +00:00 · 15b6623d81
parent 0e74ec1a4c
commit 15b6623d81
1 changed files with 356 additions and 0 deletions
--- a/356
+++ b/356
@ -33,6 +33,362 @@
      "message": "You should mark the COMMENTS of this review as \u0027resolved\u0027, if and when they are indeed resolved ... otherwise it looks like there are open issues/comments with the review.",
      "revId": "f56c4f46fa118c34ff34ebabd4b6011a07a6fb6a",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "da1f3eaf_666a8595",
+        "filename": "/PATCHSET_LEVEL",
+        "patchSetId": 10
+      },
+      "lineNbr": 0,
+      "author": {
+        "id": 26026
+      },
+      "writtenOn": "2023-06-19T14:01:22Z",
+      "side": 1,
+      "message": "bunch of minor items and questions",
+      "revId": "f56c4f46fa118c34ff34ebabd4b6011a07a6fb6a",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "db1f0e2f_5f9a1f98",
+        "filename": "doc/source/specs/stx-9.0/approved/IEO_Starlingx_Spec_submission.rst",
+        "patchSetId": 10
+      },
+      "lineNbr": 32,
+      "author": {
+        "id": 26026
+      },
+      "writtenOn": "2023-06-19T14:01:22Z",
+      "side": 1,
+      "message": "? firmware for Intel Ethernet NICs ?\nif yes, maybe add extra text",
+      "range": {
+        "startLine": 32,
+        "startChar": 39,
+        "endLine": 32,
+        "endChar": 48
+      },
+      "revId": "f56c4f46fa118c34ff34ebabd4b6011a07a6fb6a",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "3155efc8_3230b0f3",
+        "filename": "doc/source/specs/stx-9.0/approved/IEO_Starlingx_Spec_submission.rst",
+        "patchSetId": 10
+      },
+      "lineNbr": 32,
+      "author": {
+        "id": 26026
+      },
+      "writtenOn": "2023-06-19T14:01:22Z",
+      "side": 1,
+      "message": "Intel Ethernet Operator (IEO)\n\n\n... since you use IEO later",
+      "range": {
+        "startLine": 32,
+        "startChar": 4,
+        "endLine": 32,
+        "endChar": 27
+      },
+      "revId": "f56c4f46fa118c34ff34ebabd4b6011a07a6fb6a",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "261ef986_d99e27c1",
+        "filename": "doc/source/specs/stx-9.0/approved/IEO_Starlingx_Spec_submission.rst",
+        "patchSetId": 10
+      },
+      "lineNbr": 42,
+      "author": {
+        "id": 26026
+      },
+      "writtenOn": "2023-06-19T14:01:22Z",
+      "side": 1,
+      "message": "should we indicate here that SRIOV Device Plugin, SRIOV Network Operator and Node Features Discovery are all currently supported in StarlingX ?  I.e. this feature does not require to add them ?",
+      "range": {
+        "startLine": 39,
+        "startChar": 0,
+        "endLine": 42,
+        "endChar": 19
+      },
+      "revId": "f56c4f46fa118c34ff34ebabd4b6011a07a6fb6a",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "dc259f19_011230fc",
+        "filename": "doc/source/specs/stx-9.0/approved/IEO_Starlingx_Spec_submission.rst",
+        "patchSetId": 10
+      },
+      "lineNbr": 47,
+      "author": {
+        "id": 26026
+      },
+      "writtenOn": "2023-06-19T14:01:22Z",
+      "side": 1,
+      "message": "UFT is included as part of the installation of the Ethernet Operator ?  or the installation of base StarlingX ?",
+      "range": {
+        "startLine": 46,
+        "startChar": 53,
+        "endLine": 47,
+        "endChar": 24
+      },
+      "revId": "f56c4f46fa118c34ff34ebabd4b6011a07a6fb6a",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "a0a0e3c3_a22064b0",
+        "filename": "doc/source/specs/stx-9.0/approved/IEO_Starlingx_Spec_submission.rst",
+        "patchSetId": 10
+      },
+      "lineNbr": 51,
+      "author": {
+        "id": 26026
+      },
+      "writtenOn": "2023-06-19T14:01:22Z",
+      "side": 1,
+      "message": "Reword this ?\n\nI don\u0027t understand what is being said here.\n- is the Ethernet Operator installing a driver ?\n- is it not an open source driver ?\n- what is SRO ?\n- is Ethernet Operator upgrading the default icelake driver ?",
+      "range": {
+        "startLine": 48,
+        "startChar": 0,
+        "endLine": 51,
+        "endChar": 61
+      },
+      "revId": "f56c4f46fa118c34ff34ebabd4b6011a07a6fb6a",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "1a44857e_7d6e8cef",
+        "filename": "doc/source/specs/stx-9.0/approved/IEO_Starlingx_Spec_submission.rst",
+        "patchSetId": 10
+      },
+      "lineNbr": 52,
+      "author": {
+        "id": 26026
+      },
+      "writtenOn": "2023-06-19T14:01:22Z",
+      "side": 1,
+      "message": "GENERAL QUESTION:\n- does the configuration done by the IEO overlap at all with the basic ethernet nic configuration done by StarlingX config ?\n( My guess is no ... )",
+      "revId": "f56c4f46fa118c34ff34ebabd4b6011a07a6fb6a",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "4bc54866_b3caf28d",
+        "filename": "doc/source/specs/stx-9.0/approved/IEO_Starlingx_Spec_submission.rst",
+        "patchSetId": 10
+      },
+      "lineNbr": 58,
+      "author": {
+        "id": 26026
+      },
+      "writtenOn": "2023-06-19T14:01:22Z",
+      "side": 1,
+      "message": "a supported",
+      "range": {
+        "startLine": 58,
+        "startChar": 44,
+        "endLine": 58,
+        "endChar": 54
+      },
+      "revId": "f56c4f46fa118c34ff34ebabd4b6011a07a6fb6a",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "fad95cfd_b55f8a7e",
+        "filename": "doc/source/specs/stx-9.0/approved/IEO_Starlingx_Spec_submission.rst",
+        "patchSetId": 10
+      },
+      "lineNbr": 59,
+      "author": {
+        "id": 26026
+      },
+      "writtenOn": "2023-06-19T14:01:22Z",
+      "side": 1,
+      "message": "a compatibility",
+      "range": {
+        "startLine": 59,
+        "startChar": 23,
+        "endLine": 59,
+        "endChar": 37
+      },
+      "revId": "f56c4f46fa118c34ff34ebabd4b6011a07a6fb6a",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "d1bd97c1_68460fe0",
+        "filename": "doc/source/specs/stx-9.0/approved/IEO_Starlingx_Spec_submission.rst",
+        "patchSetId": 10
+      },
+      "lineNbr": 69,
+      "author": {
+        "id": 26026
+      },
+      "writtenOn": "2023-06-19T14:01:22Z",
+      "side": 1,
+      "message": "a specific",
+      "range": {
+        "startLine": 69,
+        "startChar": 61,
+        "endLine": 69,
+        "endChar": 70
+      },
+      "revId": "f56c4f46fa118c34ff34ebabd4b6011a07a6fb6a",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "4d4a54f7_13954ef5",
+        "filename": "doc/source/specs/stx-9.0/approved/IEO_Starlingx_Spec_submission.rst",
+        "patchSetId": 10
+      },
+      "lineNbr": 120,
+      "author": {
+        "id": 26026
+      },
+      "writtenOn": "2023-06-19T14:01:22Z",
+      "side": 1,
+      "message": "EthernetClusterConfig ?",
+      "range": {
+        "startLine": 120,
+        "startChar": 2,
+        "endLine": 120,
+        "endChar": 20
+      },
+      "revId": "f56c4f46fa118c34ff34ebabd4b6011a07a6fb6a",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "84659be3_a9a57340",
+        "filename": "doc/source/specs/stx-9.0/approved/IEO_Starlingx_Spec_submission.rst",
+        "patchSetId": 10
+      },
+      "lineNbr": 121,
+      "author": {
+        "id": 26026
+      },
+      "writtenOn": "2023-06-19T14:01:22Z",
+      "side": 1,
+      "message": "ClusterFlowConfig ?",
+      "range": {
+        "startLine": 121,
+        "startChar": 2,
+        "endLine": 121,
+        "endChar": 32
+      },
+      "revId": "f56c4f46fa118c34ff34ebabd4b6011a07a6fb6a",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "73b22987_7fdeff56",
+        "filename": "doc/source/specs/stx-9.0/approved/IEO_Starlingx_Spec_submission.rst",
+        "patchSetId": 10
+      },
+      "lineNbr": 236,
+      "author": {
+        "id": 26026
+      },
+      "writtenOn": "2023-06-19T14:01:22Z",
+      "side": 1,
+      "message": "CRDs",
+      "range": {
+        "startLine": 236,
+        "startChar": 62,
+        "endLine": 236,
+        "endChar": 65
+      },
+      "revId": "f56c4f46fa118c34ff34ebabd4b6011a07a6fb6a",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "2f7fa4e5_67717b45",
+        "filename": "doc/source/specs/stx-9.0/approved/IEO_Starlingx_Spec_submission.rst",
+        "patchSetId": 10
+      },
+      "lineNbr": 248,
+      "author": {
+        "id": 26026
+      },
+      "writtenOn": "2023-06-19T14:01:22Z",
+      "side": 1,
+      "message": "? And configure flow rules and display configuration status associated with firmware/ddp and flow rules on Ethernet NICs ?",
+      "range": {
+        "startLine": 248,
+        "startChar": 25,
+        "endLine": 248,
+        "endChar": 26
+      },
+      "revId": "f56c4f46fa118c34ff34ebabd4b6011a07a6fb6a",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "8850075f_25f72bf1",
+        "filename": "doc/source/specs/stx-9.0/approved/IEO_Starlingx_Spec_submission.rst",
+        "patchSetId": 10
+      },
+      "lineNbr": 307,
+      "author": {
+        "id": 26026
+      },
+      "writtenOn": "2023-06-19T14:01:22Z",
+      "side": 1,
+      "message": "FluxCD",
+      "range": {
+        "startLine": 307,
+        "startChar": 49,
+        "endLine": 307,
+        "endChar": 55
+      },
+      "revId": "f56c4f46fa118c34ff34ebabd4b6011a07a6fb6a",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "4e7fe524_a3f262b0",
+        "filename": "doc/source/specs/stx-9.0/approved/IEO_Starlingx_Spec_submission.rst",
+        "patchSetId": 10
+      },
+      "lineNbr": 319,
+      "author": {
+        "id": 26026
+      },
+      "writtenOn": "2023-06-19T14:01:22Z",
+      "side": 1,
+      "message": "building of this container image should be done under the new intel-ethernet-operator system application repo",
+      "range": {
+        "startLine": 316,
+        "startChar": 0,
+        "endLine": 319,
+        "endChar": 28
+      },
+      "revId": "f56c4f46fa118c34ff34ebabd4b6011a07a6fb6a",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    }
  ]
 }