starlingx
/
specs
Code Issues Proposed changes

Update patch set 25 

Patch Set 25:

(1 comment)

Patch-set: 25
Attention: {"person_ident":"Gerrit User 8768 \u003c8768@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_35139\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 35139 \u003c35139@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_35139\u003e replied on the change"}
This commit is contained in:
Gerrit User 35139 2023-06-16 12:49:47 +00:00 committed by Gerrit Code Review
parent f9d371553e
commit 696d6e9436
1 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
15029b255f03d3fff587d4cf91e5b0de621dd588
View File

@ -56,6 +56,30 @@
},
"revId": "15029b255f03d3fff587d4cf91e5b0de621dd588",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "39a30fec_3cbf2464",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010737-configurable-power-management.rst",
"patchSetId": 25
},
"lineNbr": 235,
"author": {
"id": 35139
},
"writtenOn": "2023-06-16T12:49:47Z",
"side": 1,
"message": "Hi Chris, your understanding is correct. The approach of validating the parameter will make the solution more consistent and clearer for the user than simply ignoring the parameter. This will add some extra work but we think it\u0027s worth it.",
"parentUuid": "114028ab_6103f906",
"range": {
"startLine": 234,
"startChar": 0,
"endLine": 235,
"endChar": 20
},
"revId": "15029b255f03d3fff587d4cf91e5b0de621dd588",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}