Update patch set 21
Patch Set 21: Code-Review-1 (4 comments) Patch-set: 21 Reviewer: Gerrit User 8768 <8768@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1, 3bd154b15038dc4f38101f6483a24a07dd23f6bb Attention: {"person_ident":"Gerrit User 8768 \u003c8768@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_8768\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 34769 \u003c34769@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_8768\u003e replied on the change"}
This commit is contained in:
parent
79a817dae7
commit
83c156d41e
|
@ -140,6 +140,30 @@
|
|||
},
|
||||
"revId": "39052d850badc745b34097702eafe82809c88f3a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "032fae1b_b4710569",
|
||||
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010737-configurable-power-management.rst",
|
||||
"patchSetId": 19
|
||||
},
|
||||
"lineNbr": 234,
|
||||
"author": {
|
||||
"id": 8768
|
||||
},
|
||||
"writtenOn": "2023-06-01T19:07:24Z",
|
||||
"side": 1,
|
||||
"message": "I don\u0027t really like the idea of silently ignoring something explicitly configured by the administrator, since it could make debugging kind of tricky.\n\nI think it would be cleaner for the system to reject enabling the Kubernetes Power Manager on nodes where the legacy \"Host CPU MHz Parameters Configuration\" are set, and vice versa. Or else have an automated conversion between the legacy parameters and the Kubernetes Power Manager.",
|
||||
"parentUuid": "29db3bcb_11404e63",
|
||||
"range": {
|
||||
"startLine": 234,
|
||||
"startChar": 33,
|
||||
"endLine": 234,
|
||||
"endChar": 73
|
||||
},
|
||||
"revId": "39052d850badc745b34097702eafe82809c88f3a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
|
@ -0,0 +1,67 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "0919eb22_76e75298",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 21
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 8768
|
||||
},
|
||||
"writtenOn": "2023-06-01T19:07:24Z",
|
||||
"side": 1,
|
||||
"message": "one typo, and a design comment.",
|
||||
"revId": "f9b5938b62ad5b9d9184794667112bf37c9e309e",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "e72e8838_60a7e422",
|
||||
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010737-configurable-power-management.rst",
|
||||
"patchSetId": 21
|
||||
},
|
||||
"lineNbr": 204,
|
||||
"author": {
|
||||
"id": 8768
|
||||
},
|
||||
"writtenOn": "2023-06-01T19:07:24Z",
|
||||
"side": 1,
|
||||
"message": "which",
|
||||
"range": {
|
||||
"startLine": 204,
|
||||
"startChar": 0,
|
||||
"endLine": 204,
|
||||
"endChar": 4
|
||||
},
|
||||
"revId": "f9b5938b62ad5b9d9184794667112bf37c9e309e",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "ea351a2b_5c1b529a",
|
||||
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010737-configurable-power-management.rst",
|
||||
"patchSetId": 21
|
||||
},
|
||||
"lineNbr": 247,
|
||||
"author": {
|
||||
"id": 8768
|
||||
},
|
||||
"writtenOn": "2023-06-01T19:07:24Z",
|
||||
"side": 1,
|
||||
"message": "maybe add \"or increased power consumption\"?",
|
||||
"range": {
|
||||
"startLine": 247,
|
||||
"startChar": 30,
|
||||
"endLine": 247,
|
||||
"endChar": 31
|
||||
},
|
||||
"revId": "f9b5938b62ad5b9d9184794667112bf37c9e309e",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue