Update patch set 23
Patch Set 23:
(14 comments)
Patch-set: 23
Attention: {"person_ident":"Gerrit User 35106 \u003c35106@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_35106\u003e replied on the change"}
This commit is contained in:
Gerrit User 35106
Gerrit Code Review
parent
d3c224e908
commit
848db57516
|
|
@ -17,6 +17,24 @@
|
|||
"revId": "b3e3cc575c8f446092b1515da151e444d070f26b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "f9582f4f_848cb34c",
|
||||
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010737-configurable-power-management.rst",
|
||||
"patchSetId": 22
|
||||
},
|
||||
"lineNbr": 11,
|
||||
"author": {
|
||||
"id": 35106
|
||||
},
|
||||
"writtenOn": "2023-06-12T19:41:46Z",
|
||||
"side": 1,
|
||||
"message": "Ack",
|
||||
"parentUuid": "e2a9fb85_a4e02d45",
|
||||
"revId": "b3e3cc575c8f446092b1515da151e444d070f26b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -40,6 +58,30 @@
|
|||
"revId": "b3e3cc575c8f446092b1515da151e444d070f26b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "6115469c_12c8123e",
|
||||
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010737-configurable-power-management.rst",
|
||||
"patchSetId": 22
|
||||
},
|
||||
"lineNbr": 21,
|
||||
"author": {
|
||||
"id": 35106
|
||||
},
|
||||
"writtenOn": "2023-06-12T19:41:46Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "99d476e2_1eb76511",
|
||||
"range": {
|
||||
"startLine": 21,
|
||||
"startChar": 67,
|
||||
"endLine": 21,
|
||||
"endChar": 70
|
||||
},
|
||||
"revId": "b3e3cc575c8f446092b1515da151e444d070f26b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -63,6 +105,30 @@
|
|||
"revId": "b3e3cc575c8f446092b1515da151e444d070f26b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "740da920_1a711563",
|
||||
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010737-configurable-power-management.rst",
|
||||
"patchSetId": 22
|
||||
},
|
||||
"lineNbr": 32,
|
||||
"author": {
|
||||
"id": 35106
|
||||
},
|
||||
"writtenOn": "2023-06-12T19:41:46Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "9371474b_5344612d",
|
||||
"range": {
|
||||
"startLine": 31,
|
||||
"startChar": 53,
|
||||
"endLine": 32,
|
||||
"endChar": 11
|
||||
},
|
||||
"revId": "b3e3cc575c8f446092b1515da151e444d070f26b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -86,6 +152,30 @@
|
|||
"revId": "b3e3cc575c8f446092b1515da151e444d070f26b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "992e116a_63172a74",
|
||||
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010737-configurable-power-management.rst",
|
||||
"patchSetId": 22
|
||||
},
|
||||
"lineNbr": 108,
|
||||
"author": {
|
||||
"id": 35106
|
||||
},
|
||||
"writtenOn": "2023-06-12T19:41:46Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "658f0d9e_58379565",
|
||||
"range": {
|
||||
"startLine": 108,
|
||||
"startChar": 73,
|
||||
"endLine": 108,
|
||||
"endChar": 74
|
||||
},
|
||||
"revId": "b3e3cc575c8f446092b1515da151e444d070f26b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -109,6 +199,30 @@
|
|||
"revId": "b3e3cc575c8f446092b1515da151e444d070f26b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "4361fc51_59c64c17",
|
||||
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010737-configurable-power-management.rst",
|
||||
"patchSetId": 22
|
||||
},
|
||||
"lineNbr": 195,
|
||||
"author": {
|
||||
"id": 35106
|
||||
},
|
||||
"writtenOn": "2023-06-12T19:41:46Z",
|
||||
"side": 1,
|
||||
"message": "The most appropriate term in this case is \"yaml files\", because we want to include all resources, like powerprofiles, powerworkloads, cstates, and pods.",
|
||||
"parentUuid": "fadd900d_38e9fbf5",
|
||||
"range": {
|
||||
"startLine": 195,
|
||||
"startChar": 12,
|
||||
"endLine": 195,
|
||||
"endChar": 22
|
||||
},
|
||||
"revId": "b3e3cc575c8f446092b1515da151e444d070f26b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -132,6 +246,30 @@
|
|||
"revId": "b3e3cc575c8f446092b1515da151e444d070f26b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "1d8b0714_a58bfd28",
|
||||
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010737-configurable-power-management.rst",
|
||||
"patchSetId": 22
|
||||
},
|
||||
"lineNbr": 200,
|
||||
"author": {
|
||||
"id": 35106
|
||||
},
|
||||
"writtenOn": "2023-06-12T19:41:46Z",
|
||||
"side": 1,
|
||||
"message": "1. Do we have the ability to limit the settings to non-platform cores? \nUnfortunately no. \n\n2. Is there a reason for providing this type of flexibility to end users?\nThe Kubernetes Power Manager provides this kind of flexibility out of the box.",
|
||||
"parentUuid": "a2462038_aafecbb2",
|
||||
"range": {
|
||||
"startLine": 197,
|
||||
"startChar": 0,
|
||||
"endLine": 200,
|
||||
"endChar": 28
|
||||
},
|
||||
"revId": "b3e3cc575c8f446092b1515da151e444d070f26b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -155,6 +293,30 @@
|
|||
"revId": "b3e3cc575c8f446092b1515da151e444d070f26b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "33b009c6_5bb0d470",
|
||||
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010737-configurable-power-management.rst",
|
||||
"patchSetId": 22
|
||||
},
|
||||
"lineNbr": 204,
|
||||
"author": {
|
||||
"id": 35106
|
||||
},
|
||||
"writtenOn": "2023-06-12T19:41:46Z",
|
||||
"side": 1,
|
||||
"message": "The limitation is present only in nodes with worker function. We will clarify this in the text.",
|
||||
"parentUuid": "42035b54_286f4dc1",
|
||||
"range": {
|
||||
"startLine": 204,
|
||||
"startChar": 66,
|
||||
"endLine": 204,
|
||||
"endChar": 78
|
||||
},
|
||||
"revId": "b3e3cc575c8f446092b1515da151e444d070f26b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -178,6 +340,30 @@
|
|||
"revId": "b3e3cc575c8f446092b1515da151e444d070f26b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "579b59e6_65419876",
|
||||
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010737-configurable-power-management.rst",
|
||||
"patchSetId": 22
|
||||
},
|
||||
"lineNbr": 230,
|
||||
"author": {
|
||||
"id": 35106
|
||||
},
|
||||
"writtenOn": "2023-06-12T19:41:46Z",
|
||||
"side": 1,
|
||||
"message": "The Kubernetes Power Manager integration is intended to replace the legacy host CPU MHz parameters configuration. If it is enabled, the user should not use the existing parameters.",
|
||||
"parentUuid": "4a86afc2_4f9d1537",
|
||||
"range": {
|
||||
"startLine": 228,
|
||||
"startChar": 0,
|
||||
"endLine": 230,
|
||||
"endChar": 42
|
||||
},
|
||||
"revId": "b3e3cc575c8f446092b1515da151e444d070f26b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -201,6 +387,30 @@
|
|||
"revId": "b3e3cc575c8f446092b1515da151e444d070f26b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "7d928156_6668d6a6",
|
||||
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010737-configurable-power-management.rst",
|
||||
"patchSetId": 22
|
||||
},
|
||||
"lineNbr": 234,
|
||||
"author": {
|
||||
"id": 35106
|
||||
},
|
||||
"writtenOn": "2023-06-12T19:41:46Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "a4a0d423_e4396139",
|
||||
"range": {
|
||||
"startLine": 232,
|
||||
"startChar": 0,
|
||||
"endLine": 234,
|
||||
"endChar": 8
|
||||
},
|
||||
"revId": "b3e3cc575c8f446092b1515da151e444d070f26b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -224,6 +434,30 @@
|
|||
"revId": "b3e3cc575c8f446092b1515da151e444d070f26b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "da9f82a9_8c69624c",
|
||||
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010737-configurable-power-management.rst",
|
||||
"patchSetId": 22
|
||||
},
|
||||
"lineNbr": 248,
|
||||
"author": {
|
||||
"id": 35106
|
||||
},
|
||||
"writtenOn": "2023-06-12T19:41:46Z",
|
||||
"side": 1,
|
||||
"message": "It depends of the CPU families. In some of them, for example, the max C-State is the C10.",
|
||||
"parentUuid": "5abfa155_37f5f04f",
|
||||
"range": {
|
||||
"startLine": 248,
|
||||
"startChar": 37,
|
||||
"endLine": 248,
|
||||
"endChar": 39
|
||||
},
|
||||
"revId": "b3e3cc575c8f446092b1515da151e444d070f26b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -247,6 +481,30 @@
|
|||
"revId": "b3e3cc575c8f446092b1515da151e444d070f26b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "8ded5d47_05c028a7",
|
||||
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010737-configurable-power-management.rst",
|
||||
"patchSetId": 22
|
||||
},
|
||||
"lineNbr": 266,
|
||||
"author": {
|
||||
"id": 35106
|
||||
},
|
||||
"writtenOn": "2023-06-12T19:41:46Z",
|
||||
"side": 1,
|
||||
"message": "The Kubernetes documentation already provides some general recommendations and best practices. If necessary we can replicate this in the documentation.",
|
||||
"parentUuid": "1d4b66f5_4affcf8c",
|
||||
"range": {
|
||||
"startLine": 262,
|
||||
"startChar": 0,
|
||||
"endLine": 266,
|
||||
"endChar": 18
|
||||
},
|
||||
"revId": "b3e3cc575c8f446092b1515da151e444d070f26b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -282,6 +540,24 @@
|
|||
"revId": "b3e3cc575c8f446092b1515da151e444d070f26b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "2e88e20f_6f87c95c",
|
||||
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010737-configurable-power-management.rst",
|
||||
"patchSetId": 22
|
||||
},
|
||||
"lineNbr": 354,
|
||||
"author": {
|
||||
"id": 35106
|
||||
},
|
||||
"writtenOn": "2023-06-12T19:41:46Z",
|
||||
"side": 1,
|
||||
"message": "Ack",
|
||||
"parentUuid": "48b65330_7a743d55",
|
||||
"revId": "b3e3cc575c8f446092b1515da151e444d070f26b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -299,6 +575,24 @@
|
|||
"revId": "b3e3cc575c8f446092b1515da151e444d070f26b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "456106d8_7390b869",
|
||||
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010737-configurable-power-management.rst",
|
||||
"patchSetId": 22
|
||||
},
|
||||
"lineNbr": 364,
|
||||
"author": {
|
||||
"id": 35106
|
||||
},
|
||||
"writtenOn": "2023-06-12T19:41:46Z",
|
||||
"side": 1,
|
||||
"message": "Since we don\u0027t know beforehand every impacted area, the spec should be generic at this point.",
|
||||
"parentUuid": "ca997b9a_6453bbe1",
|
||||
"revId": "b3e3cc575c8f446092b1515da151e444d070f26b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -333,6 +627,24 @@
|
|||
"parentUuid": "69c5359b_b0cc013a",
|
||||
"revId": "b3e3cc575c8f446092b1515da151e444d070f26b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "e3d7eded_fc59ee6b",
|
||||
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010737-configurable-power-management.rst",
|
||||
"patchSetId": 22
|
||||
},
|
||||
"lineNbr": 366,
|
||||
"author": {
|
||||
"id": 35106
|
||||
},
|
||||
"writtenOn": "2023-06-12T19:41:46Z",
|
||||
"side": 1,
|
||||
"message": "We will add the Upgrade test in the list.",
|
||||
"parentUuid": "d2d3c1ff_e3bfcbe4",
|
||||
"revId": "b3e3cc575c8f446092b1515da151e444d070f26b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
Reference in New Issue