starlingx
/
specs
Code Issues Proposed changes

Update patch set 3 

Patch Set 3: Code-Review-1

(5 comments)

Patch-set: 3
Reviewer: Gerrit User 8768 <8768@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, c80004d733bcb8e5c40b647e184baa694fb8a722
Attention: {"person_ident":"Gerrit User 8768 \u003c8768@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_8768\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 29042 \u003c29042@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_8768\u003e replied on the change"}
This commit is contained in:
Gerrit User 8768 2023-08-10 23:14:51 +00:00 committed by Gerrit Code Review
parent b2d62137d6
commit 8ce85c3aa0
1 changed files with 119 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

119
6369481e9a7952f62775cb53b110a2e2fded2e7c Normal file
View File

@ -0,0 +1,119 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "58e6705a_013030fe",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-ARM-platform.rst",
"patchSetId": 3
},
"lineNbr": 123,
"author": {
"id": 8768
},
"writtenOn": "2023-08-10T23:14:51Z",
"side": 1,
"message": "this should not be part of the starlingx spec",
"range": {
"startLine": 123,
"startChar": 0,
"endLine": 123,
"endChar": 59
},
"revId": "6369481e9a7952f62775cb53b110a2e2fded2e7c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "dee82c40_ca0e145f",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-ARM-platform.rst",
"patchSetId": 3
},
"lineNbr": 134,
"author": {
"id": 8768
},
"writtenOn": "2023-08-10T23:14:51Z",
"side": 1,
"message": "why wrlinux rather than ARM64 Debian? Will that make it harder for non-Windriver people to build StarlingX for arm?",
"range": {
"startLine": 134,
"startChar": 19,
"endLine": 134,
"endChar": 62
},
"revId": "6369481e9a7952f62775cb53b110a2e2fded2e7c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "9f34cf65_bf759d21",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-ARM-platform.rst",
"patchSetId": 3
},
"lineNbr": 148,
"author": {
"id": 8768
},
"writtenOn": "2023-08-10T23:14:51Z",
"side": 1,
"message": "duplicate \"the\"",
"range": {
"startLine": 148,
"startChar": 0,
"endLine": 148,
"endChar": 7
},
"revId": "6369481e9a7952f62775cb53b110a2e2fded2e7c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "da84d239_9bc72654",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-ARM-platform.rst",
"patchSetId": 3
},
"lineNbr": 148,
"author": {
"id": 8768
},
"writtenOn": "2023-08-10T23:14:51Z",
"side": 1,
"message": "what does \"will be used preferentially\" mean? Would they be used instead of the non-arch-specific file (implying that you have to duplicate all the contents of the non-arch-specific file), or would they specify additions to the non-arch-specific file?",
"range": {
"startLine": 148,
"startChar": 37,
"endLine": 148,
"endChar": 65
},
"revId": "6369481e9a7952f62775cb53b110a2e2fded2e7c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "8f4ae170_e9b9413b",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-ARM-platform.rst",
"patchSetId": 3
},
"lineNbr": 150,
"author": {
"id": 8768
},
"writtenOn": "2023-08-10T23:14:51Z",
"side": 1,
"message": "are we expecting not to need x86-specific files?",
"range": {
"startLine": 150,
"startChar": 41,
"endLine": 150,
"endChar": 53
},
"revId": "6369481e9a7952f62775cb53b110a2e2fded2e7c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}