starlingx
/
specs
Code Issues Proposed changes

Update patch set 23 

Patch Set 23:

(3 comments)

Patch-set: 23
Attention: {"person_ident":"Gerrit User 33265 \u003c33265@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_33265\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 35106 \u003c35106@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_33265\u003e replied on the change"}
This commit is contained in:
Gerrit User 33265 2023-06-12 21:35:16 +00:00 committed by Gerrit Code Review
parent 46f6baeef7
commit b7c6f55236
2 changed files with 75 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
75f22eb4598b5f2dc6dcd69c07f61697e9448a1a Normal file
View File

@ -0,0 +1,27 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "83fa7578_5576e604",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010737-configurable-power-management.rst",
"patchSetId": 23
},
"lineNbr": 235,
"author": {
"id": 33265
},
"writtenOn": "2023-06-12T21:35:16Z",
"side": 1,
"message": "This appears to be vague. Do we know the impact? Is it possible to articulate the impact when the user configures deprecated parameters? If it will degrade the system behavior (especially performance), then it should not be ignored.",
"range": {
"startLine": 234,
"startChar": 38,
"endLine": 235,
"endChar": 15
},
"revId": "75f22eb4598b5f2dc6dcd69c07f61697e9448a1a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

48
b3e3cc575c8f446092b1515da151e444d070f26b
View File

@ -458,6 +458,30 @@
"revId": "b3e3cc575c8f446092b1515da151e444d070f26b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "39ef79d9_c7c16b6c",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010737-configurable-power-management.rst",
"patchSetId": 22
},
"lineNbr": 248,
"author": {
"id": 33265
},
"writtenOn": "2023-06-12T21:35:16Z",
"side": 1,
"message": "If appropriate, please rephrase to something like \u0027C0 to C10\u0027 based on the CPU family. And, please update other references to Cn.",
"parentUuid": "da9f82a9_8c69624c",
"range": {
"startLine": 248,
"startChar": 37,
"endLine": 248,
"endChar": 39
},
"revId": "b3e3cc575c8f446092b1515da151e444d070f26b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -505,6 +529,30 @@
"revId": "b3e3cc575c8f446092b1515da151e444d070f26b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "9ee845a2_f424f8f5",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010737-configurable-power-management.rst",
"patchSetId": 22
},
"lineNbr": 266,
"author": {
"id": 33265
},
"writtenOn": "2023-06-12T21:35:16Z",
"side": 1,
"message": "Ok. If appropriate, please add a reference (instead of duplicating content) in the documentation",
"parentUuid": "8ded5d47_05c028a7",
"range": {
"startLine": 262,
"startChar": 0,
"endLine": 266,
"endChar": 18
},
"revId": "b3e3cc575c8f446092b1515da151e444d070f26b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {