starlingx
/
specs
Code Issues Proposed changes

Update patch set 12 

Patch Set 12:

(13 comments)

Patch-set: 12
This commit is contained in:
Gerrit User 35858 2023-06-22 08:51:12 +00:00 committed by Gerrit Code Review
parent 25e71a0a1c
commit dffacea61f
3 changed files with 303 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

72
61d5f7f4f9a09af61d08f13b2c869080b97a8726
View File

@ -40,6 +40,30 @@
"revId": "61d5f7f4f9a09af61d08f13b2c869080b97a8726",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "41625577_b091a671",
"filename": "doc/source/specs/stx-9.0/approved/IEO_Starlingx_Spec_submission.rst",
"patchSetId": 11
},
"lineNbr": 16,
"author": {
"id": 35858
},
"writtenOn": "2023-06-22T08:51:12Z",
"side": 1,
"message": "Done",
"parentUuid": "ee3a83d5_d533ea61",
"range": {
"startLine": 16,
"startChar": 17,
"endLine": 16,
"endChar": 22
},
"revId": "61d5f7f4f9a09af61d08f13b2c869080b97a8726",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -63,6 +87,30 @@
"revId": "61d5f7f4f9a09af61d08f13b2c869080b97a8726",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "14b07bca_528d51df",
"filename": "doc/source/specs/stx-9.0/approved/IEO_Starlingx_Spec_submission.rst",
"patchSetId": 11
},
"lineNbr": 45,
"author": {
"id": 35858
},
"writtenOn": "2023-06-22T08:51:12Z",
"side": 1,
"message": "Using \"pods\" now.",
"parentUuid": "27c93368_8a94f3ac",
"range": {
"startLine": 45,
"startChar": 40,
"endLine": 45,
"endChar": 44
},
"revId": "61d5f7f4f9a09af61d08f13b2c869080b97a8726",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -85,6 +133,30 @@
},
"revId": "61d5f7f4f9a09af61d08f13b2c869080b97a8726",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "a6e17706_9bed65a1",
"filename": "doc/source/specs/stx-9.0/approved/IEO_Starlingx_Spec_submission.rst",
"patchSetId": 11
},
"lineNbr": 81,
"author": {
"id": 35858
},
"writtenOn": "2023-06-22T08:51:12Z",
"side": 1,
"message": "Added clarification as to what condition means.",
"parentUuid": "87701247_629d0c20",
"range": {
"startLine": 81,
"startChar": 3,
"endLine": 81,
"endChar": 13
},
"revId": "61d5f7f4f9a09af61d08f13b2c869080b97a8726",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

21
d23af98a83a5f42f03735ff8b07d3052dbb5814e Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "ffb986cd_a92a0235",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 12
},
"lineNbr": 0,
"author": {
"id": 35858
},
"writtenOn": "2023-06-22T08:51:12Z",
"side": 1,
"message": "Thanks for review Ramaswamy. Addressed your comments.",
"revId": "d23af98a83a5f42f03735ff8b07d3052dbb5814e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

210
f56c4f46fa118c34ff34ebabd4b6011a07a6fb6a
View File

@ -233,6 +233,30 @@
"revId": "f56c4f46fa118c34ff34ebabd4b6011a07a6fb6a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "94d2e0c4_f5dda3bd",
"filename": "doc/source/specs/stx-9.0/approved/IEO_Starlingx_Spec_submission.rst",
"patchSetId": 10
},
"lineNbr": 42,
"author": {
"id": 35858
},
"writtenOn": "2023-06-22T08:51:12Z",
"side": 1,
"message": "Added.",
"parentUuid": "e583bce4_8f630279",
"range": {
"startLine": 39,
"startChar": 0,
"endLine": 42,
"endChar": 19
},
"revId": "f56c4f46fa118c34ff34ebabd4b6011a07a6fb6a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -526,6 +550,30 @@
"revId": "f56c4f46fa118c34ff34ebabd4b6011a07a6fb6a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "7a70b3e1_ba41b629",
"filename": "doc/source/specs/stx-9.0/approved/IEO_Starlingx_Spec_submission.rst",
"patchSetId": 10
},
"lineNbr": 77,
"author": {
"id": 35858
},
"writtenOn": "2023-06-22T08:51:12Z",
"side": 1,
"message": "Since the feature is operator I replaced project with operator.",
"parentUuid": "25c2e57b_6ce0556a",
"range": {
"startLine": 77,
"startChar": 14,
"endLine": 77,
"endChar": 21
},
"revId": "f56c4f46fa118c34ff34ebabd4b6011a07a6fb6a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -737,6 +785,30 @@
"revId": "f56c4f46fa118c34ff34ebabd4b6011a07a6fb6a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "b6115653_ff77f46f",
"filename": "doc/source/specs/stx-9.0/approved/IEO_Starlingx_Spec_submission.rst",
"patchSetId": 10
},
"lineNbr": 267,
"author": {
"id": 35858
},
"writtenOn": "2023-06-22T08:51:12Z",
"side": 1,
"message": "It\u0027s RO in both, added mention about 8.0.",
"parentUuid": "c8f493a7_f64a9392",
"range": {
"startLine": 267,
"startChar": 13,
"endLine": 267,
"endChar": 17
},
"revId": "f56c4f46fa118c34ff34ebabd4b6011a07a6fb6a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -760,6 +832,30 @@
"revId": "f56c4f46fa118c34ff34ebabd4b6011a07a6fb6a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "3e69d399_c34a3633",
"filename": "doc/source/specs/stx-9.0/approved/IEO_Starlingx_Spec_submission.rst",
"patchSetId": 10
},
"lineNbr": 277,
"author": {
"id": 35858
},
"writtenOn": "2023-06-22T08:51:12Z",
"side": 1,
"message": "Updated. Contribution which enables it is already made.",
"parentUuid": "8d83269f_e5882c35",
"range": {
"startLine": 267,
"startChar": 0,
"endLine": 277,
"endChar": 26
},
"revId": "f56c4f46fa118c34ff34ebabd4b6011a07a6fb6a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -777,6 +873,24 @@
"revId": "f56c4f46fa118c34ff34ebabd4b6011a07a6fb6a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "aa152f3c_b82b9f72",
"filename": "doc/source/specs/stx-9.0/approved/IEO_Starlingx_Spec_submission.rst",
"patchSetId": 10
},
"lineNbr": 282,
"author": {
"id": 35858
},
"writtenOn": "2023-06-22T08:51:12Z",
"side": 1,
"message": "It doesn\u0027t.",
"parentUuid": "153881ff_98ceafda",
"revId": "f56c4f46fa118c34ff34ebabd4b6011a07a6fb6a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -894,6 +1008,30 @@
"revId": "f56c4f46fa118c34ff34ebabd4b6011a07a6fb6a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "e8785ead_6433d56f",
"filename": "doc/source/specs/stx-9.0/approved/IEO_Starlingx_Spec_submission.rst",
"patchSetId": 10
},
"lineNbr": 337,
"author": {
"id": 35858
},
"writtenOn": "2023-06-22T08:51:12Z",
"side": 1,
"message": "Operator doesn\u0027t have any backup functionality. Firmware flashed to E810 NIC can always be reverted back by triggering downgrade (to chosen version), same with DDP profile.",
"parentUuid": "fc537dd6_256d5c46",
"range": {
"startLine": 337,
"startChar": 30,
"endLine": 337,
"endChar": 47
},
"revId": "f56c4f46fa118c34ff34ebabd4b6011a07a6fb6a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -917,6 +1055,30 @@
"revId": "f56c4f46fa118c34ff34ebabd4b6011a07a6fb6a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "d39da4ee_22e8fef4",
"filename": "doc/source/specs/stx-9.0/approved/IEO_Starlingx_Spec_submission.rst",
"patchSetId": 10
},
"lineNbr": 364,
"author": {
"id": 35858
},
"writtenOn": "2023-06-22T08:51:12Z",
"side": 1,
"message": "Done",
"parentUuid": "10389439_d20e0647",
"range": {
"startLine": 364,
"startChar": 0,
"endLine": 364,
"endChar": 22
},
"revId": "f56c4f46fa118c34ff34ebabd4b6011a07a6fb6a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -940,6 +1102,30 @@
"revId": "f56c4f46fa118c34ff34ebabd4b6011a07a6fb6a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "e504b1a6_22c6b496",
"filename": "doc/source/specs/stx-9.0/approved/IEO_Starlingx_Spec_submission.rst",
"patchSetId": 10
},
"lineNbr": 378,
"author": {
"id": 35858
},
"writtenOn": "2023-06-22T08:51:12Z",
"side": 1,
"message": "Done",
"parentUuid": "dc82ce17_07524e84",
"range": {
"startLine": 378,
"startChar": 0,
"endLine": 378,
"endChar": 60
},
"revId": "f56c4f46fa118c34ff34ebabd4b6011a07a6fb6a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -962,6 +1148,30 @@
},
"revId": "f56c4f46fa118c34ff34ebabd4b6011a07a6fb6a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "7f520362_f1876f84",
"filename": "doc/source/specs/stx-9.0/approved/IEO_Starlingx_Spec_submission.rst",
"patchSetId": 10
},
"lineNbr": 385,
"author": {
"id": 35858
},
"writtenOn": "2023-06-22T08:51:12Z",
"side": 1,
"message": "Done",
"parentUuid": "8e859ae2_cd78b2b7",
"range": {
"startLine": 383,
"startChar": 0,
"endLine": 385,
"endChar": 31
},
"revId": "f56c4f46fa118c34ff34ebabd4b6011a07a6fb6a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}