starlingx
/
update
Code Issues Proposed changes

Update patch set 5 

Patch Set 5:

(3 comments)

Patch-set: 5
This commit is contained in:
Gerrit User 9926 2024-04-24 20:44:14 +00:00 committed by Gerrit Code Review
parent 8f137ed3fe
commit 765455b23e
1 changed files with 55 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
c4004bb0fb51498c055ccfdf299644db04227d97 Normal file
View File

@ -0,0 +1,55 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "60e7f52d_ce76225c",
"filename": "/COMMIT_MSG",
"patchSetId": 5
},
"lineNbr": 9,
"author": {
"id": 9926
},
"writtenOn": "2024-04-24T20:44:14Z",
"side": 1,
"message": "describe the issue in code and the fix",
"revId": "c4004bb0fb51498c055ccfdf299644db04227d97",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "bedd8d15_e98f607e",
"filename": "/COMMIT_MSG",
"patchSetId": 5
},
"lineNbr": 47,
"author": {
"id": 9926
},
"writtenOn": "2024-04-24T20:44:14Z",
"side": 1,
"message": "TestPlan should include InService Patch (i.e. non-reboot required) patch",
"revId": "c4004bb0fb51498c055ccfdf299644db04227d97",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "fb25232f_e702a4b4",
"filename": "sw-patch/cgcs-patch/cgcs_patch/patch_controller.py",
"patchSetId": 5
},
"lineNbr": 859,
"author": {
"id": 9926
},
"writtenOn": "2024-04-24T20:44:14Z",
"side": 1,
"message": "Code comment should include the scope of the new code changes and why",
"revId": "c4004bb0fb51498c055ccfdf299644db04227d97",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}