starlingx
/
update
Code Issues Proposed changes

Update patch set 5 

Patch Set 5:

(3 comments)

Patch-set: 5
Attention: {"person_ident":"Gerrit User 9926 \u003c9926@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_9926\u003e replied on the change"}
This commit is contained in:
Gerrit User 9926 2024-05-02 15:45:54 +00:00 committed by Gerrit Code Review
parent e45d71974c
commit 9ed2665d8d
1 changed files with 73 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

73
d81c284f3ba724339aca8020a06ae6e65bb8f37c Normal file
View File

@ -0,0 +1,73 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "d8166b4a_67d69f48",
"filename": "software/software/software_functions.py",
"patchSetId": 5
},
"lineNbr": 1358,
"author": {
"id": 9926
},
"writtenOn": "2024-05-02T15:45:54Z",
"side": 1,
"message": "this should be a new db_api, such as get_deploy_one()",
"range": {
"startLine": 1358,
"startChar": 13,
"endLine": 1358,
"endChar": 48
},
"revId": "d81c284f3ba724339aca8020a06ae6e65bb8f37c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "762905f7_44103dd2",
"filename": "software/software/software_functions.py",
"patchSetId": 5
},
"lineNbr": 1364,
"author": {
"id": 9926
},
"writtenOn": "2024-05-02T15:45:54Z",
"side": 1,
"message": "nit: does not",
"range": {
"startLine": 1364,
"startChar": 43,
"endLine": 1364,
"endChar": 48
},
"revId": "d81c284f3ba724339aca8020a06ae6e65bb8f37c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "2cb61208_248a71cf",
"filename": "software/software/software_functions.py",
"patchSetId": 5
},
"lineNbr": 1365,
"author": {
"id": 9926
},
"writtenOn": "2024-05-02T15:45:54Z",
"side": 1,
"message": "should be a defined constant",
"range": {
"startLine": 1365,
"startChar": 18,
"endLine": 1365,
"endChar": 35
},
"revId": "d81c284f3ba724339aca8020a06ae6e65bb8f37c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}