Update patch set 1

Patch Set 1:

(5 comments)

Patch-set: 1
Label: Workflow=0
This commit is contained in:
Gerrit User 15435 2018-08-24 13:13:47 +00:00 committed by Gerrit Code Review
parent 8c0f9dcee7
commit 9f3ca19c41
1 changed files with 95 additions and 0 deletions

View File

@ -0,0 +1,95 @@
{
"comments": [
{
"key": {
"uuid": "3f79a3b5_6bb34cea",
"filename": "cgcs-patch/cgcs-patch/cgcs_patch/authapi/auth_token.py",
"patchSetId": 1
},
"lineNbr": 41,
"author": {
"id": 15435
},
"writtenOn": "2018-08-24T13:13:47Z",
"side": 1,
"message": "I assume pep8 will pass here (line too wide)",
"range": {
"startLine": 41,
"startChar": 77,
"endLine": 41,
"endChar": 78
},
"revId": "e929a06659ac379ca9f43c6708b8e9de3f9e6180",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_cbe0609a",
"filename": "pylint.rc",
"patchSetId": 1
},
"lineNbr": 30,
"author": {
"id": 15435
},
"writtenOn": "2018-08-24T13:13:47Z",
"side": 1,
"message": "up to you. You are not disabling two of the warnings you have commented listed for.",
"revId": "e929a06659ac379ca9f43c6708b8e9de3f9e6180",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_8bf02869",
"filename": "pylint.rc",
"patchSetId": 1
},
"lineNbr": 37,
"author": {
"id": 15435
},
"writtenOn": "2018-08-24T13:13:47Z",
"side": 1,
"message": "You prob dont need this line either",
"revId": "e929a06659ac379ca9f43c6708b8e9de3f9e6180",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_cbf9404e",
"filename": "pylint.rc",
"patchSetId": 1
},
"lineNbr": 91,
"author": {
"id": 15435
},
"writtenOn": "2018-08-24T13:13:47Z",
"side": 1,
"message": "This is not the VIM. Likely most of the ignored-classes here can be removed",
"revId": "e929a06659ac379ca9f43c6708b8e9de3f9e6180",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_cb8e20d0",
"filename": "tox.ini",
"patchSetId": 1
},
"lineNbr": 36,
"author": {
"id": 15435
},
"writtenOn": "2018-08-24T13:13:47Z",
"side": 1,
"message": "This is the line that is breaking the other tox jobs. You should be able to put this in the pylint target, and then update zuul to require this project",
"revId": "e929a06659ac379ca9f43c6708b8e9de3f9e6180",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}