starlingx
/
update
Code Issues Proposed changes

Update patch set 4 

Patch Set 4:

(2 comments)

Patch-set: 4
Attention: {"person_ident":"Gerrit User 33390 \u003c33390@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_9926\u003e replied on the change"}
This commit is contained in:
Gerrit User 9926 2024-04-30 19:10:32 +00:00 committed by Gerrit Code Review
parent c0df2ce71a
commit d5dabcaf33
1 changed files with 40 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
ee78efb5f769d7dcf7bfcb299aa083dd61ec1e04
View File

@ -16,6 +16,46 @@
"message": "Rebased to resolve Merge Conflicts.",
"revId": "ee78efb5f769d7dcf7bfcb299aa083dd61ec1e04",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "a8a3004a_35262d6f",
"filename": "software/software/ostree_utils.py",
"patchSetId": 4
},
"lineNbr": 579,
"author": {
"id": 9926
},
"writtenOn": "2024-04-30T19:10:32Z",
"side": 1,
"message": "should consider minimizing use of shell in future e.g. 00575b6dc20c9a161c9aa8c35e3717bb74c7440c",
"range": {
"startLine": 579,
"startChar": 46,
"endLine": 579,
"endChar": 56
},
"revId": "ee78efb5f769d7dcf7bfcb299aa083dd61ec1e04",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "f379702f_6ec41c4a",
"filename": "software/software/software_agent.py",
"patchSetId": 4
},
"lineNbr": 580,
"author": {
"id": 9926
},
"writtenOn": "2024-04-30T19:10:32Z",
"side": 1,
"message": "would the major release install be able to be retried by the vim orchestrator after this point?",
"revId": "ee78efb5f769d7dcf7bfcb299aa083dd61ec1e04",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}