Update patch set 2

Patch Set 2: (5 comments) Patch-set: 2 Attention: {"person_ident":"Gerrit User 33390 \u003c33390@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_33390\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 33684 \u003c33684@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_33390\u003e replied on the change"}
2024-04-26 19:23:55 +00:00 · 2024-04-26 19:23:55 +00:00 · ebd3c5ce0e
parent eb5b6f0815
commit ebd3c5ce0e
1 changed files with 119 additions and 0 deletions
--- a/119
+++ b/119
@ -0,0 +1,119 @@
+{
+  "comments": [
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "362d7d75_cdf04636",
+        "filename": "/COMMIT_MSG",
+        "patchSetId": 2
+      },
+      "lineNbr": 13,
+      "author": {
+        "id": 33390
+      },
+      "writtenOn": "2024-04-26T19:23:55Z",
+      "side": 1,
+      "message": "What about host-done, host-failed, activate-failed? If deleting a deployment is to allow the system to be rolled-back, then I guess it should include all these states.",
+      "range": {
+        "startLine": 12,
+        "startChar": 36,
+        "endLine": 13,
+        "endChar": 10
+      },
+      "revId": "9c41dea4a861f9dffa55a78537940e00807aa75c",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "70335652_6d7feb93",
+        "filename": "/COMMIT_MSG",
+        "patchSetId": 2
+      },
+      "lineNbr": 20,
+      "author": {
+        "id": 33390
+      },
+      "writtenOn": "2024-04-26T19:23:55Z",
+      "side": 1,
+      "message": "Also there is some data under /var/lib/postgres, like the target major release migrated database data files.",
+      "range": {
+        "startLine": 18,
+        "startChar": 25,
+        "endLine": 20,
+        "endChar": 37
+      },
+      "revId": "9c41dea4a861f9dffa55a78537940e00807aa75c",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "f2a90225_8b7eaad4",
+        "filename": "/COMMIT_MSG",
+        "patchSetId": 2
+      },
+      "lineNbr": 26,
+      "author": {
+        "id": 33390
+      },
+      "writtenOn": "2024-04-26T19:23:55Z",
+      "side": 1,
+      "message": "nit: Folders",
+      "range": {
+        "startLine": 26,
+        "startChar": 6,
+        "endLine": 26,
+        "endChar": 14
+      },
+      "revId": "9c41dea4a861f9dffa55a78537940e00807aa75c",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "ee84d0a4_2778eb37",
+        "filename": "software/software/software_controller.py",
+        "patchSetId": 2
+      },
+      "lineNbr": 2654,
+      "author": {
+        "id": 33390
+      },
+      "writtenOn": "2024-04-26T19:23:55Z",
+      "side": 1,
+      "message": "Please see my comment on the commit msg regarding the states. I believe more states should be listed here.",
+      "range": {
+        "startLine": 2654,
+        "startChar": 27,
+        "endLine": 2654,
+        "endChar": 105
+      },
+      "revId": "9c41dea4a861f9dffa55a78537940e00807aa75c",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "741988b7_df9efc77",
+        "filename": "software/software/software_controller.py",
+        "patchSetId": 2
+      },
+      "lineNbr": 2698,
+      "author": {
+        "id": 33390
+      },
+      "writtenOn": "2024-04-26T19:23:55Z",
+      "side": 1,
+      "message": "Alternatively you could pass ignore_errors\u003dTrue without the \"if\"",
+      "range": {
+        "startLine": 2698,
+        "startChar": 34,
+        "endLine": 2698,
+        "endChar": 38
+      },
+      "revId": "9c41dea4a861f9dffa55a78537940e00807aa75c",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    }
+  ]
+}