starlingx
/
update
Code Issues Proposed changes

Update patch set 6 

Patch Set 6:

(2 comments)

Patch-set: 6
Attention: {"person_ident":"Gerrit User 33684 \u003c33684@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_33684\u003e replied on the change"}
This commit is contained in:
Gerrit User 33684 2024-04-24 21:02:29 +00:00 committed by Gerrit Code Review
parent 40281f83a0
commit f0262e7b22
1 changed files with 46 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
c96da8ef26958fe6e07531eb7570dcb609e49ad6
View File

@ -17,6 +17,52 @@
"revId": "c96da8ef26958fe6e07531eb7570dcb609e49ad6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "0b2e837f_005a5e07",
"filename": "software-client/software_client/common/base.py",
"patchSetId": 6
},
"lineNbr": 59,
"author": {
"id": 33684
},
"writtenOn": "2024-04-24T21:02:29Z",
"side": 1,
"message": "shouldn\u0027t be good to add **kwargs here in case of need parameters/body to a delete operation?",
"range": {
"startLine": 59,
"startChar": 4,
"endLine": 59,
"endChar": 27
},
"revId": "c96da8ef26958fe6e07531eb7570dcb609e49ad6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "ce8c3fe8_6d7ddf22",
"filename": "software/software/api/controllers/v1/release.py",
"patchSetId": 6
},
"lineNbr": 45,
"author": {
"id": 33684
},
"writtenOn": "2024-04-24T21:02:29Z",
"side": 1,
"message": "Do we need this log?",
"range": {
"startLine": 45,
"startChar": 8,
"endLine": 45,
"endChar": 40
},
"revId": "c96da8ef26958fe6e07531eb7570dcb609e49ad6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {