diff --git a/0c7cdcc94a07efdb8c323179322e46a6a7ce99a8 b/0c7cdcc94a07efdb8c323179322e46a6a7ce99a8 new file mode 100644 index 00000000..4d323a95 --- /dev/null +++ b/0c7cdcc94a07efdb8c323179322e46a6a7ce99a8 @@ -0,0 +1,27 @@ +{ + "comments": [ + { + "unresolved": true, + "key": { + "uuid": "16bf0aa7_74ec4bef", + "filename": "software/software/software_controller.py", + "patchSetId": 4 + }, + "lineNbr": 3052, + "author": { + "id": 33390 + }, + "writtenOn": "2024-04-26T18:56:17Z", + "side": 1, + "message": "This function is more complex than it needs, please see https://opendev.org/starlingx/update/src/commit/1d6add41a22ebed6a99517915147a5244cf5c6a5/software/software/software_controller.py#L3038-L3058\n\n\nIt could be like:\n\n```\ndeploy \u003d self.get_software_upgrade()\nif deploy:\n from_major_release \u003d \".\".join(deploy.get(\"from_release\").rsplit(\".\")[:-1])\n to_major_release \u003d \".\".join(deploy.get(\"to_release\").rsplit(\".\")[:-1]\n return from_major_release !\u003d to_major_release\nreturn None\n```\n\nBy the way, the function `get_software_upgrade` should be renamed, as it seems to get any deployment in progress, regardless if it is patch or major release.", + "range": { + "startLine": 3039, + "startChar": 4, + "endLine": 3052, + "endChar": 35 + }, + "revId": "0c7cdcc94a07efdb8c323179322e46a6a7ce99a8", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + } + ] +} \ No newline at end of file