96 lines
3.5 KiB
Plaintext
96 lines
3.5 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "7a9ab605_59b98086",
|
|
"filename": "software/software/software_controller.py",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 2739,
|
|
"author": {
|
|
"id": 9926
|
|
},
|
|
"writtenOn": "2024-04-26T19:09:57Z",
|
|
"side": 1,
|
|
"message": "this variable isnt really required, since not referenced elsewhere",
|
|
"range": {
|
|
"startLine": 2739,
|
|
"startChar": 8,
|
|
"endLine": 2739,
|
|
"endChar": 28
|
|
},
|
|
"revId": "0c7cdcc94a07efdb8c323179322e46a6a7ce99a8",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "36b04eef_e0738a11",
|
|
"filename": "software/software/software_controller.py",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 3047,
|
|
"author": {
|
|
"id": 9926
|
|
},
|
|
"writtenOn": "2024-04-26T19:09:57Z",
|
|
"side": 1,
|
|
"message": "this should resuse self._get_software_upgrade() to obtain the from_release, to_release",
|
|
"range": {
|
|
"startLine": 3044,
|
|
"startChar": 0,
|
|
"endLine": 3047,
|
|
"endChar": 60
|
|
},
|
|
"revId": "0c7cdcc94a07efdb8c323179322e46a6a7ce99a8",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "ca89c4ae_f35883ad",
|
|
"filename": "software/software/software_controller.py",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 3050,
|
|
"author": {
|
|
"id": 9926
|
|
},
|
|
"writtenOn": "2024-04-26T19:09:57Z",
|
|
"side": 1,
|
|
"message": "This may not be needed if all we need to do is check the return value of from_release and to_release from _get_software_upgrade() ... \n\notherwise, could this check use some of the Version methods?\n\n\nfrom_release \u003d version.Version(from_release)\nto_release \u003d version.Version(to_release)\n\nif from_release.major !\u003d to_release.major or from_release.minor !\u003d to_release.minor: \n\n....",
|
|
"range": {
|
|
"startLine": 3048,
|
|
"startChar": 1,
|
|
"endLine": 3050,
|
|
"endChar": 82
|
|
},
|
|
"revId": "0c7cdcc94a07efdb8c323179322e46a6a7ce99a8",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "16bf0aa7_74ec4bef",
|
|
"filename": "software/software/software_controller.py",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 3052,
|
|
"author": {
|
|
"id": 33390
|
|
},
|
|
"writtenOn": "2024-04-26T18:56:17Z",
|
|
"side": 1,
|
|
"message": "This function is more complex than it needs, please see https://opendev.org/starlingx/update/src/commit/1d6add41a22ebed6a99517915147a5244cf5c6a5/software/software/software_controller.py#L3038-L3058\n\n\nIt could be like:\n\n```\ndeploy \u003d self.get_software_upgrade()\nif deploy:\n from_major_release \u003d \".\".join(deploy.get(\"from_release\").rsplit(\".\")[:-1])\n to_major_release \u003d \".\".join(deploy.get(\"to_release\").rsplit(\".\")[:-1]\n return from_major_release !\u003d to_major_release\nreturn None\n```\n\nBy the way, the function `get_software_upgrade` should be renamed, as it seems to get any deployment in progress, regardless if it is patch or major release.",
|
|
"range": {
|
|
"startLine": 3039,
|
|
"startChar": 4,
|
|
"endLine": 3052,
|
|
"endChar": 35
|
|
},
|
|
"revId": "0c7cdcc94a07efdb8c323179322e46a6a7ce99a8",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |