update/9c41dea4a861f9dffa55a78537940e00807aa75c

{
  "comments": [
    {
      "unresolved": true,
      "key": {
        "uuid": "362d7d75_cdf04636",
        "filename": "/COMMIT_MSG",
        "patchSetId": 2
      },
      "lineNbr": 13,
      "author": {
        "id": 33390
      },
      "writtenOn": "2024-04-26T19:23:55Z",
      "side": 1,
      "message": "What about host-done, host-failed, activate-failed? If deleting a deployment is to allow the system to be rolled-back, then I guess it should include all these states.",
      "range": {
        "startLine": 12,
        "startChar": 36,
        "endLine": 13,
        "endChar": 10
      },
      "revId": "9c41dea4a861f9dffa55a78537940e00807aa75c",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "2b147efd_d303563f",
        "filename": "/COMMIT_MSG",
        "patchSetId": 2
      },
      "lineNbr": 13,
      "author": {
        "id": 33684
      },
      "writtenOn": "2024-04-26T20:14:56Z",
      "side": 1,
      "message": "The deletion is not to allow the system to be rolled-back but to allow deletion of a deploy that is not complete. For the abort process this delete function should not be called but handled by the deploy abort itself.",
      "parentUuid": "362d7d75_cdf04636",
      "range": {
        "startLine": 12,
        "startChar": 36,
        "endLine": 13,
        "endChar": 10
      },
      "revId": "9c41dea4a861f9dffa55a78537940e00807aa75c",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "70335652_6d7feb93",
        "filename": "/COMMIT_MSG",
        "patchSetId": 2
      },
      "lineNbr": 20,
      "author": {
        "id": 33390
      },
      "writtenOn": "2024-04-26T19:23:55Z",
      "side": 1,
      "message": "Also there is some data under /var/lib/postgres, like the target major release migrated database data files.",
      "range": {
        "startLine": 18,
        "startChar": 25,
        "endLine": 20,
        "endChar": 37
      },
      "revId": "9c41dea4a861f9dffa55a78537940e00807aa75c",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "75588d5a_63bc8482",
        "filename": "/COMMIT_MSG",
        "patchSetId": 2
      },
      "lineNbr": 20,
      "author": {
        "id": 33684
      },
      "writtenOn": "2024-04-26T20:14:56Z",
      "side": 1,
      "message": "Good catch, it is deleted on the code but I forgot to mention here. Thanks.",
      "parentUuid": "70335652_6d7feb93",
      "range": {
        "startLine": 18,
        "startChar": 25,
        "endLine": 20,
        "endChar": 37
      },
      "revId": "9c41dea4a861f9dffa55a78537940e00807aa75c",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "f2a90225_8b7eaad4",
        "filename": "/COMMIT_MSG",
        "patchSetId": 2
      },
      "lineNbr": 26,
      "author": {
        "id": 33390
      },
      "writtenOn": "2024-04-26T19:23:55Z",
      "side": 1,
      "message": "nit: Folders",
      "range": {
        "startLine": 26,
        "startChar": 6,
        "endLine": 26,
        "endChar": 14
      },
      "revId": "9c41dea4a861f9dffa55a78537940e00807aa75c",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "b2fd6af3_b161e1c2",
        "filename": "/COMMIT_MSG",
        "patchSetId": 2
      },
      "lineNbr": 26,
      "author": {
        "id": 33684
      },
      "writtenOn": "2024-04-26T20:14:56Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "f2a90225_8b7eaad4",
      "range": {
        "startLine": 26,
        "startChar": 6,
        "endLine": 26,
        "endChar": 14
      },
      "revId": "9c41dea4a861f9dffa55a78537940e00807aa75c",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "ee84d0a4_2778eb37",
        "filename": "software/software/software_controller.py",
        "patchSetId": 2
      },
      "lineNbr": 2654,
      "author": {
        "id": 33390
      },
      "writtenOn": "2024-04-26T19:23:55Z",
      "side": 1,
      "message": "Please see my comment on the commit msg regarding the states. I believe more states should be listed here.",
      "range": {
        "startLine": 2654,
        "startChar": 27,
        "endLine": 2654,
        "endChar": 105
      },
      "revId": "9c41dea4a861f9dffa55a78537940e00807aa75c",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "edd63c2e_177179d7",
        "filename": "software/software/software_controller.py",
        "patchSetId": 2
      },
      "lineNbr": 2654,
      "author": {
        "id": 33684
      },
      "writtenOn": "2024-04-26T20:14:56Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "ee84d0a4_2778eb37",
      "range": {
        "startLine": 2654,
        "startChar": 27,
        "endLine": 2654,
        "endChar": 105
      },
      "revId": "9c41dea4a861f9dffa55a78537940e00807aa75c",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "741988b7_df9efc77",
        "filename": "software/software/software_controller.py",
        "patchSetId": 2
      },
      "lineNbr": 2698,
      "author": {
        "id": 33390
      },
      "writtenOn": "2024-04-26T19:23:55Z",
      "side": 1,
      "message": "Alternatively you could pass ignore_errors\u003dTrue without the \"if\"",
      "range": {
        "startLine": 2698,
        "startChar": 34,
        "endLine": 2698,
        "endChar": 38
      },
      "revId": "9c41dea4a861f9dffa55a78537940e00807aa75c",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "a72e5c2a_f0e29db7",
        "filename": "software/software/software_controller.py",
        "patchSetId": 2
      },
      "lineNbr": 2698,
      "author": {
        "id": 33684
      },
      "writtenOn": "2024-04-26T20:14:56Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "741988b7_df9efc77",
      "range": {
        "startLine": 2698,
        "startChar": 34,
        "endLine": 2698,
        "endChar": 38
      },
      "revId": "9c41dea4a861f9dffa55a78537940e00807aa75c",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    }
  ]
}