update/c96da8ef26958fe6e07531eb757...

290 lines
7.6 KiB
Plaintext

{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "7f18d3a2_9ccc7c2e",
"filename": "/COMMIT_MSG",
"patchSetId": 6
},
"lineNbr": 10,
"author": {
"id": 9926
},
"writtenOn": "2024-04-25T12:56:10Z",
"side": 1,
"message": "nit: standardized",
"range": {
"startLine": 10,
"startChar": 17,
"endLine": 10,
"endChar": 30
},
"revId": "c96da8ef26958fe6e07531eb7570dcb609e49ad6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "0f21ff87_5179e415",
"filename": "/COMMIT_MSG",
"patchSetId": 6
},
"lineNbr": 10,
"author": {
"id": 28466
},
"writtenOn": "2024-04-26T15:53:34Z",
"side": 1,
"message": "Done",
"parentUuid": "7f18d3a2_9ccc7c2e",
"range": {
"startLine": 10,
"startChar": 17,
"endLine": 10,
"endChar": 30
},
"revId": "c96da8ef26958fe6e07531eb7570dcb609e49ad6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "b360a347_99cd4ca7",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 6
},
"lineNbr": 0,
"author": {
"id": 33390
},
"writtenOn": "2024-04-24T17:47:10Z",
"side": 1,
"message": "Very nice Job Bin. Thanks.",
"revId": "c96da8ef26958fe6e07531eb7570dcb609e49ad6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "0b2e837f_005a5e07",
"filename": "software-client/software_client/common/base.py",
"patchSetId": 6
},
"lineNbr": 59,
"author": {
"id": 33684
},
"writtenOn": "2024-04-24T21:02:29Z",
"side": 1,
"message": "shouldn\u0027t be good to add **kwargs here in case of need parameters/body to a delete operation?",
"range": {
"startLine": 59,
"startChar": 4,
"endLine": 59,
"endChar": 27
},
"revId": "c96da8ef26958fe6e07531eb7570dcb609e49ad6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "88c5c828_c0de2ef8",
"filename": "software-client/software_client/common/http.py",
"patchSetId": 6
},
"lineNbr": 180,
"author": {
"id": 9926
},
"writtenOn": "2024-04-25T12:56:10Z",
"side": 1,
"message": "nit: response",
"range": {
"startLine": 180,
"startChar": 70,
"endLine": 180,
"endChar": 77
},
"revId": "c96da8ef26958fe6e07531eb7570dcb609e49ad6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "bf7a17ff_e6383c86",
"filename": "software-client/software_client/common/http.py",
"patchSetId": 6
},
"lineNbr": 180,
"author": {
"id": 28466
},
"writtenOn": "2024-04-26T15:53:34Z",
"side": 1,
"message": "Done",
"parentUuid": "88c5c828_c0de2ef8",
"range": {
"startLine": 180,
"startChar": 70,
"endLine": 180,
"endChar": 77
},
"revId": "c96da8ef26958fe6e07531eb7570dcb609e49ad6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "ce8c3fe8_6d7ddf22",
"filename": "software/software/api/controllers/v1/release.py",
"patchSetId": 6
},
"lineNbr": 45,
"author": {
"id": 33684
},
"writtenOn": "2024-04-24T21:02:29Z",
"side": 1,
"message": "Do we need this log?",
"range": {
"startLine": 45,
"startChar": 8,
"endLine": 45,
"endChar": 40
},
"revId": "c96da8ef26958fe6e07531eb7570dcb609e49ad6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "5c71c3a1_b985d9ca",
"filename": "software/software/authapi/app.py",
"patchSetId": 6
},
"lineNbr": 15,
"author": {
"id": 33390
},
"writtenOn": "2024-04-24T17:47:10Z",
"side": 1,
"message": "Should remove this commented import",
"range": {
"startLine": 15,
"startChar": 0,
"endLine": 15,
"endChar": 61
},
"revId": "c96da8ef26958fe6e07531eb7570dcb609e49ad6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "c11ee819_90226209",
"filename": "software/software/authapi/app.py",
"patchSetId": 6
},
"lineNbr": 15,
"author": {
"id": 28466
},
"writtenOn": "2024-04-26T15:53:34Z",
"side": 1,
"message": "Done",
"parentUuid": "5c71c3a1_b985d9ca",
"range": {
"startLine": 15,
"startChar": 0,
"endLine": 15,
"endChar": 61
},
"revId": "c96da8ef26958fe6e07531eb7570dcb609e49ad6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "625f9237_86db67f5",
"filename": "software/software/authapi/app.py",
"patchSetId": 6
},
"lineNbr": 59,
"author": {
"id": 33390
},
"writtenOn": "2024-04-24T17:47:10Z",
"side": 1,
"message": "Should remove this commented line as well",
"range": {
"startLine": 59,
"startChar": 8,
"endLine": 59,
"endChar": 43
},
"revId": "c96da8ef26958fe6e07531eb7570dcb609e49ad6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "bcf1d64e_541dad72",
"filename": "software/software/authapi/app.py",
"patchSetId": 6
},
"lineNbr": 59,
"author": {
"id": 28466
},
"writtenOn": "2024-04-26T15:53:34Z",
"side": 1,
"message": "Done",
"parentUuid": "625f9237_86db67f5",
"range": {
"startLine": 59,
"startChar": 8,
"endLine": 59,
"endChar": 43
},
"revId": "c96da8ef26958fe6e07531eb7570dcb609e49ad6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "157ebbf0_9b7c0956",
"filename": "software/software/software_controller.py",
"patchSetId": 6
},
"lineNbr": 2226,
"author": {
"id": 9926
},
"writtenOn": "2024-04-25T12:56:10Z",
"side": 1,
"message": "region_name as a parameter - Is it actually required by this controller which only runs in this region?",
"revId": "c96da8ef26958fe6e07531eb7570dcb609e49ad6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "b521e319_d59208f6",
"filename": "software/software/software_controller.py",
"patchSetId": 6
},
"lineNbr": 2226,
"author": {
"id": 28466
},
"writtenOn": "2024-04-26T15:53:34Z",
"side": 1,
"message": "This is not a required parameter. it is coming from the REST API. If specified, the precheck will be conducted against the specified region.",
"parentUuid": "157ebbf0_9b7c0956",
"revId": "c96da8ef26958fe6e07531eb7570dcb609e49ad6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}