update/ee78efb5f769d7dcf7bfcb299aa083dd61ec1e04

{
  "comments": [
    {
      "unresolved": false,
      "key": {
        "uuid": "5aa36fdc_af1092cf",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 4
      },
      "lineNbr": 0,
      "author": {
        "id": 33390
      },
      "writtenOn": "2024-04-30T18:18:20Z",
      "side": 1,
      "message": "Rebased to resolve Merge Conflicts.",
      "revId": "ee78efb5f769d7dcf7bfcb299aa083dd61ec1e04",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "a8a3004a_35262d6f",
        "filename": "software/software/ostree_utils.py",
        "patchSetId": 4
      },
      "lineNbr": 579,
      "author": {
        "id": 9926
      },
      "writtenOn": "2024-04-30T19:10:32Z",
      "side": 1,
      "message": "should consider minimizing use of shell in future e.g. 00575b6dc20c9a161c9aa8c35e3717bb74c7440c",
      "range": {
        "startLine": 579,
        "startChar": 46,
        "endLine": 579,
        "endChar": 56
      },
      "revId": "ee78efb5f769d7dcf7bfcb299aa083dd61ec1e04",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "f379702f_6ec41c4a",
        "filename": "software/software/software_agent.py",
        "patchSetId": 4
      },
      "lineNbr": 580,
      "author": {
        "id": 9926
      },
      "writtenOn": "2024-04-30T19:10:32Z",
      "side": 1,
      "message": "would the major release install be able to be retried by the vim orchestrator after this point?",
      "revId": "ee78efb5f769d7dcf7bfcb299aa083dd61ec1e04",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "ea7649fa_80b22a72",
        "filename": "software/software/software_agent.py",
        "patchSetId": 4
      },
      "lineNbr": 580,
      "author": {
        "id": 33390
      },
      "writtenOn": "2024-04-30T21:01:39Z",
      "side": 1,
      "message": "Yes. The \"deploy host\" command is reentrant, so if it fails here, the host will go to state \"failed\", but once in this state it is allowed to retry: https://opendev.org/starlingx/update/src/commit/5585c1fc3b14f4e82d58f486fc2781e387cbbec2/software/software/software_controller.py#L2711-L2713",
      "parentUuid": "f379702f_6ec41c4a",
      "revId": "ee78efb5f769d7dcf7bfcb299aa083dd61ec1e04",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    }
  ],
  "submitRequirementResults": [
    {
      "submitRequirement": {
        "name": "Code-Review",
        "description": {
          "value": "Code reviewed by core reviewer"
        },
        "applicabilityExpression": {},
        "submittabilityExpression": {
          "expressionString": "label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN"
        },
        "overrideExpression": {},
        "allowOverrideInChildProjects": true
      },
      "applicabilityExpressionResult": {},
      "submittabilityExpressionResult": {
        "value": {"expression":{"expressionString":"label:Code-Review=MAX AND -label:Code-Review=MIN"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["label:Code-Review=MAX"],"failingAtoms":["label:Code-Review=MIN"]}
      },
      "overrideExpressionResult": {},
      "patchSetCommitId": "ee78efb5f769d7dcf7bfcb299aa083dd61ec1e04",
      "legacy": {
        "value": false
      },
      "forced": {},
      "hidden": {}
    },
    {
      "submitRequirement": {
        "name": "Verified",
        "description": {
          "value": "Verified in gate by CI"
        },
        "applicabilityExpression": {},
        "submittabilityExpression": {
          "expressionString": "label:Verified\u003dMAX AND -label:Verified\u003dMIN"
        },
        "overrideExpression": {},
        "allowOverrideInChildProjects": false
      },
      "applicabilityExpressionResult": {},
      "submittabilityExpressionResult": {
        "value": {"expression":{"expressionString":"label:Verified=MAX AND -label:Verified=MIN"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["label:Verified=MAX"],"failingAtoms":["label:Verified=MIN"]}
      },
      "overrideExpressionResult": {},
      "patchSetCommitId": "ee78efb5f769d7dcf7bfcb299aa083dd61ec1e04",
      "legacy": {
        "value": false
      },
      "forced": {},
      "hidden": {}
    },
    {
      "submitRequirement": {
        "name": "Workflow",
        "description": {
          "value": "Approved for gate by core reviewer"
        },
        "applicabilityExpression": {},
        "submittabilityExpression": {
          "expressionString": "label:Workflow\u003dMAX AND -label:Workflow\u003dMIN"
        },
        "overrideExpression": {},
        "allowOverrideInChildProjects": false
      },
      "applicabilityExpressionResult": {},
      "submittabilityExpressionResult": {
        "value": {"expression":{"expressionString":"label:Workflow=MAX AND -label:Workflow=MIN"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["label:Workflow=MAX"],"failingAtoms":["label:Workflow=MIN"]}
      },
      "overrideExpressionResult": {},
      "patchSetCommitId": "ee78efb5f769d7dcf7bfcb299aa083dd61ec1e04",
      "legacy": {
        "value": false
      },
      "forced": {},
      "hidden": {}
    }
  ]
}