starlingx
/
upstream
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(1 comment)

Patch-set: 1
This commit is contained in:
Gerrit User 31646 2023-10-24 01:21:57 +00:00 committed by Gerrit Code Review
parent 3b9777e701
commit 26ffe19bdd
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
eb557c0450684931b48b6975c80f8ce05f45a3d4
View File

@ -70,6 +70,24 @@
"parentUuid": "476c317b_03bf6036",
"revId": "eb557c0450684931b48b6975c80f8ce05f45a3d4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "a19c3520_9e05bba5",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 31646
},
"writtenOn": "2023-10-24T01:21:57Z",
"side": 1,
"message": "One thought: \nWhen it comes to a package and it functions I\u0027d rather make my change on top of another patch that created a new function and modify that function rather than modify native function behavior. \nIf in the future we find that modifying a package native function does not break other functionality I can refactor this change.",
"parentUuid": "3d3530b8_484ff51d",
"revId": "eb557c0450684931b48b6975c80f8ce05f45a3d4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}