starlingx
/
upstream
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(1 comment)

Patch-set: 1
Attention: {"person_ident":"Gerrit User 31646 \u003c31646@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_31646\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 8768 \u003c8768@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_31646\u003e replied on the change"}
This commit is contained in:
Gerrit User 31646 2023-10-23 21:40:51 +00:00 committed by Gerrit Code Review
parent b7a1b2953e
commit 39f4ce9f8c
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
eb557c0450684931b48b6975c80f8ce05f45a3d4
View File

@ -16,6 +16,24 @@
"message": "this looks mostly okay, but I\u0027m wondering if it might make sense to find where the ownership is being reset and remove that code rather than adding new code.",
"revId": "eb557c0450684931b48b6975c80f8ce05f45a3d4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "21e9755b_a99c65b0",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 31646
},
"writtenOn": "2023-10-23T21:40:51Z",
"side": 1,
"message": "There are several places where \"keyring.set_password()\" function is called. I only wanted to make the change in the context of \"_update_keyring_password()\" to allow ldap users with \"sys_protected\" permission to do \"source /etc/platform/openrc\" and get access to system commands.",
"parentUuid": "4961509b_c4605257",
"revId": "eb557c0450684931b48b6975c80f8ce05f45a3d4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}