Update patch set 3

Patch Set 3: Workflow-1

(2 comments)

Patch-set: 3
Reviewer: Gerrit User 33594 <33594@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Workflow=-1, 8aa6346f007fc8a6fb12d801c096edf6f0c05b4a
Attention: {"person_ident":"Gerrit User 33594 \u003c33594@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_33594\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 28459 \u003c28459@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_33594\u003e replied on the change"}

0a490cffc2a762f4727432a832974e63eaa4eddd

@@ -1,5 +1,22 @@
 {
   "comments": [
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "04bb3adf_450303e5",
+        "filename": "/PATCHSET_LEVEL",
+        "patchSetId": 3
+      },
+      "lineNbr": 0,
+      "author": {
+        "id": 33594
+      },
+      "writtenOn": "2023-09-07T17:50:25Z",
+      "side": 1,
+      "message": "Holding this review until we make sure that we use the python-openstack-client packages upstream packages dependencies, rather than building ones here.",
+      "revId": "0a490cffc2a762f4727432a832974e63eaa4eddd",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
     {
       "unresolved": true,
       "key": {
@@ -34,6 +51,24 @@
       "parentUuid": "6d75b2f6_d67de8b2",
       "revId": "0a490cffc2a762f4727432a832974e63eaa4eddd",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "cec7e379_e7863d36",
+        "filename": "debian_iso_image.inc",
+        "patchSetId": 3
+      },
+      "lineNbr": 31,
+      "author": {
+        "id": 33594
+      },
+      "writtenOn": "2023-09-07T17:50:25Z",
+      "side": 1,
+      "message": "That is a very good point actually.\n\nWell, since the platform only uses a restricted set of openstack services (e.g. keystone, barbican) if the openstack client would throw runtime errors when trying to run volume/image commands, that could be good feedback for an user, right? I mean, if use needs this type of openstack services, the openstack application needs to be installed...\n\nBut looking at the python-openstackclient debian/control file [1] it is possible to verify that all openstack clients are listed under Build-Depends-Indep, so they need to be available in build time.\nAlso, the openstack-client docker image is currently installing other openstack clients using PIP [2].\n\nThe best way to go here is to have a clean build env with this change cherry-picked and ensure that we are not building those clients, but rather downloading it as build dependencies (on the required version).\n\n[1] https://salsa.debian.org/openstack-team/clients/python-openstackclient/-/blob/debian/5.4.0-4/debian/control#L18\n[2] https://opendev.org/starlingx/upstream/src/branch/master/openstack/python-openstackclient/debian/stx-openstackclient.stable_docker_image#L6",
+      "parentUuid": "663dea45_c8f66a3c",
+      "revId": "0a490cffc2a762f4727432a832974e63eaa4eddd",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
     }
   ]
 }