From ff598b27e1f4dbc9b993d9c9360fbe06e2d2ed8c Mon Sep 17 00:00:00 2001 From: Tao Liu Date: Thu, 31 Jan 2019 09:41:48 -0600 Subject: [PATCH 1/3] Configurable Host HTTP/HTTPS Port Binding change platform horizon to bind to port 8008 Story: 2004642 Task: 29265 Depends-On: https://review.openstack.org/#/c/634237/ Change-Id: Id6890c8e62d31225969e4c0bb23c78ccb66a3517 Signed-off-by: Tao Liu --- openstack/python-horizon/centos/files/horizon.init | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/openstack/python-horizon/centos/files/horizon.init b/openstack/python-horizon/centos/files/horizon.init index b0c5ad21..36f2340d 100755 --- a/openstack/python-horizon/centos/files/horizon.init +++ b/openstack/python-horizon/centos/files/horizon.init @@ -20,7 +20,7 @@ PYTHON=`which python` MANAGE="/usr/share/openstack-dashboard/manage.py" EXEC="/usr/bin/gunicorn" BIND="localhost" -PORT="8080" +PORT="8008" WORKER="eventlet" WORKERS=`grep workers /etc/openstack-dashboard/horizon-config.ini | cut -f3 -d' '` # Increased timeout to facilitate large image uploads From aac168b3984f715f06661686869e70f1b44b57c0 Mon Sep 17 00:00:00 2001 From: Irina Mihai Date: Mon, 4 Feb 2019 18:06:14 +0000 Subject: [PATCH 2/3] Glance chart: add images pool replication - pass new pool replication parameter to the storage init script - set images pool replication in the storage init script Change-Id: If0ecaeb12afd78caacdbb9b85cda8d6cfda00dea Story: 2004520 Task: 29324 Depends-on: I120e196ec3acca1f57b717cc4548c7c549fac738 Signed-off-by: Irina Mihai --- .../openstack-helm/centos/build_srpm.data | 2 +- .../openstack-helm/centos/openstack-helm.spec | 2 + ...ce-chart-add-images-pool-replication.patch | 55 +++++++++++++++++++ 3 files changed, 58 insertions(+), 1 deletion(-) create mode 100644 openstack/openstack-helm/files/0007-Glance-chart-add-images-pool-replication.patch diff --git a/openstack/openstack-helm/centos/build_srpm.data b/openstack/openstack-helm/centos/build_srpm.data index 02fffd4f..14cc7512 100644 --- a/openstack/openstack-helm/centos/build_srpm.data +++ b/openstack/openstack-helm/centos/build_srpm.data @@ -5,4 +5,4 @@ TAR="$TAR_NAME-$SHA.tar.gz" COPY_LIST="${CGCS_BASE}/downloads/$TAR $PKG_BASE/files/* " -TIS_PATCH_VER=8 +TIS_PATCH_VER=9 diff --git a/openstack/openstack-helm/centos/openstack-helm.spec b/openstack/openstack-helm/centos/openstack-helm.spec index 30ec6ae1..0f0c94d1 100644 --- a/openstack/openstack-helm/centos/openstack-helm.spec +++ b/openstack/openstack-helm/centos/openstack-helm.spec @@ -24,6 +24,7 @@ Patch03: 0003-Add-Panko-Chart.patch Patch04: Remove-stale-Apache2-service-pids-when-a-POD-starts.patch Patch05: 0005-Add-heat-purge-deleted-cron-job.patch Patch06: 0006-Enable-cold-migration-in-nova-helm-chart.patch +Patch07: 0007-Glance-chart-add-images-pool-replication.patch BuildRequires: helm BuildRequires: openstack-helm-infra @@ -40,6 +41,7 @@ Openstack Helm charts %patch04 -p1 %patch05 -p1 %patch06 -p1 +%patch07 -p1 %build # initialize helm and build the toolkit diff --git a/openstack/openstack-helm/files/0007-Glance-chart-add-images-pool-replication.patch b/openstack/openstack-helm/files/0007-Glance-chart-add-images-pool-replication.patch new file mode 100644 index 00000000..53f983ca --- /dev/null +++ b/openstack/openstack-helm/files/0007-Glance-chart-add-images-pool-replication.patch @@ -0,0 +1,55 @@ +From 5480584be125316f3ce325fd1d0e9b4022db5c69 Mon Sep 17 00:00:00 2001 +From: Irina Mihai +Date: Fri, 1 Feb 2019 16:02:46 -0500 +Subject: [PATCH] Add replication support for the images rbd pool + +--- + glance/templates/bin/_storage-init.sh.tpl | 2 ++ + glance/templates/job-storage-init.yaml | 4 ++++ + glance/values.yaml | 2 ++ + 3 files changed, 8 insertions(+) + +diff --git a/glance/templates/bin/_storage-init.sh.tpl b/glance/templates/bin/_storage-init.sh.tpl +index 4082c52..e6bd188 100755 +--- a/glance/templates/bin/_storage-init.sh.tpl ++++ b/glance/templates/bin/_storage-init.sh.tpl +@@ -47,6 +47,8 @@ elif [ "x$STORAGE_BACKEND" == "xrbd" ]; then + if [[ ${test_luminous} -gt 0 ]]; then + ceph osd pool application enable "$1" "$3" + fi ++ ceph osd pool set $1 size ${RBD_POOL_REPLICATION} ++ ceph osd pool set $1 crush_rule "${RBD_POOL_CRUSH_RULE}" + } + ensure_pool "${RBD_POOL_NAME}" "${RBD_POOL_CHUNK_SIZE}" "glance-image" + +diff --git a/glance/templates/job-storage-init.yaml b/glance/templates/job-storage-init.yaml +index 9d95627..c0cd186 100755 +--- a/glance/templates/job-storage-init.yaml ++++ b/glance/templates/job-storage-init.yaml +@@ -103,6 +103,10 @@ spec: + value: {{ .Values.conf.glance.glance_store.rbd_store_pool | quote }} + - name: RBD_POOL_USER + value: {{ .Values.conf.glance.glance_store.rbd_store_user | quote }} ++ - name: RBD_POOL_REPLICATION ++ value: {{ .Values.conf.glance.glance_store.rbd_store_replication | quote }} ++ - name: RBD_POOL_CRUSH_RULE ++ value: {{ .Values.conf.glance.glance_store.rbd_store_crush_rule | quote }} + - name: RBD_POOL_CHUNK_SIZE + value: {{ .Values.conf.glance.glance_store.rbd_store_chunk_size | quote }} + - name: RBD_POOL_SECRET +diff --git a/glance/values.yaml b/glance/values.yaml +index 5ae9863..4d482d1 100755 +--- a/glance/values.yaml ++++ b/glance/values.yaml +@@ -268,6 +268,8 @@ conf: + memcache_security_strategy: ENCRYPT + glance_store: + rbd_store_chunk_size: 8 ++ rbd_store_replication: 1 ++ rbd_store_crush_rule: replicated_rule + rbd_store_pool: glance.images + rbd_store_user: glance + rbd_store_ceph_conf: /etc/ceph/ceph.conf +-- +2.7.4 + From ab3945fcc78cc912b0db0dc0e8ecffc75cef4568 Mon Sep 17 00:00:00 2001 From: Chris Friesen Date: Wed, 6 Feb 2019 17:47:47 -0600 Subject: [PATCH 3/3] fix type error to streamline single-replica mariadb startup The mariadb startup script was trying to optimize the single-replica case but missed the fact that the variable it was checking was a string rather than an int. Converting it to an int before doing the comparison makes it work as expected. Change-Id: I0f920b52c5cc92672a71ee3db3d7f8e5700fb709 Signed-off-by: Chris Friesen Story: 2004712 Task: 29385 --- .../centos/openstack-helm-infra.spec | 2 ++ ...o-streamline-single-replica-mariadb-.patch | 34 +++++++++++++++++++ 2 files changed, 36 insertions(+) create mode 100644 openstack/openstack-helm-infra/files/fix-type-error-to-streamline-single-replica-mariadb-.patch diff --git a/openstack/openstack-helm-infra/centos/openstack-helm-infra.spec b/openstack/openstack-helm-infra/centos/openstack-helm-infra.spec index 96ca1c66..66e2aab0 100644 --- a/openstack/openstack-helm-infra/centos/openstack-helm-infra.spec +++ b/openstack/openstack-helm-infra/centos/openstack-helm-infra.spec @@ -19,6 +19,7 @@ Patch01: 0001-gnocchi-chart-updates.patch Patch02: Mariadb-Support-adoption-of-running-single-node-mari.patch Patch03: Mariadb-Share-container-PID-namespaces-under-docker.patch Patch04: 0004-Allow-multiple-containers-per-daemonset-pod.patch +Patch05: fix-type-error-to-streamline-single-replica-mariadb-.patch BuildRequires: helm @@ -31,6 +32,7 @@ Openstack Helm Infra charts %patch02 -p1 %patch03 -p1 %patch04 -p1 +%patch05 -p1 %build # initialize helm and build the toolkit diff --git a/openstack/openstack-helm-infra/files/fix-type-error-to-streamline-single-replica-mariadb-.patch b/openstack/openstack-helm-infra/files/fix-type-error-to-streamline-single-replica-mariadb-.patch new file mode 100644 index 00000000..c12ac9f7 --- /dev/null +++ b/openstack/openstack-helm-infra/files/fix-type-error-to-streamline-single-replica-mariadb-.patch @@ -0,0 +1,34 @@ +From d983c89dbce840fad50f49e4253ecc7930f15338 Mon Sep 17 00:00:00 2001 +From: Chris Friesen +Date: Wed, 6 Feb 2019 17:19:39 -0600 +Subject: [PATCH] fix type error to streamline single-replica mariadb startup + +The mariadb startup script was trying to optimize the single-replica +case but missed the fact that the variable it was checking was a +string rather than an int. + +Converting it to an int before doing the comparison makes it work +as expected. + +Change-Id: I8612e9e8ef5ec8ff61ecf0782f262a5feafd501a +Signed-off-by: Chris Friesen +--- + mariadb/templates/bin/_start.py.tpl | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/mariadb/templates/bin/_start.py.tpl b/mariadb/templates/bin/_start.py.tpl +index 4d4428c..d0b9c8e 100644 +--- a/mariadb/templates/bin/_start.py.tpl ++++ b/mariadb/templates/bin/_start.py.tpl +@@ -729,7 +729,7 @@ elif get_cluster_state() == 'init': + run_mysqld() + elif get_cluster_state() == 'live': + logger.info("Cluster has been running starting restore/rejoin") +- if not mariadb_replicas > 1: ++ if not int(mariadb_replicas) > 1: + logger.info( + "There is only a single node in this cluster, we are good to go") + update_grastate_on_restart() +-- +1.8.3.1 +