Update patch set 5
Patch Set 5:
(5 comments)
Patch-set: 5
Attention: {"person_ident":"Gerrit User 35148 \u003c35148@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_35741\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 35741 \u003c35741@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_35741\u003e replied on the change"}
This commit is contained in:
Gerrit User 35741
Gerrit Code Review
parent
5ec4ba1acc
commit
468dba0839
|
|
@ -64,6 +64,24 @@
|
|||
"revId": "49fdf59bdb2f4aa8d9dcdd5c1070b1155561fd40",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "0a0ecc44_4cac967c",
|
||||
"filename": "/COMMIT_MSG",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 42,
|
||||
"author": {
|
||||
"id": 35741
|
||||
},
|
||||
"writtenOn": "2024-05-09T15:00:02Z",
|
||||
"side": 1,
|
||||
"message": "I don\u0027t think we should limit it just to platform cores . Aren\u0027t we giving the customer the ability to tune these workers so that they can install tons and tons of subclouds ?",
|
||||
"parentUuid": "6d42533e_6a753c6f",
|
||||
"revId": "49fdf59bdb2f4aa8d9dcdd5c1070b1155561fd40",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -122,6 +140,30 @@
|
|||
"revId": "49fdf59bdb2f4aa8d9dcdd5c1070b1155561fd40",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "18c00e8e_7bad462d",
|
||||
"filename": "sysinv/cgts-client/cgts-client/cgtsclient/tests/v1/test_service_parameter_shell.py",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 15,
|
||||
"author": {
|
||||
"id": 35741
|
||||
},
|
||||
"writtenOn": "2024-05-09T15:00:02Z",
|
||||
"side": 1,
|
||||
"message": "Validation seems to be happening either at the cgts-client or at the sysinv_api v1 handlers. The actual service_parameter_shell.py isn\u0027t doing much validation on input",
|
||||
"parentUuid": "02f91f19_7e2bb5dd",
|
||||
"range": {
|
||||
"startLine": 15,
|
||||
"startChar": 0,
|
||||
"endLine": 15,
|
||||
"endChar": 24
|
||||
},
|
||||
"revId": "49fdf59bdb2f4aa8d9dcdd5c1070b1155561fd40",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -139,6 +181,24 @@
|
|||
"revId": "49fdf59bdb2f4aa8d9dcdd5c1070b1155561fd40",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "a9bbb6f6_1c63fff4",
|
||||
"filename": "sysinv/sysinv/sysinv/sysinv/common/service_parameter.py",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 613,
|
||||
"author": {
|
||||
"id": 35741
|
||||
},
|
||||
"writtenOn": "2024-05-09T15:00:02Z",
|
||||
"side": 1,
|
||||
"message": "same comment as above . I think we should allow up to all physical cores not just platform cores",
|
||||
"parentUuid": "b6c3c22e_14329500",
|
||||
"revId": "49fdf59bdb2f4aa8d9dcdd5c1070b1155561fd40",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -210,6 +270,30 @@
|
|||
"revId": "49fdf59bdb2f4aa8d9dcdd5c1070b1155561fd40",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "e714729f_5466cef7",
|
||||
"filename": "sysinv/sysinv/sysinv/sysinv/common/service_parameter.py",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 614,
|
||||
"author": {
|
||||
"id": 35741
|
||||
},
|
||||
"writtenOn": "2024-05-09T15:00:02Z",
|
||||
"side": 1,
|
||||
"message": "Acknowledged",
|
||||
"parentUuid": "0a9943ce_21bd0fd4",
|
||||
"range": {
|
||||
"startLine": 614,
|
||||
"startChar": 4,
|
||||
"endLine": 614,
|
||||
"endChar": 19
|
||||
},
|
||||
"revId": "49fdf59bdb2f4aa8d9dcdd5c1070b1155561fd40",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -226,6 +310,24 @@
|
|||
"message": "this should accept the minimum value from each controller rather than adding all controllers.\nand should be based on only cpus with PLATFORM_FUNCTION (since on AIO, not all cpus are PLATFORM_FUNCTION )",
|
||||
"revId": "49fdf59bdb2f4aa8d9dcdd5c1070b1155561fd40",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "db1c587c_73a3796a",
|
||||
"filename": "sysinv/sysinv/sysinv/sysinv/common/utils.py",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 1034,
|
||||
"author": {
|
||||
"id": 35741
|
||||
},
|
||||
"writtenOn": "2024-05-09T15:00:02Z",
|
||||
"side": 1,
|
||||
"message": "same comment as above . I think we should allow up to all physical cores not just platform cores",
|
||||
"parentUuid": "f34da433_8b7c3721",
|
||||
"revId": "49fdf59bdb2f4aa8d9dcdd5c1070b1155561fd40",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
Reference in New Issue