starlingx
/
config
Code Issues Proposed changes

Update patch set 3 

Patch Set 3: Code-Review+1

(2 comments)

Patch-set: 3
Reviewer: Gerrit User 36411 <36411@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+1, 1acdaaeb7e527555e4392d670ed6645bf7cd0505
This commit is contained in:
Gerrit User 36411 2024-05-03 14:14:09 +00:00 committed by Gerrit Code Review
parent d509dd5341
commit fd7737bed8
1 changed files with 34 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
ebeadb53662f087a356d8eb057ec79b96fc6a9a8
View File

@ -1,5 +1,39 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "65c3d03a_78adc938",
"filename": "sysinv/sysinv/sysinv/sysinv/common/utils.py",
"patchSetId": 3
},
"lineNbr": 3779,
"author": {
"id": 36411
},
"writtenOn": "2024-05-03T14:14:09Z",
"side": 1,
"message": "what about LOG.err ?",
"revId": "ebeadb53662f087a356d8eb057ec79b96fc6a9a8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "a2e2bd63_c0b31aac",
"filename": "sysinv/sysinv/sysinv/sysinv/common/utils.py",
"patchSetId": 3
},
"lineNbr": 3798,
"author": {
"id": 36411
},
"writtenOn": "2024-05-03T14:14:09Z",
"side": 1,
"message": "nit: LOG.debug We don\u0027t expect secondary to be there all time.",
"revId": "ebeadb53662f087a356d8eb057ec79b96fc6a9a8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {