starlingx
/
nfv
Code Issues Proposed changes

Update patch set 3 

Patch Set 3:

(9 comments)

Patch-set: 3
Attention: {"person_ident":"Gerrit User 35148 \u003c35148@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_35748\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 35748 \u003c35748@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_35748\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 9926 \u003c9926@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_35748\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 28464 \u003c28464@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_35748\u003e replied on the change"}
This commit is contained in:
Gerrit User 35748 2024-04-25 14:00:05 +00:00 committed by Gerrit Code Review
parent 69c0172d9a
commit be7559dd51
2 changed files with 204 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
6142d9f11642113cb641d5683e02478c1a011941
View File

@ -22,6 +22,30 @@
},
"revId": "6142d9f11642113cb641d5683e02478c1a011941",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "413d5f62_90da8c97",
"filename": "nfv/nfv-plugins/nfv_plugins/nfvi_plugins/nfvi_infrastructure_api.py",
"patchSetId": 2
},
"lineNbr": 2308,
"author": {
"id": 35748
},
"writtenOn": "2024-04-25T14:00:05Z",
"side": 0,
"message": "testing by updating the object with needed error info.",
"parentUuid": "9852de52_d82a0bb9",
"range": {
"startLine": 2305,
"startChar": 12,
"endLine": 2308,
"endChar": 21
},
"revId": "6142d9f11642113cb641d5683e02478c1a011941",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

180
748c9090fe85301cc32cf25d7830eddc8b15b7aa
View File

@ -40,6 +40,48 @@
"revId": "748c9090fe85301cc32cf25d7830eddc8b15b7aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "0ee300a8_c8e9926d",
"filename": "nfv/nfv-common/nfv_common/tasks/_task_future.py",
"patchSetId": 2
},
"lineNbr": 60,
"author": {
"id": 35748
},
"writtenOn": "2024-04-25T14:00:05Z",
"side": 1,
"message": "changing in config.ini takes effect on the usm plugin timeout, but the thread that\nruns the task ends if the timeout is not changed here.",
"parentUuid": "ae30fb76_dcfb3e5b",
"range": {
"startLine": 60,
"startChar": 0,
"endLine": 60,
"endChar": 33
},
"revId": "748c9090fe85301cc32cf25d7830eddc8b15b7aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "832f860a_3a886903",
"filename": "nfv/nfv-common/nfv_common/tasks/_task_future.py",
"patchSetId": 2
},
"lineNbr": 60,
"author": {
"id": 35748
},
"writtenOn": "2024-04-25T14:00:05Z",
"side": 1,
"message": "Acknowledged",
"parentUuid": "e8ead83e_48e88f08",
"revId": "748c9090fe85301cc32cf25d7830eddc8b15b7aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -63,6 +105,30 @@
"revId": "748c9090fe85301cc32cf25d7830eddc8b15b7aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "c3a9b272_3b877003",
"filename": "nfv/nfv-plugins/nfv_plugins/nfvi_plugins/nfvi_infrastructure_api.py",
"patchSetId": 2
},
"lineNbr": 2363,
"author": {
"id": 35748
},
"writtenOn": "2024-04-25T14:00:05Z",
"side": 1,
"message": "added todo comment.\nobject update is not done here, as the api will be changed to asynch call.\nthe object update could be done as part of api \u0027deploy show\u0027 to check on the state and release data in event handling and callback function of start.",
"parentUuid": "d02d76ab_8362a14f",
"range": {
"startLine": 2354,
"startChar": 1,
"endLine": 2363,
"endChar": 54
},
"revId": "748c9090fe85301cc32cf25d7830eddc8b15b7aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -86,6 +152,30 @@
"revId": "748c9090fe85301cc32cf25d7830eddc8b15b7aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "c7c78a3a_dfcbf2ec",
"filename": "nfv/nfv-plugins/nfv_plugins/nfvi_plugins/openstack/rest_api.py",
"patchSetId": 2
},
"lineNbr": 476,
"author": {
"id": 35748
},
"writtenOn": "2024-04-25T14:00:05Z",
"side": 1,
"message": "Tested k8s upgrade with this change, seems to work fine.\nI guess the timeout in each plugin call is replacing the value 600.\nIn such case the same should be the behavior of sw-deploy-strategy.\ntodo: test sw-deploy-strategy with only change in usm timeout.\n\nStrategy Kubernetes Upgrade Strategy:\n strategy-uuid: 2a85655e-62cd-40c0-b67e-9df79c68418a\n controller-apply-type: serial\n storage-apply-type: serial\n worker-apply-type: serial\n default-instance-action: stop-start\n alarm-restrictions: strict\n current-phase: apply\n current-phase-completion: 100%\n state: applied",
"parentUuid": "303ad34c_303cf887",
"range": {
"startLine": 476,
"startChar": 21,
"endLine": 476,
"endChar": 41
},
"revId": "748c9090fe85301cc32cf25d7830eddc8b15b7aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -133,6 +223,30 @@
"revId": "748c9090fe85301cc32cf25d7830eddc8b15b7aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "e5c76e02_3bcac169",
"filename": "nfv/nfv-plugins/nfv_plugins/nfvi_plugins/openstack/usm.py",
"patchSetId": 2
},
"lineNbr": 91,
"author": {
"id": 35748
},
"writtenOn": "2024-04-25T14:00:05Z",
"side": 1,
"message": "To adapt the precheck api call to exclude region name once the software-api changes are available.",
"parentUuid": "77e931bc_34b9c7e5",
"range": {
"startLine": 91,
"startChar": 44,
"endLine": 91,
"endChar": 67
},
"revId": "748c9090fe85301cc32cf25d7830eddc8b15b7aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -156,6 +270,30 @@
"revId": "748c9090fe85301cc32cf25d7830eddc8b15b7aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "79578374_c3121653",
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy.py",
"patchSetId": 2
},
"lineNbr": 1840,
"author": {
"id": 35748
},
"writtenOn": "2024-04-25T14:00:05Z",
"side": 1,
"message": "checking the response of the result-data to determine success / failure?",
"parentUuid": "7b349a35_b80dd2f7",
"range": {
"startLine": 1809,
"startChar": 1,
"endLine": 1840,
"endChar": 0
},
"revId": "748c9090fe85301cc32cf25d7830eddc8b15b7aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -173,6 +311,24 @@
"revId": "748c9090fe85301cc32cf25d7830eddc8b15b7aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "9fe5aab7_6ec41609",
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy.py",
"patchSetId": 2
},
"lineNbr": 1858,
"author": {
"id": 35748
},
"writtenOn": "2024-04-25T14:00:05Z",
"side": 1,
"message": "Agreed.\nQueryUpgradeStep corresponds to \u0027software list\u0027 api?\nif yes, then QueryUpgrade to be done before precheck, as we need the data to validate the \u0027input\u0027 release passed by the user and its state.",
"parentUuid": "19fba6e7_2f72a3ba",
"revId": "748c9090fe85301cc32cf25d7830eddc8b15b7aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -195,6 +351,30 @@
},
"revId": "748c9090fe85301cc32cf25d7830eddc8b15b7aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "0453fa4e_0008c53a",
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy_steps.py",
"patchSetId": 2
},
"lineNbr": 1122,
"author": {
"id": 35748
},
"writtenOn": "2024-04-25T14:00:05Z",
"side": 1,
"message": "response[\u0027result-data\u0027] is assigned with release_info data in nfvi_infrastructure_api Line #2365",
"parentUuid": "83d210f1_cddc0df1",
"range": {
"startLine": 1122,
"startChar": 60,
"endLine": 1122,
"endChar": 92
},
"revId": "748c9090fe85301cc32cf25d7830eddc8b15b7aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}