starlingx
/
specs
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(4 comments)

Patch-set: 1
Attention: {"person_ident":"Gerrit User 26026 \u003c26026@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_32832\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 32832 \u003c32832@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_32832\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 33377 \u003c33377@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_32832\u003e replied on the change"}
This commit is contained in:
Gerrit User 32832 2024-01-05 09:26:37 +00:00 committed by Gerrit Code Review
parent 7fdbd464d3
commit 14d60f2502
1 changed files with 84 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

84
b612622ae079e4d93c1ba3bbb1557909338844b1
View File

@ -34,6 +34,42 @@
"revId": "b612622ae079e4d93c1ba3bbb1557909338844b1",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "385030a9_0506c239",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 32832
},
"writtenOn": "2024-01-05T09:26:37Z",
"side": 1,
"message": "Thanks for the review in details and wait for more of your suggestions.\nI reply some of them and agree with the others. I will change in the next push.",
"parentUuid": "2fcb778c_8cbb409f",
"revId": "b612622ae079e4d93c1ba3bbb1557909338844b1",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "12982e54_7dff9178",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 32832
},
"writtenOn": "2024-01-05T09:26:37Z",
"side": 1,
"message": "Thanks. I will move it to stx-10 in next push.",
"parentUuid": "5b49a1f7_7ca58523",
"revId": "b612622ae079e4d93c1ba3bbb1557909338844b1",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -74,6 +110,30 @@
"revId": "b612622ae079e4d93c1ba3bbb1557909338844b1",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "d8dcf8cf_05686924",
"filename": "doc/source/specs/stx-9.0/approved/kernel-2011000-uprevision-to-6.6.rst",
"patchSetId": 1
},
"lineNbr": 19,
"author": {
"id": 32832
},
"writtenOn": "2024-01-05T09:26:37Z",
"side": 1,
"message": "For the 1st reason list, maybe we can pick something from the link you gave. Welcome suggestions.\nFor the 2nd reason list, my worry is if the hardware vendor such as intel has kept the newest and most stable driver in linux mainline? If we move the oot driver to in tree driver, I hope we won\u0027t need move them oot again one day.",
"parentUuid": "47e40917_81144f6c",
"range": {
"startLine": 18,
"startChar": 0,
"endLine": 19,
"endChar": 2
},
"revId": "b612622ae079e4d93c1ba3bbb1557909338844b1",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -159,6 +219,30 @@
},
"revId": "b612622ae079e4d93c1ba3bbb1557909338844b1",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "97f8f30c_8abdd472",
"filename": "doc/source/specs/stx-9.0/approved/kernel-2011000-uprevision-to-6.6.rst",
"patchSetId": 1
},
"lineNbr": 51,
"author": {
"id": 32832
},
"writtenOn": "2024-01-05T09:26:37Z",
"side": 1,
"message": "Yes. What I care for is that if we should at least keep some complicate drivers as oot modules, e.g. mlnx-ofa_kernel / intel-opae-fpga .",
"parentUuid": "ed7b78e0_71d96698",
"range": {
"startLine": 49,
"startChar": 39,
"endLine": 51,
"endChar": 29
},
"revId": "b612622ae079e4d93c1ba3bbb1557909338844b1",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}