starlingx
/
specs
Code Issues Proposed changes

Update patch set 10 

Patch Set 10:

(11 comments)

Patch-set: 10
Attention: {"person_ident":"Gerrit User 33394 \u003c33394@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_29042\u003e replied on the change"}
This commit is contained in:
Gerrit User 29042 2023-10-07 08:37:11 +00:00 committed by Gerrit Code Review
parent 2ebd63c25c
commit 9ff69b1d3a
1 changed files with 198 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

198
f595f62e7c3bc541ba7d1e3a7079543df2686a69
View File

@ -34,6 +34,24 @@
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "b8362a36_0dee54d2",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
"patchSetId": 10
},
"lineNbr": 9,
"author": {
"id": 29042
},
"writtenOn": "2023-10-07T08:37:11Z",
"side": 1,
"message": "The link definition is in line 330:\n\n.. _#2010739: https://storyboard.openstack.org/#!/story/2010739",
"parentUuid": "30a66264_dff51620",
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -51,6 +69,24 @@
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "46d4afd8_af649342",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
"patchSetId": 10
},
"lineNbr": 35,
"author": {
"id": 29042
},
"writtenOn": "2023-10-07T08:37:11Z",
"side": 1,
"message": "Ack",
"parentUuid": "e092d352_45409972",
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -68,6 +104,24 @@
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "36cb53bd_3d4b1092",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
"patchSetId": 10
},
"lineNbr": 41,
"author": {
"id": 29042
},
"writtenOn": "2023-10-07T08:37:11Z",
"side": 1,
"message": "Ack",
"parentUuid": "ae494d99_753d9088",
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -85,6 +139,24 @@
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "ded8256a_4e32b429",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
"patchSetId": 10
},
"lineNbr": 42,
"author": {
"id": 29042
},
"writtenOn": "2023-10-07T08:37:11Z",
"side": 1,
"message": "For the package lists, patches and configs, there are details in the \"Work Items\", so I will change like this:\n\nThe proposed change here is to extend the support to Arm64 architecture, which\nwill modify the StarlingX Debian build system to add support native builds on\nArm64 servers, modify the package lists, container images, package meta data, \nbootstrap sctips and so on to also hanle for Arm architecture, and the produced\nruntime will be validated using Ampere Altra Processor based servers.\n\nThe change will also include adding documentations of the support for Arm64\narchitecture.",
"parentUuid": "08290855_746f1726",
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -102,6 +174,24 @@
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "678ee590_f13c1c05",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
"patchSetId": 10
},
"lineNbr": 63,
"author": {
"id": 29042
},
"writtenOn": "2023-10-07T08:37:11Z",
"side": 1,
"message": "I\u0027m not familiar with secure boot, and AFAIK the patches for x86 secure boot cannot be ported to Arm, which needs extra work to investigate and re-implement for Arm.\n\nI would like to separate it out to next phase or another Story/Spec to handle, which may need the developers from Arm team to contribute, so I will change this line to:\nSecure boot support will be disabled on Arm and need extra work to investigate\nand re-implement for Arm platform. \n\nAnd I will also add a work item for this:\n\nSecure boot support\n^^^^^^^^^^^^^^^^^^^\n\n* The secure boot support will be disabled in this implementation on Arm64.\n* Extra work is needed to investigate and re-implement the support for secure\n boot on Arm64 architecture (in another Story/Spec).",
"parentUuid": "b5aa50a6_67f75eed",
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -119,6 +209,24 @@
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "069df477_ccb69b05",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
"patchSetId": 10
},
"lineNbr": 68,
"author": {
"id": 29042
},
"writtenOn": "2023-10-07T08:37:11Z",
"side": 1,
"message": "Thanks for reminding, I will change this to:\n* For x86_64 end user: None\n* For Arm64 end user: there will be docs for Arm64 for these new users",
"parentUuid": "3f3d1668_72751f96",
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -136,6 +244,24 @@
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "3e68567c_ee1cbdd3",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
"patchSetId": 10
},
"lineNbr": 73,
"author": {
"id": 29042
},
"writtenOn": "2023-10-07T08:37:11Z",
"side": 1,
"message": "* For x86_64: None\n* For Arm64: the performance is not likely to be the same as on x86_64.",
"parentUuid": "11308fe6_2fb29ce6",
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -153,6 +279,24 @@
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "3e56979a_9bfb4499",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
"patchSetId": 10
},
"lineNbr": 78,
"author": {
"id": 29042
},
"writtenOn": "2023-10-07T08:37:11Z",
"side": 1,
"message": "Yes, the doc will be changed and the deployer need to choose between the two arches.",
"parentUuid": "73c47d4a_75bfe64b",
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -170,6 +314,24 @@
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "8a0d75ba_9be28308",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
"patchSetId": 10
},
"lineNbr": 85,
"author": {
"id": 29042
},
"writtenOn": "2023-10-07T08:37:11Z",
"side": 1,
"message": "Yes, the details are listed in the work items and doc (developer guide) will be updated with all the impact.\n\nI will change the statement like this:\nThe documentation for developers (developer guide) will be updated with detail\nitems of the impact, e.g. \n\n* Avoid hardcoded arch names like \u0027x86-64\u0027 or \u0027amd64\u0027 in the source codes.\n* Consider if there are any different patches or behavior for x86 and Arm.\n* Different package lists for x86 and Arm.\n* Different container image for x86 and Arm.",
"parentUuid": "43bb49fb_6efcf4c5",
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -222,6 +384,24 @@
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "2ede5aa5_5c970432",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
"patchSetId": 10
},
"lineNbr": 191,
"author": {
"id": 29042
},
"writtenOn": "2023-10-07T08:37:11Z",
"side": 1,
"message": "Ack",
"parentUuid": "ce861c40_c3ae00d4",
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -239,6 +419,24 @@
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "4a1998b5_aba9af64",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
"patchSetId": 10
},
"lineNbr": 250,
"author": {
"id": 29042
},
"writtenOn": "2023-10-07T08:37:11Z",
"side": 1,
"message": "No impact to the repo, the deb files for x86_64 and Arm are the same ones, no extra deb files will be added, all the logic to handle different arch is inside the file \"control\" and \"rules\".",
"parentUuid": "c110ced5_cdd8f92e",
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {