Update patch set 7

Patch Set 7: Code-Review-1

(4 comments)

Patch-set: 7
Reviewer: Gerrit User 28652 <28652@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, ebf29c36833d015fdaf10ab74cc3e500c7b468ff
Attention: {"person_ident":"Gerrit User 28652 \u003c28652@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_28652\u003e replied on the change"}
This commit is contained in:
Gerrit User 28652 2023-04-17 18:11:15 +00:00 committed by Gerrit Code Review
parent af5662a53b
commit ff5f0cc546
1 changed files with 68 additions and 0 deletions

View File

@ -1,5 +1,73 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "2763b169_0d64277d",
"filename": "/COMMIT_MSG",
"patchSetId": 7
},
"lineNbr": 8,
"author": {
"id": 28652
},
"writtenOn": "2023-04-17T18:11:15Z",
"side": 1,
"message": "According to the Technical Steering Commitee, STX commits require Story/Task or Closes-Bug or Partial-Bug tags. Also needs a verification section. See other commits via git log to get an idea of what is required. Yeah, I know, some repo owners have been lax at enforcement, and I\u0027m not an owner of this repo.",
"revId": "c2433c94003bf0991b027c449ffeb4079a901e8a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "2b9ac6ee_c0fe56b1",
"filename": "/COMMIT_MSG",
"patchSetId": 7
},
"lineNbr": 9,
"author": {
"id": 28652
},
"writtenOn": "2023-04-17T18:11:15Z",
"side": 1,
"message": "Requires \"Firstname Lastname\" ahead of your email address, like in the Author and Commit fields. Did you forget to set your user.name git config variable? You need to do it every time you enter the build container.",
"revId": "c2433c94003bf0991b027c449ffeb4079a901e8a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "77f0d9c4_427df189",
"filename": "doc/source/specs/stx-9.0/approved/IEO_Starlingx_Spec_submission.rst",
"patchSetId": 7
},
"lineNbr": 3,
"author": {
"id": 28652
},
"writtenOn": "2023-04-17T18:11:15Z",
"side": 1,
"message": "The pink blocks in this file are signs of whitespace errors, such as cruft eg. ^M that might be left behind by microsoft editors. Or spaces at ends of lines. Please clean up all of that.\n\nAlso run this file through a spell checker. Eg. https://www.linux.com/training-tutorials/using-spell-checking-vim/",
"revId": "c2433c94003bf0991b027c449ffeb4079a901e8a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "38a276f2_e0dc9aaa",
"filename": "doc/source/specs/stx-9.0/approved/IEO_Starlingx_Spec_submission.rst",
"patchSetId": 7
},
"lineNbr": 218,
"author": {
"id": 28652
},
"writtenOn": "2023-04-17T18:11:15Z",
"side": 1,
"message": "It might be cleaner if you didn\u0027t have linewrap in this file. You seem to be avoiding it up to here but from about line 263 on down there is a lot of it. Long URLs which can\u0027t fit on a line by themselves would be fine to wrap though.",
"revId": "c2433c94003bf0991b027c449ffeb4079a901e8a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {