starlingx
/
update
Code Issues Proposed changes

Fix print issue for Python 2/3 compatible code. 

Use flake8 to replace pep8 because pep8 is invalid from the log.
enable pep8/flake8 voting and suppress flake8 Errors(fix later)

Story: 2003429
Task: 24623

Change-Id: I79e9def77dc0c8ce74403d4ba846b35ae5aa487b
Signed-off-by: chenyan <yan.chen@intel.com>
Signed-off-by: Sun Austin <austin.sun@intel.com>
This commit is contained in:
chenyan 2018-08-30 16:04:17 +08:00 committed by Sun Austin
parent 3bc6628096
commit ad22ae3db1
7 changed files with 425 additions and 407 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

362
cgcs-patch/cgcs-patch/cgcs_make_patch/make_patch_functions.py
View File

File diff suppressed because it is too large Load Diff

20
cgcs-patch/cgcs-patch/cgcs_patch/patch_agent.py
View File

@ -765,7 +765,7 @@ class PatchAgent(PatchService):
# Build up the install set # Build up the install set
if verbose_to_stdout: if verbose_to_stdout:
print "Checking for software updates..." print("Checking for software updates...")
self.query() self.query()
install_set = [] install_set = []
for pkg, version in self.to_install.iteritems(): for pkg, version in self.to_install.iteritems():
@ -779,23 +779,23 @@ class PatchAgent(PatchService):
if len(install_set) > 0: if len(install_set) > 0:
try: try:
if verbose_to_stdout: if verbose_to_stdout:
print "Installing software updates..." print("Installing software updates...")
LOG.info("Installing: %s" % ", ".join(install_set)) LOG.info("Installing: %s" % ", ".join(install_set))
output = subprocess.check_output(smart_install_cmd + install_set, stderr=subprocess.STDOUT) output = subprocess.check_output(smart_install_cmd + install_set, stderr=subprocess.STDOUT)
changed = True changed = True
for line in output.split('\n'): for line in output.split('\n'):
LOG.info("INSTALL: %s" % line) LOG.info("INSTALL: %s" % line)
if verbose_to_stdout: if verbose_to_stdout:
print "Software updated." print("Software updated.")
except subprocess.CalledProcessError as e: except subprocess.CalledProcessError as e:
LOG.exception("Failed to install RPMs") LOG.exception("Failed to install RPMs")
LOG.error("Command output: %s" % e.output) LOG.error("Command output: %s" % e.output)
rc = False rc = False
if verbose_to_stdout: if verbose_to_stdout:
print "WARNING: Software update failed." print("WARNING: Software update failed.")
else: else:
if verbose_to_stdout: if verbose_to_stdout:
print "Nothing to install." print("Nothing to install.")
LOG.info("Nothing to install") LOG.info("Nothing to install")
if rc: if rc:
@ -805,23 +805,23 @@ class PatchAgent(PatchService):
if len(remove_set) > 0: if len(remove_set) > 0:
try: try:
if verbose_to_stdout: if verbose_to_stdout:
print "Handling patch removal..." print("Handling patch removal...")
LOG.info("Removing: %s" % ", ".join(remove_set)) LOG.info("Removing: %s" % ", ".join(remove_set))
output = subprocess.check_output(smart_remove_cmd + remove_set, stderr=subprocess.STDOUT) output = subprocess.check_output(smart_remove_cmd + remove_set, stderr=subprocess.STDOUT)
changed = True changed = True
for line in output.split('\n'): for line in output.split('\n'):
LOG.info("REMOVE: %s" % line) LOG.info("REMOVE: %s" % line)
if verbose_to_stdout: if verbose_to_stdout:
print "Patch removal complete." print("Patch removal complete.")
except subprocess.CalledProcessError as e: except subprocess.CalledProcessError as e:
LOG.exception("Failed to remove RPMs") LOG.exception("Failed to remove RPMs")
LOG.error("Command output: %s" % e.output) LOG.error("Command output: %s" % e.output)
rc = False rc = False
if verbose_to_stdout: if verbose_to_stdout:
print "WARNING: Patch removal failed." print("WARNING: Patch removal failed.")
else: else:
if verbose_to_stdout: if verbose_to_stdout:
print "Nothing to remove." print("Nothing to remove.")
LOG.info("Nothing to remove") LOG.info("Nothing to remove")
if changed: if changed:
@ -830,7 +830,7 @@ class PatchAgent(PatchService):
self.node_is_patched = True self.node_is_patched = True
if verbose_to_stdout: if verbose_to_stdout:
print "This node has been patched." print("This node has been patched.")
if os.path.exists(node_is_patched_rr_file): if os.path.exists(node_is_patched_rr_file):
LOG.info("Reboot is required. Skipping patch-scripts") LOG.info("Reboot is required. Skipping patch-scripts")

356
cgcs-patch/cgcs-patch/cgcs_patch/patch_client.py
View File

@ -4,7 +4,7 @@ Copyright (c) 2014-2017 Wind River Systems, Inc.
SPDX-License-Identifier: Apache-2.0 SPDX-License-Identifier: Apache-2.0
""" """
from __future__ import print_function
import requests import requests
import json import json
import os import os
@ -78,65 +78,65 @@ def set_term_width():
def print_help(): def print_help():
print "usage: sw-patch [--debug]" print("usage: sw-patch [--debug]")
print " <subcommand> ..." print(" <subcommand> ...")
print "" print("")
print "Subcomands:" print("Subcomands:")
print "" print("")
print textwrap.fill(" {0:<15} ".format("upload:") + help_upload, print(textwrap.fill(" {0:<15} ".format("upload:") + help_upload,
width=TERM_WIDTH, subsequent_indent=' ' * 20) width=TERM_WIDTH, subsequent_indent=' ' * 20))
print "" print("")
print textwrap.fill(" {0:<15} ".format("upload-dir:") + help_upload_dir, print(textwrap.fill(" {0:<15} ".format("upload-dir:") + help_upload_dir,
width=TERM_WIDTH, subsequent_indent=' ' * 20) width=TERM_WIDTH, subsequent_indent=' ' * 20))
print "" print("")
print textwrap.fill(" {0:<15} ".format("apply:") + help_apply, print(textwrap.fill(" {0:<15} ".format("apply:") + help_apply,
width=TERM_WIDTH, subsequent_indent=' ' * 20) width=TERM_WIDTH, subsequent_indent=' ' * 20))
print textwrap.fill(help_patch_args, print(textwrap.fill(help_patch_args,
width=TERM_WIDTH, initial_indent=' ' * 20, subsequent_indent=' ' * 20) width=TERM_WIDTH, initial_indent=' ' * 20, subsequent_indent=' ' * 20))
print "" print("")
print textwrap.fill(" {0:<15} ".format("remove:") + help_remove, print(textwrap.fill(" {0:<15} ".format("remove:") + help_remove,
width=TERM_WIDTH, subsequent_indent=' ' * 20) width=TERM_WIDTH, subsequent_indent=' ' * 20))
print textwrap.fill(help_patch_args, print(textwrap.fill(help_patch_args,
width=TERM_WIDTH, initial_indent=' ' * 20, subsequent_indent=' ' * 20) width=TERM_WIDTH, initial_indent=' ' * 20, subsequent_indent=' ' * 20))
print "" print("")
print textwrap.fill(" {0:<15} ".format("delete:") + help_delete, print(textwrap.fill(" {0:<15} ".format("delete:") + help_delete,
width=TERM_WIDTH, subsequent_indent=' ' * 20) width=TERM_WIDTH, subsequent_indent=' ' * 20))
print textwrap.fill(help_patch_args, print(textwrap.fill(help_patch_args,
width=TERM_WIDTH, initial_indent=' ' * 20, subsequent_indent=' ' * 20) width=TERM_WIDTH, initial_indent=' ' * 20, subsequent_indent=' ' * 20))
print "" print("")
print textwrap.fill(" {0:<15} ".format("query:") + help_query, print(textwrap.fill(" {0:<15} ".format("query:") + help_query,
width=TERM_WIDTH, subsequent_indent=' ' * 20) width=TERM_WIDTH, subsequent_indent=' ' * 20))
print "" print("")
print textwrap.fill(" {0:<15} ".format("show:") + help_show, print(textwrap.fill(" {0:<15} ".format("show:") + help_show,
width=TERM_WIDTH, subsequent_indent=' ' * 20) width=TERM_WIDTH, subsequent_indent=' ' * 20))
print "" print("")
print textwrap.fill(" {0:<15} ".format("what-requires:") + help_what_requires, print(textwrap.fill(" {0:<15} ".format("what-requires:") + help_what_requires,
width=TERM_WIDTH, subsequent_indent=' ' * 20) width=TERM_WIDTH, subsequent_indent=' ' * 20))
print "" print("")
print textwrap.fill(" {0:<15} ".format("query-hosts:") + help_query_hosts, print(textwrap.fill(" {0:<15} ".format("query-hosts:") + help_query_hosts,
width=TERM_WIDTH, subsequent_indent=' ' * 20) width=TERM_WIDTH, subsequent_indent=' ' * 20))
print "" print("")
print textwrap.fill(" {0:<15} ".format("host-install:") + help_host_install, print(textwrap.fill(" {0:<15} ".format("host-install:") + help_host_install,
width=TERM_WIDTH, subsequent_indent=' ' * 20) width=TERM_WIDTH, subsequent_indent=' ' * 20))
print "" print("")
print textwrap.fill(" {0:<15} ".format("host-install-async:") + help_host_install_async, print(textwrap.fill(" {0:<15} ".format("host-install-async:") + help_host_install_async,
width=TERM_WIDTH, subsequent_indent=' ' * 20) width=TERM_WIDTH, subsequent_indent=' ' * 20))
print "" print("")
print textwrap.fill(" {0:<15} ".format("install-local:") + help_install_local, print(textwrap.fill(" {0:<15} ".format("install-local:") + help_install_local,
width=TERM_WIDTH, subsequent_indent=' ' * 20) width=TERM_WIDTH, subsequent_indent=' ' * 20))
print "" print("")
print textwrap.fill(" {0:<15} ".format("drop-host:") + help_drop_host, print(textwrap.fill(" {0:<15} ".format("drop-host:") + help_drop_host,
width=TERM_WIDTH, subsequent_indent=' ' * 20) width=TERM_WIDTH, subsequent_indent=' ' * 20))
print "" print("")
print textwrap.fill(" {0:<15} ".format("query-dependencies:") + help_query_dependencies, print(textwrap.fill(" {0:<15} ".format("query-dependencies:") + help_query_dependencies,
width=TERM_WIDTH, subsequent_indent=' ' * 20) width=TERM_WIDTH, subsequent_indent=' ' * 20))
print "" print("")
print textwrap.fill(" {0:<15} ".format("commit:") + help_commit, print(textwrap.fill(" {0:<15} ".format("commit:") + help_commit,
width=TERM_WIDTH, subsequent_indent=' ' * 20) width=TERM_WIDTH, subsequent_indent=' ' * 20))
print "" print("")
print textwrap.fill(" {0:<15} ".format("--os-region-name:") + help_region_name, print(textwrap.fill(" {0:<15} ".format("--os-region-name:") + help_region_name,
width=TERM_WIDTH, subsequent_indent=' ' * 20) width=TERM_WIDTH, subsequent_indent=' ' * 20))
print "" print("")
exit(1) exit(1)
@ -157,25 +157,25 @@ def print_result_debug(req):
if req.status_code == 200: if req.status_code == 200:
data = json.loads(req.text) data = json.loads(req.text)
if 'pd' in data: if 'pd' in data:
print json.dumps(data['pd'], print(json.dumps(data['pd'],
sort_keys=True, sort_keys=True,
indent=4, indent=4,
separators=(',', ': ')) separators=(',', ': ')))
elif 'data' in data: elif 'data' in data:
print json.dumps(data['data'], print(json.dumps(data['data'],
sort_keys=True, sort_keys=True,
indent=4, indent=4,
separators=(',', ': ')) separators=(',', ': ')))
else: else:
print json.dumps(data, print(json.dumps(data,
sort_keys=True, sort_keys=True,
indent=4, indent=4,
separators=(',', ': ')) separators=(',', ': ')))
elif req.status_code == 500: elif req.status_code == 500:
print "An internal error has occurred. Please check /var/log/patching.log for details" print("An internal error has occurred. Please check /var/log/patching.log for details")
else: else:
m = re.search("(Error message:.*)", req.text, re.MULTILINE) m = re.search("(Error message:.*)", req.text, re.MULTILINE)
print m.group(0) print(m.group(0))
def print_patch_op_result(req): def print_patch_op_result(req):
@ -213,13 +213,13 @@ def print_patch_op_result(req):
show_repo = True show_repo = True
if show_repo: if show_repo:
print "{0:^{width_id}} {1:^{width_rr}} {2:^{width_rel}} {3:^{width_repo}} {4:^{width_state}}".format( print("{0:^{width_id}} {1:^{width_rr}} {2:^{width_rel}} {3:^{width_repo}} {4:^{width_state}}".format(
hdr_id, hdr_rr, hdr_rel, hdr_repo, hdr_state, hdr_id, hdr_rr, hdr_rel, hdr_repo, hdr_state,
width_id=width_id, width_rr=width_rr, width_id=width_id, width_rr=width_rr,
width_rel=width_rel, width_repo=width_repo, width_state=width_state) width_rel=width_rel, width_repo=width_repo, width_state=width_state))
print "{0} {1} {2} {3} {4}".format( print("{0} {1} {2} {3} {4}".format(
'=' * width_id, '=' * width_rr, '=' * width_rel, '=' * width_repo, '=' * width_state) '=' * width_id, '=' * width_rr, '=' * width_rel, '=' * width_repo, '=' * width_state))
for patch_id in sorted(pd.keys()): for patch_id in sorted(pd.keys()):
if "reboot_required" in pd[patch_id]: if "reboot_required" in pd[patch_id]:
@ -227,21 +227,21 @@ def print_patch_op_result(req):
else: else:
rr = "Y" rr = "Y"
print "{0:<{width_id}} {1:^{width_rr}} {2:^{width_rel}} {3:^{width_repo}} {4:^{width_state}}".format( print("{0:<{width_id}} {1:^{width_rr}} {2:^{width_rel}} {3:^{width_repo}} {4:^{width_state}}".format(
patch_id, patch_id,
rr, rr,
pd[patch_id]["sw_version"], pd[patch_id]["sw_version"],
pd[patch_id]["repostate"], pd[patch_id]["repostate"],
pd[patch_id]["patchstate"], pd[patch_id]["patchstate"],
width_id=width_id, width_rr=width_rr, width_id=width_id, width_rr=width_rr,
width_rel=width_rel, width_repo=width_repo, width_state=width_state) width_rel=width_rel, width_repo=width_repo, width_state=width_state))
else: else:
print "{0:^{width_id}} {1:^{width_rr}} {2:^{width_rel}} {3:^{width_state}}".format( print("{0:^{width_id}} {1:^{width_rr}} {2:^{width_rel}} {3:^{width_state}}".format(
hdr_id, hdr_rr, hdr_rel, hdr_state, hdr_id, hdr_rr, hdr_rel, hdr_state,
width_id=width_id, width_rr=width_rr, width_rel=width_rel, width_state=width_state) width_id=width_id, width_rr=width_rr, width_rel=width_rel, width_state=width_state))
print "{0} {1} {2} {3}".format( print("{0} {1} {2} {3}".format(
'=' * width_id, '=' * width_rr, '=' * width_rel, '=' * width_state) '=' * width_id, '=' * width_rr, '=' * width_rel, '=' * width_state))
for patch_id in sorted(pd.keys()): for patch_id in sorted(pd.keys()):
if "reboot_required" in pd[patch_id]: if "reboot_required" in pd[patch_id]:
@ -249,28 +249,28 @@ def print_patch_op_result(req):
else: else:
rr = "Y" rr = "Y"
print "{0:<{width_id}} {1:^{width_rr}} {2:^{width_rel}} {3:^{width_state}}".format( print("{0:<{width_id}} {1:^{width_rr}} {2:^{width_rel}} {3:^{width_state}}".format(
patch_id, patch_id,
rr, rr,
pd[patch_id]["sw_version"], pd[patch_id]["sw_version"],
pd[patch_id]["patchstate"], pd[patch_id]["patchstate"],
width_id=width_id, width_rr=width_rr, width_rel=width_rel, width_state=width_state) width_id=width_id, width_rr=width_rr, width_rel=width_rel, width_state=width_state))
print "" print("")
if 'info' in data and data["info"] != "": if 'info' in data and data["info"] != "":
print data["info"] print(data["info"])
if 'warning' in data and data["warning"] != "": if 'warning' in data and data["warning"] != "":
print "Warning:" print("Warning:")
print data["warning"] print(data["warning"])
if 'error' in data and data["error"] != "": if 'error' in data and data["error"] != "":
print "Error:" print("Error:")
print data["error"] print(data["error"])
elif req.status_code == 500: elif req.status_code == 500:
print "An internal error has occurred. Please check /var/log/patching.log for details" print("An internal error has occurred. Please check /var/log/patching.log for details")
def print_patch_show_result(req): def print_patch_show_result(req):
@ -280,93 +280,93 @@ def print_patch_show_result(req):
if 'metadata' in data: if 'metadata' in data:
pd = data['metadata'] pd = data['metadata']
for patch_id in sorted(pd.keys()): for patch_id in sorted(pd.keys()):
print "%s:" % patch_id print("%s:" % patch_id)
if "sw_version" in pd[patch_id] and pd[patch_id]["sw_version"] != "": if "sw_version" in pd[patch_id] and pd[patch_id]["sw_version"] != "":
print textwrap.fill(" {0:<15} ".format("Release:") + pd[patch_id]["sw_version"], print(textwrap.fill(" {0:<15} ".format("Release:") + pd[patch_id]["sw_version"],
width=TERM_WIDTH, subsequent_indent=' ' * 20) width=TERM_WIDTH, subsequent_indent=' ' * 20))
if "patchstate" in pd[patch_id] and pd[patch_id]["patchstate"] != "": if "patchstate" in pd[patch_id] and pd[patch_id]["patchstate"] != "":
print textwrap.fill(" {0:<15} ".format("Patch State:") + pd[patch_id]["patchstate"], print(textwrap.fill(" {0:<15} ".format("Patch State:") + pd[patch_id]["patchstate"],
width=TERM_WIDTH, subsequent_indent=' ' * 20) width=TERM_WIDTH, subsequent_indent=' ' * 20))
if pd[patch_id]["patchstate"] == "n/a": if pd[patch_id]["patchstate"] == "n/a":
if "repostate" in pd[patch_id] and pd[patch_id]["repostate"] != "": if "repostate" in pd[patch_id] and pd[patch_id]["repostate"] != "":
print textwrap.fill(" {0:<15} ".format("Repo State:") + pd[patch_id]["repostate"], print(textwrap.fill(" {0:<15} ".format("Repo State:") + pd[patch_id]["repostate"],
width=TERM_WIDTH, subsequent_indent=' ' * 20) width=TERM_WIDTH, subsequent_indent=' ' * 20))
if "status" in pd[patch_id] and pd[patch_id]["status"] != "": if "status" in pd[patch_id] and pd[patch_id]["status"] != "":
print textwrap.fill(" {0:<15} ".format("Status:") + pd[patch_id]["status"], print(textwrap.fill(" {0:<15} ".format("Status:") + pd[patch_id]["status"],
width=TERM_WIDTH, subsequent_indent=' ' * 20) width=TERM_WIDTH, subsequent_indent=' ' * 20))
if "unremovable" in pd[patch_id] and pd[patch_id]["unremovable"] != "": if "unremovable" in pd[patch_id] and pd[patch_id]["unremovable"] != "":
print textwrap.fill(" {0:<15} ".format("Unremovable:") + pd[patch_id]["unremovable"], print(textwrap.fill(" {0:<15} ".format("Unremovable:") + pd[patch_id]["unremovable"],
width=TERM_WIDTH, subsequent_indent=' ' * 20) width=TERM_WIDTH, subsequent_indent=' ' * 20))
if "reboot_required" in pd[patch_id] and pd[patch_id]["reboot_required"] != "": if "reboot_required" in pd[patch_id] and pd[patch_id]["reboot_required"] != "":
print textwrap.fill(" {0:<15} ".format("RR:") + pd[patch_id]["reboot_required"], print(textwrap.fill(" {0:<15} ".format("RR:") + pd[patch_id]["reboot_required"],
width=TERM_WIDTH, subsequent_indent=' ' * 20) width=TERM_WIDTH, subsequent_indent=' ' * 20))
if "summary" in pd[patch_id] and pd[patch_id]["summary"] != "": if "summary" in pd[patch_id] and pd[patch_id]["summary"] != "":
print textwrap.fill(" {0:<15} ".format("Summary:") + pd[patch_id]["summary"], print(textwrap.fill(" {0:<15} ".format("Summary:") + pd[patch_id]["summary"],
width=TERM_WIDTH, subsequent_indent=' ' * 20) width=TERM_WIDTH, subsequent_indent=' ' * 20))
if "description" in pd[patch_id] and pd[patch_id]["description"] != "": if "description" in pd[patch_id] and pd[patch_id]["description"] != "":
first_line = True first_line = True
for line in pd[patch_id]["description"].split('\n'): for line in pd[patch_id]["description"].split('\n'):
if first_line: if first_line:
print textwrap.fill(" {0:<15} ".format("Description:") + line, print(textwrap.fill(" {0:<15} ".format("Description:") + line,
width=TERM_WIDTH, subsequent_indent=' ' * 20) width=TERM_WIDTH, subsequent_indent=' ' * 20))
first_line = False first_line = False
else: else:
print textwrap.fill(line, print(textwrap.fill(line,
width=TERM_WIDTH, subsequent_indent=' ' * 20, width=TERM_WIDTH, subsequent_indent=' ' * 20,
initial_indent=' ' * 20) initial_indent=' ' * 20))
if "install_instructions" in pd[patch_id] and pd[patch_id]["install_instructions"] != "": if "install_instructions" in pd[patch_id] and pd[patch_id]["install_instructions"] != "":
print " Install Instructions:" print(" Install Instructions:")
for line in pd[patch_id]["install_instructions"].split('\n'): for line in pd[patch_id]["install_instructions"].split('\n'):
print textwrap.fill(line, print(textwrap.fill(line,
width=TERM_WIDTH, subsequent_indent=' ' * 20, width=TERM_WIDTH, subsequent_indent=' ' * 20,
initial_indent=' ' * 20) initial_indent=' ' * 20))
if "warnings" in pd[patch_id] and pd[patch_id]["warnings"] != "": if "warnings" in pd[patch_id] and pd[patch_id]["warnings"] != "":
first_line = True first_line = True
for line in pd[patch_id]["warnings"].split('\n'): for line in pd[patch_id]["warnings"].split('\n'):
if first_line: if first_line:
print textwrap.fill(" {0:<15} ".format("Warnings:") + line, print(textwrap.fill(" {0:<15} ".format("Warnings:") + line,
width=TERM_WIDTH, subsequent_indent=' ' * 20) width=TERM_WIDTH, subsequent_indent=' ' * 20))
first_line = False first_line = False
else: else:
print textwrap.fill(line, print(textwrap.fill(line,
width=TERM_WIDTH, subsequent_indent=' ' * 20, width=TERM_WIDTH, subsequent_indent=' ' * 20,
initial_indent=' ' * 20) initial_indent=' ' * 20))
if "requires" in pd[patch_id] and len(pd[patch_id]["requires"]) > 0: if "requires" in pd[patch_id] and len(pd[patch_id]["requires"]) > 0:
print " Requires:" print(" Requires:")
for req_patch in sorted(pd[patch_id]["requires"]): for req_patch in sorted(pd[patch_id]["requires"]):
print ' ' * 20 + req_patch print(' ' * 20 + req_patch)
if "contents" in data and patch_id in data["contents"]: if "contents" in data and patch_id in data["contents"]:
print " Contents:" print(" Contents:")
for pkg in sorted(data["contents"][patch_id]): for pkg in sorted(data["contents"][patch_id]):
print ' ' * 20 + pkg print(' ' * 20 + pkg)
print "\n" print("\n")
if 'info' in data and data["info"] != "": if 'info' in data and data["info"] != "":
print data["info"] print(data["info"])
if 'warning' in data and data["warning"] != "": if 'warning' in data and data["warning"] != "":
print "Warning:" print("Warning:")
print data["warning"] print(data["warning"])
if 'error' in data and data["error"] != "": if 'error' in data and data["error"] != "":
print "Error:" print("Error:")
print data["error"] print(data["error"])
elif req.status_code == 500: elif req.status_code == 500:
print "An internal error has occurred. Please check /var/log/patching.log for details" print("An internal error has occurred. Please check /var/log/patching.log for details")
def patch_upload_req(debug, args): def patch_upload_req(debug, args):
@ -380,11 +380,11 @@ def patch_upload_req(debug, args):
for patchfile in sorted(list(set(args))): for patchfile in sorted(list(set(args))):
if os.path.isdir(patchfile): if os.path.isdir(patchfile):
print "Error: %s is a directory. Please use upload-dir" % patchfile print("Error: %s is a directory. Please use upload-dir" % patchfile)
continue continue
if not os.path.isfile(patchfile): if not os.path.isfile(patchfile):
print "Error: File does not exist: %s" % patchfile print("Error: File does not exist: %s" % patchfile)
continue continue
enc = MultipartEncoder(fields={'file': (patchfile, enc = MultipartEncoder(fields={'file': (patchfile,
@ -528,7 +528,7 @@ def patch_commit_req(debug, args):
append_auth_token_if_required(headers) append_auth_token_if_required(headers)
if release and not all_patches: if release and not all_patches:
# Disallow # Disallow
print "Use of --release option requires --all" print("Use of --release option requires --all")
return 1 return 1
elif all_patches: elif all_patches:
# Get a list of all patches # Get a list of all patches
@ -544,17 +544,17 @@ def patch_commit_req(debug, args):
if 'pd' in data: if 'pd' in data:
patch_list = sorted(data['pd'].keys()) patch_list = sorted(data['pd'].keys())
elif req.status_code == 500: elif req.status_code == 500:
print "Failed to get patch list. Aborting..." print("Failed to get patch list. Aborting...")
return 1 return 1
if len(patch_list) == 0: if len(patch_list) == 0:
print "There are no %s patches to commit." % relopt print("There are no %s patches to commit." % relopt)
return 0 return 0
print "The following patches will be committed:" print("The following patches will be committed:")
for patch_id in patch_list: for patch_id in patch_list:
print " %s" % patch_id print(" %s" % patch_id)
print print()
patches = "/".join(patch_list) patches = "/".join(patch_list)
else: else:
@ -569,16 +569,16 @@ def patch_commit_req(debug, args):
data = json.loads(req.text) data = json.loads(req.text)
if 'patches' in data: if 'patches' in data:
print "The following patches will be committed:" print("The following patches will be committed:")
for patch_id in sorted(data['patches']): for patch_id in sorted(data['patches']):
print " %s" % patch_id print(" %s" % patch_id)
print print()
else: else:
print "No patches found to commit" print("No patches found to commit")
return 1 return 1
elif req.status_code == 500: elif req.status_code == 500:
print "An internal error has occurred. Please check /var/log/patching.log for details" print("An internal error has occurred. Please check /var/log/patching.log for details")
return 1 return 1
# Run dry-run # Run dry-run
@ -588,21 +588,21 @@ def patch_commit_req(debug, args):
print_patch_op_result(req) print_patch_op_result(req)
if check_rc(req) != 0: if check_rc(req) != 0:
print "Aborting..." print("Aborting...")
return 1 return 1
if dry_run: if dry_run:
return 0 return 0
print print()
commit_warning = "WARNING: Committing a patch is an irreversible operation. " + \ commit_warning = "WARNING: Committing a patch is an irreversible operation. " + \
"Committed patches cannot be removed." "Committed patches cannot be removed."
print textwrap.fill(commit_warning, width=TERM_WIDTH, subsequent_indent=' ' * 9) print(textwrap.fill(commit_warning, width=TERM_WIDTH, subsequent_indent=' ' * 9))
print print()
user_input = raw_input("Would you like to continue? [y/N]: ") user_input = raw_input("Would you like to continue? [y/N]: ")
if user_input.lower() != 'y': if user_input.lower() != 'y':
print "Aborting..." print("Aborting...")
return 1 return 1
url = "http://%s/patch/commit/%s" % (api_addr, patches) url = "http://%s/patch/commit/%s" % (api_addr, patches)
@ -659,7 +659,7 @@ def print_query_hosts_result(req):
if req.status_code == 200: if req.status_code == 200:
data = json.loads(req.text) data = json.loads(req.text)
if 'data' not in data: if 'data' not in data:
print "Invalid data returned:" print("Invalid data returned:")
print_result_debug(req) print_result_debug(req)
return return
@ -690,12 +690,12 @@ def print_query_hosts_result(req):
if len(agent["state"]) > width_state: if len(agent["state"]) > width_state:
width_state = len(agent["state"]) width_state = len(agent["state"])
print "{0:^{width_hn}} {1:^{width_ip}} {2:^{width_pc}} {3:^{width_rr}} {4:^{width_rel}} {5:^{width_state}}".format( print("{0:^{width_hn}} {1:^{width_ip}} {2:^{width_pc}} {3:^{width_rr}} {4:^{width_rel}} {5:^{width_state}}".format(
hdr_hn, hdr_ip, hdr_pc, hdr_rr, hdr_rel, hdr_state, hdr_hn, hdr_ip, hdr_pc, hdr_rr, hdr_rel, hdr_state,
width_hn=width_hn, width_ip=width_ip, width_pc=width_pc, width_rr=width_rr, width_rel=width_rel, width_state=width_state) width_hn=width_hn, width_ip=width_ip, width_pc=width_pc, width_rr=width_rr, width_rel=width_rel, width_state=width_state))
print "{0} {1} {2} {3} {4} {5}".format( print("{0} {1} {2} {3} {4} {5}".format(
'=' * width_hn, '=' * width_ip, '=' * width_pc, '=' * width_rr, '=' * width_rel, '=' * width_state) '=' * width_hn, '=' * width_ip, '=' * width_pc, '=' * width_rr, '=' * width_rel, '=' * width_state))
for agent in sorted(agents, key=lambda a: a["hostname"]): for agent in sorted(agents, key=lambda a: a["hostname"]):
patch_current_field = "Yes" if agent["patch_current"] else "No" patch_current_field = "Yes" if agent["patch_current"] else "No"
@ -705,17 +705,17 @@ def print_query_hosts_result(req):
if agent["patch_failed"]: if agent["patch_failed"]:
patch_current_field = "Failed" patch_current_field = "Failed"
print "{0:<{width_hn}} {1:<{width_ip}} {2:^{width_pc}} {3:^{width_rr}} {4:^{width_rel}} {5:^{width_state}}".format( print("{0:<{width_hn}} {1:<{width_ip}} {2:^{width_pc}} {3:^{width_rr}} {4:^{width_rel}} {5:^{width_state}}".format(
agent["hostname"], agent["hostname"],
agent["ip"], agent["ip"],
patch_current_field, patch_current_field,
"Yes" if agent["requires_reboot"] else "No", "Yes" if agent["requires_reboot"] else "No",
agent["sw_version"], agent["sw_version"],
agent["state"], agent["state"],
width_hn=width_hn, width_ip=width_ip, width_pc=width_pc, width_rr=width_rr, width_rel=width_rel, width_state=width_state) width_hn=width_hn, width_ip=width_ip, width_pc=width_pc, width_rr=width_rr, width_rel=width_rel, width_state=width_state))
elif req.status_code == 500: elif req.status_code == 500:
print "An internal error has occurred. Please check /var/log/patching.log for details" print("An internal error has occurred. Please check /var/log/patching.log for details")
def patch_query_hosts_req(debug, args): def patch_query_hosts_req(debug, args):
@ -800,10 +800,10 @@ def query_dependencies(debug, args):
if 'patches' in data: if 'patches' in data:
for patch_id in sorted(data['patches']): for patch_id in sorted(data['patches']):
print patch_id print(patch_id)
elif req.status_code == 500: elif req.status_code == 500:
print "An internal error has occurred. Please check /var/log/patching.log for details" print("An internal error has occurred. Please check /var/log/patching.log for details")
return check_rc(req) return check_rc(req)
@ -828,14 +828,14 @@ def wait_for_install_complete(agent_ip):
if retriable_count <= max_retries: if retriable_count <= max_retries:
continue continue
else: else:
print "Lost communications with the patch controller" print("Lost communications with the patch controller")
rc = 1 rc = 1
break break
if req.status_code == 200: if req.status_code == 200:
data = json.loads(req.text) data = json.loads(req.text)
if 'data' not in data: if 'data' not in data:
print "Invalid query-hosts data returned:" print("Invalid query-hosts data returned:")
print_result_debug(req) print_result_debug(req)
rc = 1 rc = 1
break break
@ -857,7 +857,7 @@ def wait_for_install_complete(agent_ip):
if retriable_count <= max_retries: if retriable_count <= max_retries:
continue continue
else: else:
print "%s agent has timed out." % agent_ip print("%s agent has timed out." % agent_ip)
rc = 1 rc = 1
break break
@ -867,29 +867,29 @@ def wait_for_install_complete(agent_ip):
sys.stdout.write(".") sys.stdout.write(".")
sys.stdout.flush() sys.stdout.flush()
elif state == constants.PATCH_AGENT_STATE_INSTALL_REJECTED: elif state == constants.PATCH_AGENT_STATE_INSTALL_REJECTED:
print "\nInstallation rejected. Node must be locked" print("\nInstallation rejected. Node must be locked")
rc = 1 rc = 1
break break
elif state == constants.PATCH_AGENT_STATE_INSTALL_FAILED: elif state == constants.PATCH_AGENT_STATE_INSTALL_FAILED:
print "\nInstallation failed. Please check logs for details." print("\nInstallation failed. Please check logs for details.")
rc = 1 rc = 1
break break
elif state == constants.PATCH_AGENT_STATE_IDLE: elif state == constants.PATCH_AGENT_STATE_IDLE:
print "\nInstallation was successful." print("\nInstallation was successful.")
rc = 0 rc = 0
break break
else: else:
print "\nPatch agent is reporting unknown state: %s" % state print("\nPatch agent is reporting unknown state: %s" % state)
rc = 1 rc = 1
break break
elif req.status_code == 500: elif req.status_code == 500:
print "An internal error has occurred. Please check /var/log/patching.log for details" print("An internal error has occurred. Please check /var/log/patching.log for details")
rc = 1 rc = 1
break break
else: else:
m = re.search("(Error message:.*)", req.text, re.MULTILINE) m = re.search("(Error message:.*)", req.text, re.MULTILINE)
print m.group(0) print(m.group(0))
rc = 1 rc = 1
break break
@ -920,17 +920,17 @@ def host_install(debug, args):
if req.status_code == 200: if req.status_code == 200:
data = json.loads(req.text) data = json.loads(req.text)
if 'error' in data and data["error"] != "": if 'error' in data and data["error"] != "":
print "Error:" print("Error:")
print data["error"] print(data["error"])
rc = 1 rc = 1
else: else:
rc = wait_for_install_complete(agent_ip) rc = wait_for_install_complete(agent_ip)
elif req.status_code == 500: elif req.status_code == 500:
print "An internal error has occurred. Please check /var/log/patching.log for details" print("An internal error has occurred. Please check /var/log/patching.log for details")
rc = 1 rc = 1
else: else:
m = re.search("(Error message:.*)", req.text, re.MULTILINE) m = re.search("(Error message:.*)", req.text, re.MULTILINE)
print m.group(0) print(m.group(0))
rc = 1 rc = 1
return rc return rc
@ -1015,7 +1015,7 @@ def patch_install_local(debug, args):
# First, check to see if the controller hostname is already known. # First, check to see if the controller hostname is already known.
if utils.gethostbyname(constants.CONTROLLER_FLOATING_HOSTNAME): if utils.gethostbyname(constants.CONTROLLER_FLOATING_HOSTNAME):
# If this is successful, disallow the install # If this is successful, disallow the install
print >>sys.stderr, "Error: This function can only be used before initial system configuration." print("Error: This function can only be used before initial system configuration.", file=sys.stderr)
return 1 return 1
# Ignore interrupts during this function # Ignore interrupts during this function
@ -1041,15 +1041,15 @@ def patch_install_local(debug, args):
# install patches but won't automatically reboot if the RR flag is set # install patches but won't automatically reboot if the RR flag is set
subprocess.check_output(['/etc/init.d/sw-patch', 'restart']) subprocess.check_output(['/etc/init.d/sw-patch', 'restart'])
except subprocess.CalledProcessError: except subprocess.CalledProcessError:
print >>sys.stderr, "Error: Failed to install patches. Please check /var/log/patching.log for details" print("Error: Failed to install patches. Please check /var/log/patching.log for details", file=sys.stderr)
rc = 1 rc = 1
# Restore /etc/hosts # Restore /etc/hosts
os.rename('/etc/hosts.patchbak', '/etc/hosts') os.rename('/etc/hosts.patchbak', '/etc/hosts')
if rc == 0: if rc == 0:
print "Patch installation is complete." print("Patch installation is complete.")
print "Please reboot before continuing with configuration." print("Please reboot before continuing with configuration.")
return rc return rc
@ -1108,7 +1108,7 @@ def completion_opts(args):
data = json.loads(req.text) data = json.loads(req.text)
if 'pd' in data: if 'pd' in data:
print " ".join(data['pd'].keys()) print(" ".join(data['pd'].keys()))
return 0 return 0
elif args[0] == "hosts": elif args[0] == "hosts":
@ -1121,7 +1121,7 @@ def completion_opts(args):
if 'data' in data: if 'data' in data:
for agent in data['data']: for agent in data['data']:
print agent["hostname"] print(agent["hostname"])
return 0 return 0
return 1 return 1
@ -1129,7 +1129,7 @@ def completion_opts(args):
def check_env(env, var): def check_env(env, var):
if env not in os.environ: if env not in os.environ:
print "You must provide a %s via env[%s]" % (var, env) print("You must provide a %s via env[%s]" % (var, env))
exit(-1) exit(-1)
@ -1160,7 +1160,7 @@ def get_auth_token_and_endpoint(region_name):
interface='internal', interface='internal',
region_name=region_name) region_name=region_name)
except (exceptions.http.Unauthorized, exceptions.EndpointNotFound) as e: except (exceptions.http.Unauthorized, exceptions.EndpointNotFound) as e:
print e.message print(e.message)
exit(-1) exit(-1)
return token, endpoint return token, endpoint
@ -1192,13 +1192,13 @@ def check_for_os_region_name():
for c, value in enumerate(sys.argv, 1): for c, value in enumerate(sys.argv, 1):
if value == region_option: if value == region_option:
if c == len(sys.argv): if c == len(sys.argv):
print "Please specify a region name" print("Please specify a region name")
print_help() print_help()
region = sys.argv[c] region = sys.argv[c]
global VIRTUAL_REGION global VIRTUAL_REGION
if region != VIRTUAL_REGION: if region != VIRTUAL_REGION:
print "Unsupported region name: %s" % region print("Unsupported region name: %s" % region)
exit(1) exit(1)
# check it is running on the active controller # check it is running on the active controller
@ -1246,8 +1246,8 @@ def main():
"host-install-async", "host-install-async",
"install-local", "drop-host"]): "install-local", "drop-host"]):
global VIRTUAL_REGION global VIRTUAL_REGION
print "\n%s command is not allowed in %s region" % (action, print("\n%s command is not allowed in %s region" % (action,
VIRTUAL_REGION) VIRTUAL_REGION))
exit(1) exit(1)
if auth_token is None and os.geteuid() != 0: if auth_token is None and os.geteuid() != 0:
@ -1263,7 +1263,7 @@ def main():
elif action == "--help" or action == "-h": elif action == "--help" or action == "-h":
print_help() print_help()
else: else:
print >>sys.stderr, "Error: Command must be run as sudo or root" print("Error: Command must be run as sudo or root", file=sys.stderr)
rc = 1 rc = 1
else: else:
if action == "upload": if action == "upload":

54
cgcs-patch/cgcs-patch/cgcs_patch/patch_functions.py
View File

@ -778,7 +778,7 @@ class PatchFile:
try: try:
subprocess.check_call(["sign-rpms", "-d", tmpdir]) subprocess.check_call(["sign-rpms", "-d", tmpdir])
except subprocess.CalledProcessError as e: except subprocess.CalledProcessError as e:
print "Failed to to add file signatures to RPMs. Call to sign-rpms process returned non-zero exit status %i" % e.returncode print("Failed to to add file signatures to RPMs. Call to sign-rpms process returned non-zero exit status %i" % e.returncode)
os.chdir(orig_wd) os.chdir(orig_wd)
shutil.rmtree(tmpdir) shutil.rmtree(tmpdir)
raise SystemExit(e.returncode) raise SystemExit(e.returncode)
@ -800,7 +800,7 @@ class PatchFile:
shutil.rmtree(tmpdir) shutil.rmtree(tmpdir)
print "Patch is %s" % patchfile print("Patch is %s" % patchfile)
@staticmethod @staticmethod
def write_patch(patchfile, cert_type=None): def write_patch(patchfile, cert_type=None):
@ -849,7 +849,7 @@ class PatchFile:
# Note: This can fail if the user is not authorized to sign with the formal key. # Note: This can fail if the user is not authorized to sign with the formal key.
subprocess.check_call(["sign_patch_formal.sh", patchfile]) subprocess.check_call(["sign_patch_formal.sh", patchfile])
except subprocess.CalledProcessError as e: except subprocess.CalledProcessError as e:
print "Failed to sign official patch. Call to sign_patch_formal.sh process returned non-zero exit status %i" % e.returncode print("Failed to sign official patch. Call to sign_patch_formal.sh process returned non-zero exit status %i" % e.returncode)
raise SystemExit(e.returncode) raise SystemExit(e.returncode)
@staticmethod @staticmethod
@ -1036,7 +1036,7 @@ class PatchFile:
except Exception as e: except Exception as e:
template = "An exception of type {0} occurred. Arguments:\n{1!r}" template = "An exception of type {0} occurred. Arguments:\n{1!r}"
message = template.format(type(e).__name__, e.args) message = template.format(type(e).__name__, e.args)
print message print(message)
finally: finally:
# Change back to original working dir # Change back to original working dir
os.chdir(orig_wd) os.chdir(orig_wd)
@ -1079,7 +1079,7 @@ class PatchFile:
patch_id = thispatch.parse_metadata("metadata.xml") patch_id = thispatch.parse_metadata("metadata.xml")
if patch_id is None: if patch_id is None:
print "Failed to import patch" print("Failed to import patch")
# Change back to original working dir # Change back to original working dir
os.chdir(orig_wd) os.chdir(orig_wd)
shutil.rmtree(tmpdir) shutil.rmtree(tmpdir)
@ -1188,26 +1188,26 @@ def patch_build():
'storage=', 'storage=',
'all-nodes=']) 'all-nodes='])
except getopt.GetoptError: except getopt.GetoptError:
print "Usage: %s [ <args> ] ... <rpm list>" \ print("Usage: %s [ <args> ] ... <rpm list>" \
% os.path.basename(sys.argv[0]) % os.path.basename(sys.argv[0]))
print "Options:" print("Options:")
print "\t--id <id> Patch ID" print("\t--id <id> Patch ID")
print "\t--release <version> Platform release version" print("\t--release <version> Platform release version")
print "\t--status <status> Patch Status Code (ie. O, R, V)" print("\t--status <status> Patch Status Code (ie. O, R, V)")
print "\t--unremovable Marks patch as unremovable" print("\t--unremovable Marks patch as unremovable")
print "\t--reboot-required <Y|N> Marks patch as reboot-required (default=Y)" print("\t--reboot-required <Y|N> Marks patch as reboot-required (default=Y)")
print "\t--summary <summary> Patch Summary" print("\t--summary <summary> Patch Summary")
print "\t--desc <description> Patch Description" print("\t--desc <description> Patch Description")
print "\t--warn <warnings> Patch Warnings" print("\t--warn <warnings> Patch Warnings")
print "\t--inst <instructions> Patch Install Instructions" print("\t--inst <instructions> Patch Install Instructions")
print "\t--req <patch_id> Required Patch" print("\t--req <patch_id> Required Patch")
print "\t--controller <rpm> New package for controller" print("\t--controller <rpm> New package for controller")
print "\t--compute <rpm> New package for compute node" print("\t--compute <rpm> New package for compute node")
print "\t--compute-lowlatency <rpm> New package for compute-lowlatency node" print("\t--compute-lowlatency <rpm> New package for compute-lowlatency node")
print "\t--storage <rpm> New package for storage node" print("\t--storage <rpm> New package for storage node")
print "\t--controller-compute <rpm> New package for combined node" print("\t--controller-compute <rpm> New package for combined node")
print "\t--controller-compute-lowlatency <rpm> New package for lowlatency combined node" print("\t--controller-compute-lowlatency <rpm> New package for lowlatency combined node")
print "\t--all-nodes <rpm> New package for all node types" print("\t--all-nodes <rpm> New package for all node types")
exit(1) exit(1)
pf = PatchFile() pf = PatchFile()
@ -1228,7 +1228,7 @@ def patch_build():
pf.meta.unremovable = "Y" pf.meta.unremovable = "Y"
elif opt == "--reboot-required": elif opt == "--reboot-required":
if arg != "Y" and arg != "N": if arg != "Y" and arg != "N":
print "The --reboot-required option requires either Y or N as argument." print("The --reboot-required option requires either Y or N as argument.")
exit(1) exit(1)
pf.meta.reboot_required = arg pf.meta.reboot_required = arg
elif opt == "--desc": elif opt == "--desc":
@ -1256,7 +1256,7 @@ def patch_build():
pf.add_rpm(arg, personality=opt[2:]) pf.add_rpm(arg, personality=opt[2:])
if pf.meta.id is None: if pf.meta.id is None:
print "The --id argument is mandatory." print("The --id argument is mandatory.")
exit(1) exit(1)
for rpmfile in remainder: for rpmfile in remainder:

2
cgcs-patch/cgcs-patch/cgcs_patch_id/patch_id_allocator.py
View File

@ -27,7 +27,7 @@ def get_unique_id(filename, digits=4):
file = posixfile.open(path, "w") file = posixfile.open(path, "w")
file.lock("w|", digits) file.lock("w|", digits)
except IOError: except IOError:
print "creation of file '%s' failed" % path print("creation of file '%s' failed" % path)
return -1 return -1
file.seek(0) # rewind file.seek(0) # rewind

14
cgcs-patch/cgcs-patch/cgcs_patch_id/patch_id_allocator_client.py
View File

@ -21,7 +21,7 @@ def request_patch_id(sw_version="1.01", prefix="CGCS"):
raw_parms = {} raw_parms = {}
raw_parms['sw_version'] = sw_version raw_parms['sw_version'] = sw_version
raw_parms['prefix'] = prefix raw_parms['prefix'] = prefix
print "raw_parms = %s" % str(raw_parms) print("raw_parms = %s" % str(raw_parms))
url = "http://%s:%d/get_patch_id" % (server, port) url = "http://%s:%d/get_patch_id" % (server, port)
params = urllib.urlencode(raw_parms) params = urllib.urlencode(raw_parms)
@ -36,23 +36,23 @@ def main():
prefix = None prefix = None
raw_parms = {} raw_parms = {}
print "optlist = %s" % str(optlist) print("optlist = %s" % str(optlist))
print "remainder = %s" % str(remainder) print("remainder = %s" % str(remainder))
for key, val in optlist: for key, val in optlist:
print "key = %s, val = %s" % (key, val) print("key = %s, val = %s" % (key, val))
if key == '--sw_version': if key == '--sw_version':
sw_version = val sw_version = val
print "sw_version = %s" % sw_version print("sw_version = %s" % sw_version)
raw_parms['sw_version'] = sw_version raw_parms['sw_version'] = sw_version
if key == '--prefix': if key == '--prefix':
prefix = val prefix = val
print "prefix = %s" % prefix print("prefix = %s" % prefix)
raw_parms['prefix'] = prefix raw_parms['prefix'] = prefix
# response = request_patch_id(sw_version=sw_version, prefix=prefix) # response = request_patch_id(sw_version=sw_version, prefix=prefix)
response = request_patch_id(**raw_parms) response = request_patch_id(**raw_parms)
print "response = %s" % str(response) print("response = %s" % str(response))
if __name__ == "__main__": if __name__ == "__main__":

24
tox.ini
View File

@ -52,16 +52,34 @@ commands =
[pep8] [pep8]
# Ignoring these warnings # Ignoring these warnings
# E501 line too long # E501 line too long
ignore = E501 ignore = E501
[flake8]
# ingore below errors , will fix flake8 errors in future
# E123, E125 skipped as they are invalid PEP-8.
# E128 continuation line under-indented for visual indent
# E305 expected 2 blank lines after class or function definition, found 1
# E501 skipped because some of the code files include templates
# that end up quite wide
# E502 the backslash is redundant between brackets
# E722 do not use bare except'
# E741 ambiguous variable name 'l'
# E999 SyntaxError: invalid token
# F401 'XXXXX' imported but unused
# F821 undefined name 'XXXX'
# F841 local variable 'XXXXXX' is assigned to but never used
show-source = True
ignore = E123,E125,E128,E305,E501,E502,E722,E741,E999,F401,F821,F841
exclude = .venv,.git,.tox,dist,doc,*lib/python*,*egg,build,release-tag-*
# Use flake8 to replace pep8.
[testenv:pep8] [testenv:pep8]
usedevelop = False usedevelop = False
skip_install = True skip_install = True
deps = deps =
pep8 flake8
commands = commands =
pep8 flake8
[testenv:venv] [testenv:venv]
commands = {posargs} commands = {posargs}