clear yamllint errors under stx-config

Listed below are the errors which were fixed as well as the actions
    [error] trailing spaces (trailing-spaces)
    --> delete spaces
    [error] too many blank lines (3 > 2)
    --> delete blank line
    [error] too few spaces after comma (commas)
    --> add space after comma
    [error] too many spaces inside brackets
    --> delete extra spaces
    [error] wrong indentation: expected XX but found XX (indentation)
    --> delete/add spaces to indente
    [error] line too long (97 > 80 characters) (line-length)
    --> change the line max length to 200
        cut the too long lines to 2 or 3 (by using '|-')
    [error] duplication of key "XXX" in mapping (key-duplicates)
    --> delete the duplication
    [warning] missing starting space in comment (comments)
    --> add blank after '#'
    [warning] truthy value should be true or false (truthy)
    --> lower case "False"/"True" to false/true

  Listed below are test cases done which run one controller and one compute in KVMs
    Test-Install           ----  success
    Test_create_instance   ----  success

  Now linters errors under stx-config is clear. Weee!!

Related commit: https://review.openstack.org/#/c/600473/

Story: 2003360
Task: 24411

Change-Id: Idc3c9304172be52c5d2fb2cbd862527066b72ecf
Signed-off-by: SidneyAn <ran1.an@intel.com>

.yamllint

@@ -0,0 +1,8 @@
+---
+extends: default
+
+rules:
+  # 80 chars should be enough, but don't fail if a line is longer
+  line-length:
+    max: 200
+    level: warning

puppet-manifests/src/hieradata/controller.yaml

@@ -512,7 +512,7 @@ ironic::db::postgresql::encoding: 'UTF8'
 ironic::logging::debug: false
 ironic::api::enabled: false
 ironic::conductor::enabled: false
-ironic::conductor::enabled_drivers: ['pxe_ipmitool','pxe_ipmitool_socat']
+ironic::conductor::enabled_drivers: ['pxe_ipmitool', 'pxe_ipmitool_socat']
 ironic::conductor::automated_clean: true
 ironic::conductor::default_boot_option: 'local'
 ironic::drivers::pxe::images_path: '/opt/img-conversions/ironic/images/'
@@ -528,7 +528,7 @@ dcmanager::use_syslog: true
 dcmanager::log_facility: 'local2'
 dcmanager::debug: false
 
-#FM
+# FM
 fm::use_syslog: true
 fm::log_facility: 'local2'
 fm::api::enable_proxy_headers_parsing: true
@@ -536,4 +536,3 @@ fm::db::sync::user: 'root'
 fm::database_idle_timeout: 60
 fm::database_max_overflow: 20
 fm::database_max_pool_size: 1
-

puppet-manifests/src/hieradata/global.yaml

@@ -42,14 +42,8 @@ neutron::vlan_transparent: true
 neutron::pnet_audit_enabled: false
 
 neutron::verbose: false
-neutron::root_helper: 'sudo'
 neutron::log_dir: false
 neutron::use_syslog: true
-neutron::host_driver: 'neutron.plugins.wrs.drivers.host.DefaultHostDriver'
-neutron::fm_driver: 'neutron.plugins.wrs.drivers.fm.DefaultFmDriver'
-neutron::vlan_transparent: true
-neutron::state_path: '/var/run/neutron'
-neutron::lock_path: '/var/run/neutron/lock'
 neutron::notification_driver: ['messagingv2']
 neutron::dns_domain: 'openstacklocal'
 
@@ -59,7 +53,6 @@ nova::use_syslog: true
 nova::debug: false
 nova::log_facility: 'local6'
 nova::notification_driver: 'messagingv2'
-nova::notify_on_state_change: 'vm_and_task_state'
 nova::cinder_catalog_info: 'volumev2:cinderv2:internalURL'
 nova::notify_on_state_change: 'vm_and_task_state'
 
@@ -104,7 +97,7 @@ platform::collectd::params::collectd_d_dir: '/etc/collectd.d'
 
 # collectd: module named plugins
 platform::collectd::params::module_path: '/opt/collectd/extensions/python'
-platform::collectd::params::plugins: ['fm_notifier','mtce_notifier']
+platform::collectd::params::plugins: ['fm_notifier', 'mtce_notifier']
 platform::collectd::params::mtce_notifier_port: 2101
 platform::collectd::params::log_traces: true
 platform::collectd::params::encoding: "utf-8"

tox.ini

@@ -24,11 +24,11 @@ commands =
          -print0 | xargs -0 bashate -v -e E*  \
          -i E006,E010"
 
-#  bash -c "find {toxinidir}        \
-#        \( -name .tox -prune \)         \
-#        -o -type f -name '*.yaml'       \
-#        -print0 | xargs -0 yamllint -f parsable \
-#        -c {toxinidir}/.yamllint"
+  bash -c "find {toxinidir}        \
+        \( -name .tox -prune \)         \
+        -o -type f -name '*.yaml'       \
+        -print0 | xargs -0 yamllint -f parsable \
+        -c {toxinidir}/.yamllint"
 
 [testenv:pep8]
 usedevelop = False