starlingx
/
config
Code Issues Proposed changes

Update patch set 11 

Patch Set 11:

(1 comment)

Patch-set: 11
Attention: {"person_ident":"Gerrit User 33390 \u003c33390@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_33390\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 33684 \u003c33684@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_33390\u003e replied on the change"}
This commit is contained in:
Gerrit User 33390 2024-04-26 13:18:29 +00:00 committed by Gerrit Code Review
parent dae0b5f640
commit fdd0be52e1
1 changed files with 27 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
9ce242f20e1a586a7a310339e63e386e75877ab5 Normal file
View File

@ -0,0 +1,27 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "fcf3649f_147da7b6",
"filename": "sysinv/sysinv/sysinv/sysinv/conductor/manager.py",
"patchSetId": 11
},
"lineNbr": 1937,
"author": {
"id": 33390
},
"writtenOn": "2024-04-26T13:18:29Z",
"side": 1,
"message": "There are other places where the version is read/write from loads table, e.g. \n\nhttps://opendev.org/starlingx/config/src/commit/64021ed7dac40d3825a1001ffa42812fc5296d47/sysinv/sysinv/sysinv/sysinv/agent/manager.py#L975-L981\n\nhttps://opendev.org/starlingx/config/src/commit/64021ed7dac40d3825a1001ffa42812fc5296d47/sysinv/sysinv/sysinv/sysinv/conductor/manager.py#L2457-L2480\n\nAre these going to be addressed by another commit? If so, it\u0027s worth mentioning in the commit message.",
"range": {
"startLine": 1936,
"startChar": 12,
"endLine": 1937,
"endChar": 40
},
"revId": "9ce242f20e1a586a7a310339e63e386e75877ab5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}