starlingx
/
distcloud
Code Issues Proposed changes

Update patch set 17 

Patch Set 17:

(4 comments)

Patch-set: 17
Attention: {"person_ident":"Gerrit User 35230 \u003c35230@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_35230\u003e replied on the change"}
This commit is contained in:
Gerrit User 35230 2024-05-07 13:29:49 +00:00 committed by Gerrit Code Review
parent b2f5b4aa2a
commit feb590b2f8
2 changed files with 90 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
362bfbc4f4b1b8493fe1c7f27134b7514d408dc4
View File

@ -288,6 +288,30 @@
"revId": "362bfbc4f4b1b8493fe1c7f27134b7514d408dc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "c28f8fb1_d0be4a00",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 11
},
"lineNbr": 662,
"author": {
"id": 35230
},
"writtenOn": "2024-05-07T13:29:49Z",
"side": 1,
"message": "The current assertions do not verify the call order, it only checks if it was called or not.\n\nHere\u0027s an example on how the call order could be verified:\nhttps://stackoverflow.com/a/22677452",
"parentUuid": "3fbb4881_98b6c116",
"range": {
"startLine": 654,
"startChar": 0,
"endLine": 662,
"endChar": 9
},
"revId": "362bfbc4f4b1b8493fe1c7f27134b7514d408dc4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {

66
da6df0e7527e75e5976a82f63d788195d9cc7d88
View File

@ -129,6 +129,24 @@
"revId": "da6df0e7527e75e5976a82f63d788195d9cc7d88",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "effddef3_82755fd6",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 14
},
"lineNbr": 3660,
"author": {
"id": 35230
},
"writtenOn": "2024-05-07T13:29:49Z",
"side": 1,
"message": "Could you please also add the assert_not_called() to the test_unmanage_system_peer_subcloud_ret_true test bellow?",
"parentUuid": "4d819eee_0cf5ce9d",
"revId": "da6df0e7527e75e5976a82f63d788195d9cc7d88",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -176,6 +194,30 @@
"revId": "da6df0e7527e75e5976a82f63d788195d9cc7d88",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "09904b32_961d9bdc",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 14
},
"lineNbr": 3964,
"author": {
"id": 35230
},
"writtenOn": "2024-05-07T13:29:49Z",
"side": 1,
"message": "Considering that this test is to verify the ansible_files during subcloud renaming, it\u0027s still worth verifying that it was renamed. Currently we only check that the subcloud was renamed in the DB.",
"parentUuid": "83f4bd71_b996c9cc",
"range": {
"startLine": 3964,
"startChar": 8,
"endLine": 3964,
"endChar": 76
},
"revId": "da6df0e7527e75e5976a82f63d788195d9cc7d88",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -222,6 +264,30 @@
},
"revId": "da6df0e7527e75e5976a82f63d788195d9cc7d88",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "535d2813_70c8e8bf",
"filename": "distributedcloud/dcmanager/tests/unit/manager/test_subcloud_manager.py",
"patchSetId": 14
},
"lineNbr": 3974,
"author": {
"id": 35230
},
"writtenOn": "2024-05-07T13:29:49Z",
"side": 1,
"message": "nit: You can also move the new_subcloud_name",
"parentUuid": "bcbc5719_ed95e7bb",
"range": {
"startLine": 3973,
"startChar": 8,
"endLine": 3974,
"endChar": 67
},
"revId": "da6df0e7527e75e5976a82f63d788195d9cc7d88",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}