starlingx
/
ha
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(3 comments)

Patch-set: 1
Attention: {"person_ident":"Gerrit User 35741 \u003c35741@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_35741\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 35022 \u003c35022@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_35741\u003e replied on the change"}
This commit is contained in:
Gerrit User 35741 2024-01-12 17:22:37 +00:00 committed by Gerrit Code Review
parent e29a459a48
commit 2a8e9aeab5
1 changed files with 54 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
ba7929d90721ceccda51faed2886c5952595fb9d
View File

@ -40,6 +40,24 @@
"revId": "ba7929d90721ceccda51faed2886c5952595fb9d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "bd0cbffb_21e7334e",
"filename": "service-mgmt/sm-db/database/create_sm_db.sql",
"patchSetId": 1
},
"lineNbr": 171,
"author": {
"id": 35741
},
"writtenOn": "2024-01-12T17:22:37Z",
"side": 1,
"message": "I don\u0027t think so. The reverse dependency is not necessary",
"parentUuid": "aad3230f_3bb2f861",
"revId": "ba7929d90721ceccda51faed2886c5952595fb9d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -73,6 +91,42 @@
"message": "like the oam-ip depends that haproxy is disabled in order to be disabled too, \nI believe you need to add here the same dependency to disable the dnsmasq.",
"revId": "ba7929d90721ceccda51faed2886c5952595fb9d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "b1acd575_5b7a781a",
"filename": "service-mgmt/sm-db/database/create_sm_db.sql",
"patchSetId": 1
},
"lineNbr": 210,
"author": {
"id": 35741
},
"writtenOn": "2024-01-12T17:22:37Z",
"side": 1,
"message": "Acknowledged",
"parentUuid": "9e9eae0b_e6566fef",
"revId": "ba7929d90721ceccda51faed2886c5952595fb9d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "321884bd_1776690c",
"filename": "service-mgmt/sm-db/database/create_sm_db.sql",
"patchSetId": 1
},
"lineNbr": 210,
"author": {
"id": 35741
},
"writtenOn": "2024-01-12T17:22:37Z",
"side": 1,
"message": "Acknowledged",
"parentUuid": "ec5b5763_539bb2a2",
"revId": "ba7929d90721ceccda51faed2886c5952595fb9d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}