Update patch set 3

Patch Set 3: Code-Review+2

(1 comment)

Patch-set: 3
Reviewer: Gerrit User 28464 <28464@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+2, fcfada3bf9f243fe4bccd8d800ebbade34873cbd
Attention: {"person_ident":"Gerrit User 28464 \u003c28464@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_28464\u003e replied on the change"}
This commit is contained in:
Gerrit User 28464 2024-04-20 13:39:43 +00:00 committed by Gerrit Code Review
parent cd0578c794
commit 4794459778
1 changed files with 17 additions and 0 deletions

View File

@ -1,5 +1,22 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "e09da03c_17ed6632",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 3
},
"lineNbr": 0,
"author": {
"id": 28464
},
"writtenOn": "2024-04-20T13:39:43Z",
"side": 1,
"message": "I know that Fabiano delivered the update https://review.opendev.org/c/starlingx/metal/+/914696/4/kickstart/files/kickstart.cfg that is now being discarded for an IP address only based solution. His original solution considered very seriously this precise change but upgrades was a concern.\n\nSeems from the commit message that dual stack handling has exposed another challenge in this area causing us to flop back to the ip address only based solution.\n\nYou need to verify that this solution will work for the upgrade case, at least to the point of the upgrade install working, even if end-to-end upgrade may not be.\n\nI will +2 knowing that the dual-stack feature will eventually need to be upgrades tested.",
"revId": "9821652bc8174cc8a037b160421af23992a7dc7e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {