starlingx
/
specs
Code Issues Proposed changes

Update patch set 10 

Patch Set 10:

(17 comments)

Patch-set: 10
Attention: {"person_ident":"Gerrit User 28652 \u003c28652@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_35858\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 24777 \u003c24777@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_35858\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 35858 \u003c35858@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_35858\u003e replied on the change"}
This commit is contained in:
Gerrit User 35858 2023-06-19 14:14:21 +00:00 committed by Gerrit Code Review
parent 15b6623d81
commit f8c5c8af55
4 changed files with 309 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

90
c2433c94003bf0991b027c449ffeb4079a901e8a
View File

@ -17,6 +17,24 @@
"revId": "c2433c94003bf0991b027c449ffeb4079a901e8a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "0f74d662_4e1c4ae6",
"filename": "/COMMIT_MSG",
"patchSetId": 7
},
"lineNbr": 8,
"author": {
"id": 35858
},
"writtenOn": "2023-06-19T14:14:21Z",
"side": 1,
"message": "Thanks for the review Jim, addressed all comments and committed fixed file. I tried to keep lines length lower than 79, deleted white spaces, ran it through spellchecker and added StoryBoard info.",
"parentUuid": "2763b169_0d64277d",
"revId": "c2433c94003bf0991b027c449ffeb4079a901e8a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -34,6 +52,24 @@
"revId": "c2433c94003bf0991b027c449ffeb4079a901e8a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "1fe2e358_7716ce7d",
"filename": "/COMMIT_MSG",
"patchSetId": 7
},
"lineNbr": 9,
"author": {
"id": 35858
},
"writtenOn": "2023-06-19T14:14:21Z",
"side": 1,
"message": "Done",
"parentUuid": "2b9ac6ee_c0fe56b1",
"revId": "c2433c94003bf0991b027c449ffeb4079a901e8a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -51,6 +87,24 @@
"revId": "c2433c94003bf0991b027c449ffeb4079a901e8a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "991fa23e_7b937b7b",
"filename": "doc/source/specs/stx-9.0/approved/IEO_Starlingx_Spec_submission.rst",
"patchSetId": 7
},
"lineNbr": 3,
"author": {
"id": 35858
},
"writtenOn": "2023-06-19T14:14:21Z",
"side": 1,
"message": "Done",
"parentUuid": "77f0d9c4_427df189",
"revId": "c2433c94003bf0991b027c449ffeb4079a901e8a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -68,6 +122,24 @@
"revId": "c2433c94003bf0991b027c449ffeb4079a901e8a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "d8f258e6_de4fde81",
"filename": "doc/source/specs/stx-9.0/approved/IEO_Starlingx_Spec_submission.rst",
"patchSetId": 7
},
"lineNbr": 218,
"author": {
"id": 35858
},
"writtenOn": "2023-06-19T14:14:21Z",
"side": 1,
"message": "Done",
"parentUuid": "38a276f2_e0dc9aaa",
"revId": "c2433c94003bf0991b027c449ffeb4079a901e8a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -102,6 +174,24 @@
"parentUuid": "d0f28b1e_c67a8dd6",
"revId": "c2433c94003bf0991b027c449ffeb4079a901e8a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "5b450905_57f55e56",
"filename": "doc/source/specs/stx-9.0/approved/IEO_Starlingx_Spec_submission.rst",
"patchSetId": 7
},
"lineNbr": 299,
"author": {
"id": 35858
},
"writtenOn": "2023-06-19T14:14:21Z",
"side": 1,
"message": "One thing to have in mind with this is that stx-ice.pkg sets the DDP package for all E810 cards on one node. To set DDP package for specific card it needs to be named ice-\u003cserial-number\u003e.pkg. File named this way always has priority for this specific card over the stx-ice.pkg.",
"parentUuid": "ee03942e_da473511",
"revId": "c2433c94003bf0991b027c449ffeb4079a901e8a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

22
c49b4608bcee8afe563fcd2d28661688b19c41a1 Normal file
View File

@ -0,0 +1,22 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "fc3c5916_04a359fa",
"filename": "doc/source/specs/stx-9.0/approved/IEO_Starlingx_Spec_submission.rst",
"patchSetId": 8
},
"lineNbr": 347,
"author": {
"id": 35858
},
"writtenOn": "2023-06-19T14:14:21Z",
"side": 1,
"message": "\u003e docs: Unexpected indentation.\n\nPlease fix.",
"parentUuid": "2e69fb62_72e8c33c",
"revId": "c49b4608bcee8afe563fcd2d28661688b19c41a1",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

180
de346378e56ab979825cf566c5852831b60fa10f
View File

@ -17,6 +17,24 @@
"revId": "de346378e56ab979825cf566c5852831b60fa10f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "2da40f23_abf339e1",
"filename": "/COMMIT_MSG",
"patchSetId": 9
},
"lineNbr": 10,
"author": {
"id": 35858
},
"writtenOn": "2023-06-19T14:14:21Z",
"side": 1,
"message": "Done",
"parentUuid": "c24583ba_5086de6e",
"revId": "de346378e56ab979825cf566c5852831b60fa10f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
@ -51,6 +69,24 @@
"revId": "de346378e56ab979825cf566c5852831b60fa10f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "940095d5_4ab7d7c6",
"filename": "doc/source/specs/stx-9.0/approved/IEO_Starlingx_Spec_submission.rst",
"patchSetId": 9
},
"lineNbr": 45,
"author": {
"id": 35858
},
"writtenOn": "2023-06-19T14:14:21Z",
"side": 1,
"message": "Done",
"parentUuid": "fc309e2b_25c8cbad",
"revId": "de346378e56ab979825cf566c5852831b60fa10f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -68,6 +104,24 @@
"revId": "de346378e56ab979825cf566c5852831b60fa10f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "fa7e33c8_30ed5179",
"filename": "doc/source/specs/stx-9.0/approved/IEO_Starlingx_Spec_submission.rst",
"patchSetId": 9
},
"lineNbr": 46,
"author": {
"id": 35858
},
"writtenOn": "2023-06-19T14:14:21Z",
"side": 1,
"message": "Done",
"parentUuid": "f1b5acf5_2d9b9de1",
"revId": "de346378e56ab979825cf566c5852831b60fa10f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -85,6 +139,24 @@
"revId": "de346378e56ab979825cf566c5852831b60fa10f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "b5a55418_36d4912b",
"filename": "doc/source/specs/stx-9.0/approved/IEO_Starlingx_Spec_submission.rst",
"patchSetId": 9
},
"lineNbr": 77,
"author": {
"id": 35858
},
"writtenOn": "2023-06-19T14:14:21Z",
"side": 1,
"message": "Done",
"parentUuid": "f5fb6d08_5bc7ec15",
"revId": "de346378e56ab979825cf566c5852831b60fa10f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -102,6 +174,24 @@
"revId": "de346378e56ab979825cf566c5852831b60fa10f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "27e39611_0c0d576e",
"filename": "doc/source/specs/stx-9.0/approved/IEO_Starlingx_Spec_submission.rst",
"patchSetId": 9
},
"lineNbr": 87,
"author": {
"id": 35858
},
"writtenOn": "2023-06-19T14:14:21Z",
"side": 1,
"message": "Done",
"parentUuid": "8034d9dd_fae64688",
"revId": "de346378e56ab979825cf566c5852831b60fa10f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -119,6 +209,24 @@
"revId": "de346378e56ab979825cf566c5852831b60fa10f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "aa8df34a_99dea8f6",
"filename": "doc/source/specs/stx-9.0/approved/IEO_Starlingx_Spec_submission.rst",
"patchSetId": 9
},
"lineNbr": 106,
"author": {
"id": 35858
},
"writtenOn": "2023-06-19T14:14:21Z",
"side": 1,
"message": "Done",
"parentUuid": "10d261df_cc26bfff",
"revId": "de346378e56ab979825cf566c5852831b60fa10f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -136,6 +244,24 @@
"revId": "de346378e56ab979825cf566c5852831b60fa10f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "e8920b1f_045ac804",
"filename": "doc/source/specs/stx-9.0/approved/IEO_Starlingx_Spec_submission.rst",
"patchSetId": 9
},
"lineNbr": 113,
"author": {
"id": 35858
},
"writtenOn": "2023-06-19T14:14:21Z",
"side": 1,
"message": "Done",
"parentUuid": "f933d268_65e10bb7",
"revId": "de346378e56ab979825cf566c5852831b60fa10f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -153,6 +279,24 @@
"revId": "de346378e56ab979825cf566c5852831b60fa10f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "e45818a8_6ceae79c",
"filename": "doc/source/specs/stx-9.0/approved/IEO_Starlingx_Spec_submission.rst",
"patchSetId": 9
},
"lineNbr": 141,
"author": {
"id": 35858
},
"writtenOn": "2023-06-19T14:14:21Z",
"side": 1,
"message": "We use SHA-1 for download integrity of both fw and ddp.",
"parentUuid": "bfe1a152_38a9abfd",
"revId": "de346378e56ab979825cf566c5852831b60fa10f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -170,6 +314,24 @@
"revId": "de346378e56ab979825cf566c5852831b60fa10f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "5292f0ff_337e43ca",
"filename": "doc/source/specs/stx-9.0/approved/IEO_Starlingx_Spec_submission.rst",
"patchSetId": 9
},
"lineNbr": 254,
"author": {
"id": 35858
},
"writtenOn": "2023-06-19T14:14:21Z",
"side": 1,
"message": "Done",
"parentUuid": "365297f0_6572657e",
"revId": "de346378e56ab979825cf566c5852831b60fa10f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -186,6 +348,24 @@
"message": "believe to be",
"revId": "de346378e56ab979825cf566c5852831b60fa10f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "2f5bf5c8_b172c173",
"filename": "doc/source/specs/stx-9.0/approved/IEO_Starlingx_Spec_submission.rst",
"patchSetId": 9
},
"lineNbr": 256,
"author": {
"id": 35858
},
"writtenOn": "2023-06-19T14:14:21Z",
"side": 1,
"message": "Done",
"parentUuid": "45757b5e_cae20d4a",
"revId": "de346378e56ab979825cf566c5852831b60fa10f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

17
f56c4f46fa118c34ff34ebabd4b6011a07a6fb6a
View File

@ -51,6 +51,23 @@
"revId": "f56c4f46fa118c34ff34ebabd4b6011a07a6fb6a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "2dbbd062_2bab22e7",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 10
},
"lineNbr": 0,
"author": {
"id": 35858
},
"writtenOn": "2023-06-19T14:14:21Z",
"side": 1,
"message": "Marked comments as resolved.",
"revId": "f56c4f46fa118c34ff34ebabd4b6011a07a6fb6a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {