starlingx
/
update
Code Issues Proposed changes

Update patch set 4 

Patch Set 4:

(3 comments)

Patch-set: 4
Attention: {"person_ident":"Gerrit User 9926 \u003c9926@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_9926\u003e replied on the change"}
This commit is contained in:
Gerrit User 9926 2024-04-26 19:09:57 +00:00 committed by Gerrit Code Review
parent f4e9ad37c3
commit 0a1fad54dd
1 changed files with 69 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

69
0c7cdcc94a07efdb8c323179322e46a6a7ce99a8
View File

@ -1,5 +1,74 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "7a9ab605_59b98086",
"filename": "software/software/software_controller.py",
"patchSetId": 4
},
"lineNbr": 2739,
"author": {
"id": 9926
},
"writtenOn": "2024-04-26T19:09:57Z",
"side": 1,
"message": "this variable isnt really required, since not referenced elsewhere",
"range": {
"startLine": 2739,
"startChar": 8,
"endLine": 2739,
"endChar": 28
},
"revId": "0c7cdcc94a07efdb8c323179322e46a6a7ce99a8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "36b04eef_e0738a11",
"filename": "software/software/software_controller.py",
"patchSetId": 4
},
"lineNbr": 3047,
"author": {
"id": 9926
},
"writtenOn": "2024-04-26T19:09:57Z",
"side": 1,
"message": "this should resuse self._get_software_upgrade() to obtain the from_release, to_release",
"range": {
"startLine": 3044,
"startChar": 0,
"endLine": 3047,
"endChar": 60
},
"revId": "0c7cdcc94a07efdb8c323179322e46a6a7ce99a8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "ca89c4ae_f35883ad",
"filename": "software/software/software_controller.py",
"patchSetId": 4
},
"lineNbr": 3050,
"author": {
"id": 9926
},
"writtenOn": "2024-04-26T19:09:57Z",
"side": 1,
"message": "This may not be needed if all we need to do is check the return value of from_release and to_release from _get_software_upgrade() ... \n\notherwise, could this check use some of the Version methods?\n\n\nfrom_release \u003d version.Version(from_release)\nto_release \u003d version.Version(to_release)\n\nif from_release.major !\u003d to_release.major or from_release.minor !\u003d to_release.minor: \n\n....",
"range": {
"startLine": 3048,
"startChar": 1,
"endLine": 3050,
"endChar": 82
},
"revId": "0c7cdcc94a07efdb8c323179322e46a6a7ce99a8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {